Code

[WIP] Clean up BaseOptionsSelector#37353

Code

Closed

roryabraham wants to merge 25 commits intomainExpensify/App:mainfrom Rory-BaseOptionsSelectorImprovementsExpensify/App:Rory-BaseOptionsSelectorImprovementsCopy head branch name to clipboard

+98-290

Commits

Commits on Feb 27, 2024

• Use useArrowKeyFocusManager hook instead of ArrowKeyFocusManager component

  roryabraham

  committed
  21bc3e6

• Remove unnecessary focusedOption state variable

  roryabraham

  committed
  5c81404

• Remove unnecessary useMemo, initialize state with function

  roryabraham

  committed
  af46a8a

• Use memo instead of state for allOptions

  roryabraham

  committed
  2748829

• use memo not state for paginated sections

  roryabraham

  committed
  5f1b6e3

• Get rid of unnecessary prevLocale and prevPaginationPage

  roryabraham

  committed
  bbd1ce3

• Use ref not state for shouldDisableRowSelection

  roryabraham

  committed
  269b813

• Remove duplicate keyboard logic for enter and ctrl+enter

  roryabraham

  committed
  b747acf

• Improve typing of ActiveElementRoleProvider

  roryabraham

  committed
  ab6d66c

• Use useActiveElementRole hook directly

  roryabraham

  committed
  2d59cf3

• use forwardRef directly

  roryabraham

  committed
  bc3f695

• Use usePrevious utility hook

  roryabraham

  committed
  e402317

• Undo bad ref change

  roryabraham

  committed
  4c05b9e

• Help reduce diff a bit

  roryabraham

  committed
  91c956b

• don't re-calculate focusedIndex unless options actually change

  roryabraham

  committed
  684be84

• Use canFocusInputOnScreenFocus rather than getPlatform

  roryabraham

  committed
  6641c00

Commits on Feb 28, 2024

• Use useAutoFocusInput hook

  roryabraham

  committed
  e3f13dd

• Remove unnecessary canFocusInputOnScreenFocus

  roryabraham

  committed
  1ffd5c6

• Remove unused focusTimeout ref

  roryabraham

  committed
  e6ee35f

• Merge branch 'main' into Rory-BaseOptionsSelectorImprovements

  Show description for 82d9773
  roryabraham

  committed
  82d9773

• make sure enter keyboard shortcut is only active if the screen is focused

  roryabraham

  committed
  9990129

• Add back accidentally removed hook import

  roryabraham

  committed
  5288a65

• Remove adjustedSectionIndex

  roryabraham

  committed
  43b8266

• Merge branch 'main' into Rory-BaseOptionsSelectorImprovements

  roryabraham

  committed
  c068e3d

• Use paginated sections to generate allOptions

  roryabraham

  committed
  b031d1e