Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[TS migration] Migrate withFullTransactionOrNotFound HOC" #37572

Merged

Conversation

tylerkaraszewski
Copy link
Contributor

@tylerkaraszewski tylerkaraszewski requested a review from a team as a code owner February 29, 2024 22:33
@tylerkaraszewski tylerkaraszewski self-assigned this Feb 29, 2024
@melvin-bot melvin-bot bot removed the request for review from a team February 29, 2024 22:34
Copy link

melvin-bot bot commented Feb 29, 2024

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from arosiclair February 29, 2024 22:34
@cead22
Copy link
Contributor

cead22 commented Feb 29, 2024

The TS check fails with "ERROR: Found new JavaScript files in the project; use TypeScript instead.", so we won't be able to get it to pass, so I don't think it's worth it to fill out the author and reviewer checklists to make those checks pass

TS passed on dev

Expensidev/App (revert-36855-ts-migration/withFullTransactionOrNotFound-hoc) $ npm run typecheck

> [email protected] typecheck
> tsc

image

@cead22 cead22 merged commit 48f6512 into main Feb 29, 2024
12 of 15 checks passed
@cead22 cead22 deleted the revert-36855-ts-migration/withFullTransactionOrNotFound-hoc branch February 29, 2024 23:07
Copy link

melvin-bot bot commented Feb 29, 2024

@cead22 looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Feb 29, 2024
@cead22
Copy link
Contributor

cead22 commented Feb 29, 2024

See #37572 (comment) for why this was merged without some checks passing, other than this being a straight revert. This is not an emergency change

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.46-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 4, 2024

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.46-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants