-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[TS migration] Migrate withFullTransactionOrNotFound HOC" #37572
Revert "[TS migration] Migrate withFullTransactionOrNotFound HOC" #37572
Conversation
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
The TS check fails with "ERROR: Found new JavaScript files in the project; use TypeScript instead.", so we won't be able to get it to pass, so I don't think it's worth it to fill out the author and reviewer checklists to make those checks pass TS passed on dev
|
@cead22 looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
See #37572 (comment) for why this was merged without some checks passing, other than this being a straight revert. This is not an emergency change |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.46-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.46-2 🚀
|
Reverts #36855
PR caused this failure: https://github.com/Expensify/App/actions/runs/8100690545