Fix/37098: In app sound is played if user not viewing chat #37872

dukenv0307 · 2024-03-07T08:59:12Z

Details

In this PR, we will:

In background, always mute in-app sounds
In foreground, mute in-app sounds when user is not actively viewing a chat

Fixed Issues

$ #37098
PROPOSAL: #37098 (comment)

Tests

In web:

Log in with user A
User A: Open a chat with user B
User A: Open a new tab
User B: Send any message
User A: Verify that No sounds play for the received message
User A: Back to the tab in step 2
User B: Send any message
User A: Verify that there is a sound play for the received message
User A: Open another chat that with user C
User B: Send any message to user A
User A: Verify that No sounds play for the received message

In mobile native:

Log in with user A
User A: Open a chat with user B
User B: Create a task and share it with user A
User A: Verify that there is a sound play for the received message
User A: Open another chat with user C
User B: Create a task and share it with user A
User A: Verify that No sounds play for the received message

Verify that no errors appear in the JS console

Offline tests

QA Steps

In web:

Log in with user A
User A: Open a chat with user B
User A: Open a new tab
User B: Send any message
User A: Verify that No sounds play for the received message
User A: Back to the tab in step 2
User B: Send any message
User A: Verify that there is a sound play for the received message
User A: Open another chat that with user C
User B: Send any message to user A
User A: Verify that No sounds play for the received message

In mobile native:

Log in with user A
User A: Open a chat with user B
User B: Create a task and share it with user A
User A: Verify that there is a sound play for the received message
User A: Open another chat with user C
User B: Create a task and share it with user A
User A: Verify that No sounds play for the received message

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

output.mp4

Android: mWeb Chrome

output.mp4

iOS: Native

Screen.Recording.2024-03-20.at.18.44.37.mov

iOS: mWeb Safari

output.mp4

MacOS: Chrome / Safari

Screencast.from.07-03-2024.15.48.04.webm

MacOS: Desktop

output.mp4

melvin-bot · 2024-03-09T03:25:50Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss

User B: Create a task and share it with user A
User A: Verify that No sounds play for the received message

I hear a sound on mobile when I am in a chat for tasks, but not for messages

dukenv0307 · 2024-03-11T10:41:05Z

I hear a sound on mobile when I am in a chat for tasks, but not for messages

@Julesssss Yes. Because in PR, we do not play sound in case of text message in a native device

Julesssss · 2024-03-11T11:00:05Z

@Julesssss Yes. Because in PR, we do not play sound in case of text message in a native device

Ah okay. That seems incorrect to me as we should mute all sounds. But that is a seperate issue.

dukenv0307 · 2024-03-12T05:09:52Z

I encountered an issue with my ios native device so I cannot make a screenshot in this platform. Will update once it is fixed

dukenv0307 · 2024-03-12T05:10:13Z

@abdulrahuman5196 Bump for review in case you miss it

abdulrahuman5196 · 2024-03-12T18:30:35Z

Hi, I will review in my morning

abdulrahuman5196 · 2024-03-13T14:30:48Z

Reviewing now

abdulrahuman5196

@dukenv0307 Could you kindly check on the requested changes?

abdulrahuman5196 · 2024-03-13T14:38:08Z

src/libs/actions/User.ts

-    const reportIDs = reportActionsOnly.map((value) => value.key.split('_')[1]);
+    const reportIDs = reportActionsOnly
+        .map((value) => value.key.split('_')[1])
+        .filter((reportID) => reportID === Navigation.getTopmostReportId() && Visibility.isVisible() && Visibility.hasFocus());


getTopmostReportId is expected to give only one reportID. Why should we use filter, we should use find in this case.

Since we use Visibility.isVisible() && Visibility.hasFocus(), we shouldn't even map or filter in this case, since it would be obviously failing.

@abdulrahuman5196 I updated the PR based on your comment

Ping to review in case you miss it

abdulrahuman5196 · 2024-03-18T17:44:42Z

Reviewing now

abdulrahuman5196 · 2024-03-18T18:22:01Z

Hi, @Julesssss , The code looks fine.

could you re-add the build label to generate build? It would be good to test this on real device.

Julesssss

Generating test builds 👍

github-actions · 2024-03-19T10:25:45Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/37872/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/37872/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/37872/NewExpensify.dmg	https://37872.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

abdulrahuman5196 · 2024-03-19T15:31:26Z

Reviewing now

abdulrahuman5196 · 2024-03-19T16:15:31Z

@dukenv0307

In the mobile test steps. Why is the sound only for task message? Don't we support sounds for normal message.

Did i miss some requirement?

Log in with user A
User A: Open a chat with user B
User B: Create a task and share it with user A
User A: Verify that there is a sound play for the received message

dukenv0307 · 2024-03-19T16:20:03Z

@abdulrahuman5196

Why is the sound only for task message? Don't we support sounds for normal message

You can check this comment

abdulrahuman5196 · 2024-03-19T16:20:38Z

Got it thanks

abdulrahuman5196 · 2024-03-19T17:02:04Z

@dukenv0307 I am unable to hear sounds in simulator for native iOS. And I don't see native iOS video from your end as well.

Is there some issue with iOS native? Should we reach out to internal engineers for testing iOS

Julesssss · 2024-03-20T10:15:30Z

Is there some issue with iOS native? Should we reach out to internal engineers for testing iOS

I will test iOS this morning on a physical iOS device. I can only test in-app behaviour though as for some reason, I can't get loud iOS notifications to work 😅

github-actions · 2024-03-20T11:03:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/37872/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/37872/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	https://37872.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

abdulrahuman5196 · 2024-03-20T11:16:04Z

Is there some issue with iOS native? Should we reach out to internal engineers for testing iOS

I will test iOS this morning on a physical iOS device. I can only test in-app behaviour though as for some reason, I can't get loud iOS notifications to work 😅

That would be quite helpful. Thank you. I have tested on all other platforms.

Julesssss · 2024-03-20T11:39:09Z

Ugh, my test iPhone refuses to play any sound within the app. It also has never played sounds for push notifications so I'm not sure if the app or device is bugged. Asking for someone else to help test...

dukenv0307 · 2024-03-20T11:46:20Z

@abdulrahuman5196 @Julesssss I just updated ios native video. It works well

abdulrahuman5196 · 2024-03-20T13:28:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

az_recorder_20240319_214241.mp4

Android: mWeb Chrome

az_recorder_20240319_220201.mp4

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-03-19.at.10.10.25.PM.mp4

ScreenRecording.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-03-19.at.9.20.39.PM.mp4

MacOS: Desktop

Screen.Recording.2024-03-19.at.9.29.20.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @Julesssss

🎀 👀 🎀
C+ Reviewed

Julesssss · 2024-03-20T13:45:42Z

One last thing, @dukenv0307 would you mind re-merging main? Then I'll merge, thanks

OSBotify · 2024-03-20T14:28:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-22T16:20:12Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-27T04:49:21Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 2 commits March 7, 2024 15:52

fix in app sound is played if user not viewing chat

71dcc03

fix lint

0873e42

dukenv0307 marked this pull request as ready for review March 9, 2024 03:25

dukenv0307 requested a review from a team as a code owner March 9, 2024 03:25

melvin-bot bot removed the request for review from a team March 9, 2024 03:25

melvin-bot bot requested a review from abdulrahuman5196 March 9, 2024 03:25

dukenv0307 mentioned this pull request Mar 9, 2024

[HOLD for payment 2024-04-03] [$500] In-app sounds play in the background and message received sounds play while not viewing the chat #37098

Closed

6 tasks

dukenv0307 changed the title ~~fix in app sound is played if user not viewing chat~~ Fix/37098: In app sound is played if user not viewing chat Mar 9, 2024

Julesssss added the Ready To Build label Mar 11, 2024

This comment has been minimized.

Sign in to view

Julesssss reviewed Mar 11, 2024

View reviewed changes

Julesssss mentioned this pull request Mar 11, 2024

[Tracking issue] Implement sound feature tasks and bugs #36846

Closed

abdulrahuman5196 suggested changes Mar 13, 2024

View reviewed changes

dukenv0307 added 4 commits March 15, 2024 18:02

fix user find instead of filter

f17e84b

fix remove promise all

3cbc9c0

fix lint

13ecc2f

fix merge main

99b291e

Julesssss reviewed Mar 19, 2024

View reviewed changes

Julesssss approved these changes Mar 20, 2024

View reviewed changes

abdulrahuman5196 approved these changes Mar 20, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss March 20, 2024 13:45

fix merge main

80e99c9

Julesssss merged commit d3ba7d3 into Expensify:main Mar 20, 2024
15 checks passed

github-actions bot mentioned this pull request Mar 22, 2024

Deploy Checklist: New Expensify 2024-03-22 #38811

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/37098: In app sound is played if user not viewing chat #37872

Fix/37098: In app sound is played if user not viewing chat #37872

dukenv0307 commented Mar 7, 2024 •

edited

Loading

melvin-bot bot commented Mar 9, 2024

This comment has been minimized.

Julesssss left a comment

dukenv0307 commented Mar 11, 2024 •

edited

Loading

Julesssss commented Mar 11, 2024

dukenv0307 commented Mar 12, 2024

dukenv0307 commented Mar 12, 2024

abdulrahuman5196 commented Mar 12, 2024

abdulrahuman5196 commented Mar 13, 2024

abdulrahuman5196 left a comment

abdulrahuman5196 Mar 13, 2024

dukenv0307 Mar 15, 2024

dukenv0307 Mar 18, 2024

abdulrahuman5196 commented Mar 18, 2024

abdulrahuman5196 commented Mar 18, 2024

Julesssss left a comment

github-actions bot commented Mar 19, 2024

abdulrahuman5196 commented Mar 19, 2024

abdulrahuman5196 commented Mar 19, 2024

dukenv0307 commented Mar 19, 2024

abdulrahuman5196 commented Mar 19, 2024

abdulrahuman5196 commented Mar 19, 2024

Julesssss commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

abdulrahuman5196 commented Mar 20, 2024

Julesssss commented Mar 20, 2024

dukenv0307 commented Mar 20, 2024

abdulrahuman5196 commented Mar 20, 2024 •

edited

Loading

abdulrahuman5196 left a comment

Julesssss commented Mar 20, 2024

OSBotify commented Mar 20, 2024

OSBotify commented Mar 22, 2024

OSBotify commented Mar 27, 2024

Fix/37098: In app sound is played if user not viewing chat #37872

Fix/37098: In app sound is played if user not viewing chat #37872

Conversation

dukenv0307 commented Mar 7, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 9, 2024

This comment has been minimized.

Julesssss left a comment

Choose a reason for hiding this comment

dukenv0307 commented Mar 11, 2024 • edited Loading

Julesssss commented Mar 11, 2024

dukenv0307 commented Mar 12, 2024

dukenv0307 commented Mar 12, 2024

abdulrahuman5196 commented Mar 12, 2024

abdulrahuman5196 commented Mar 13, 2024

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 Mar 13, 2024

Choose a reason for hiding this comment

dukenv0307 Mar 15, 2024

Choose a reason for hiding this comment

dukenv0307 Mar 18, 2024

Choose a reason for hiding this comment

abdulrahuman5196 commented Mar 18, 2024

abdulrahuman5196 commented Mar 18, 2024

Julesssss left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 19, 2024

abdulrahuman5196 commented Mar 19, 2024

abdulrahuman5196 commented Mar 19, 2024

dukenv0307 commented Mar 19, 2024

abdulrahuman5196 commented Mar 19, 2024

abdulrahuman5196 commented Mar 19, 2024

Julesssss commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

abdulrahuman5196 commented Mar 20, 2024

Julesssss commented Mar 20, 2024

dukenv0307 commented Mar 20, 2024

abdulrahuman5196 commented Mar 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Julesssss commented Mar 20, 2024

OSBotify commented Mar 20, 2024

OSBotify commented Mar 22, 2024

OSBotify commented Mar 27, 2024

dukenv0307 commented Mar 7, 2024 •

edited

Loading

dukenv0307 commented Mar 11, 2024 •

edited

Loading

abdulrahuman5196 commented Mar 20, 2024 •

edited

Loading