-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Live Markdown Preview on web #38152
Merged
thienlnam
merged 22 commits into
Expensify:main
from
software-mansion-labs:@Skalakid/live-markdown-input-for-web
Mar 27, 2024
Merged
Changes from 18 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3973b76
Enable live markdown input on web
Skalakid 60a8cec
Bump expensify-common version
Skalakid 4379afe
Merge branch 'main' into @Skalakid/live-markdown-input-for-web
Skalakid c868943
Bump react-native-live-markdown verion to 0.1.26
Skalakid 3cd3e79
Merge branch 'main' into @Skalakid/live-markdown-input-for-web
Skalakid cf5f86b
Change Composer markdown component to RNMarkdownTextInput
Skalakid 124ac6c
Change ref type
Skalakid 52f68dc
Fix prettier
Skalakid 8333bb6
Fix Podfile
Skalakid f24cebb
Merge branch 'main' into @Skalakid/live-markdown-input-for-web
Skalakid ab6d0f6
Update react-native-live-markdown and expensify-common versions
Skalakid 6db2f6b
Update Podfile
Skalakid 9509076
fix: flushSync error
BartoszGrajdek e90a031
fix: flushSync
BartoszGrajdek a689007
fix: paste in composer for message editing
BartoszGrajdek 08692ed
fix: repeated pasting
BartoszGrajdek 095cc23
chore: resolve merge conflicts
BartoszGrajdek 155a097
remove no longer needed workaround when mentions recalculate on char …
Kicu 2e73780
fix: duplicated attachments while pasting
BartoszGrajdek 7624b85
chore: resolve merge conflicts
BartoszGrajdek 58bb4ea
fix: full composer scrollbar
BartoszGrajdek 8fe7c78
fix: shift+enter after mentions scrolling issue
BartoszGrajdek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,7 +62,7 @@ | |
}, | ||
"dependencies": { | ||
"@dotlottie/react-player": "^1.6.3", | ||
"@expensify/react-native-live-markdown": "0.1.5", | ||
"@expensify/react-native-live-markdown": "0.1.28", | ||
"@expo/metro-runtime": "~3.1.1", | ||
"@formatjs/intl-datetimeformat": "^6.10.0", | ||
"@formatjs/intl-getcanonicallocales": "^2.2.0", | ||
|
@@ -102,7 +102,7 @@ | |
"date-fns-tz": "^2.0.0", | ||
"dom-serializer": "^0.2.2", | ||
"domhandler": "^4.3.0", | ||
"expensify-common": "git+ssh://[email protected]/Expensify/expensify-common.git#7bfd55f0ce75a37423119029fde58cfbe57086d9", | ||
"expensify-common": "git+ssh://[email protected]/Expensify/expensify-common.git#dc8ea983f9e06308cdb9151a9cdfa82bd11502e1", | ||
"expo": "^50.0.3", | ||
"expo-av": "~13.10.4", | ||
"expo-image": "1.10.1", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes for this one:
TextInput
but now on this branchRNMarkdownTextInput
is used and this bug no longer appears@
char