Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect animation direction on Wallet, Save The World, Exit Survey, Profile Contact and Troubleshooting page #38190

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Incorrect animation direction on Wallet, Save The World, Exit Survey, Profile Contact and Troubleshooting page #38190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c28b23
Fix route animation
allgandalf Mar 12, 2024
f81f9b4
Merge branch 'Expensify:main' into issue37359
allgandalf Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/TeachersUnite/ImTeacherUpdateEmailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function ImTeacherUpdateEmailPage() {
<ScreenWrapper testID={ImTeacherUpdateEmailPage.displayName}>
<HeaderWithBackButton
title={translate('teachersUnitePage.iAmATeacher')}
onBackButtonPress={() => Navigation.goBack(ROUTES.TEACHERS_UNITE)}
onBackButtonPress={() => Navigation.goBack()}
/>
<BlockingView
shouldShowLink
Expand Down
3 changes: 1 addition & 2 deletions src/pages/TeachersUnite/IntroSchoolPrincipalPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import * as ValidationUtils from '@libs/ValidationUtils';
import TeachersUnite from '@userActions/TeachersUnite';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';
import INPUT_IDS from '@src/types/form/IntroSchoolPrincipalForm';
import type {LoginList} from '@src/types/onyx';

Expand Down Expand Up @@ -81,7 +80,7 @@ function IntroSchoolPrincipalPage(props: IntroSchoolPrincipalPageProps) {
>
<HeaderWithBackButton
title={translate('teachersUnitePage.introSchoolPrincipal')}
onBackButtonPress={() => Navigation.goBack(ROUTES.TEACHERS_UNITE)}
onBackButtonPress={() => Navigation.goBack()}
/>
<FormProvider
enabledWhenOffline
Expand Down
3 changes: 1 addition & 2 deletions src/pages/TeachersUnite/KnowATeacherPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import * as ValidationUtils from '@libs/ValidationUtils';
import TeachersUnite from '@userActions/TeachersUnite';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';
import INPUT_IDS from '@src/types/form/IKnowTeacherForm';
import type {LoginList} from '@src/types/onyx';

Expand Down Expand Up @@ -87,7 +86,7 @@ function KnowATeacherPage(props: KnowATeacherPageProps) {
>
<HeaderWithBackButton
title={translate('teachersUnitePage.iKnowATeacher')}
onBackButtonPress={() => Navigation.goBack(ROUTES.TEACHERS_UNITE)}
onBackButtonPress={() => Navigation.goBack()}
/>
<FormProvider
enabledWhenOffline
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/AboutPage/TroubleshootPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ function TroubleshootPage({shouldStoreLogs}: TroubleshootPageProps) {
return (
<IllustratedHeaderPageLayout
title={translate('initialSettingsPage.aboutPage.troubleshoot')}
onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_ABOUT)}
onBackButtonPress={() => Navigation.goBack()}
backgroundColor={theme.PAGE_THEMES[SCREENS.SETTINGS.TROUBLESHOOT].backgroundColor}
illustration={LottieAnimations.Desk}
testID={TroubleshootPage.displayName}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/ExitSurvey/ExitSurveyConfirmPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function ExitSurveyConfirmPage({exitReason, isLoading, route, navigation}: ExitS
<ScreenWrapper testID={ExitSurveyConfirmPage.displayName}>
<HeaderWithBackButton
title={translate('exitSurvey.header')}
onBackButtonPress={() => Navigation.goBack(backTo)}
onBackButtonPress={() => Navigation.goBack()}
/>
<View style={[styles.flex1, styles.justifyContentCenter, styles.alignItemsCenter, styles.mh5]}>
{isOffline && <ExitSurveyOffline />}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/ExitSurvey/ExitSurveyResponsePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function ExitSurveyResponsePage({draftResponse, route, navigation}: ExitSurveyRe
<ScreenWrapper testID={ExitSurveyResponsePage.displayName}>
<HeaderWithBackButton
title={translate('exitSurvey.header')}
onBackButtonPress={() => Navigation.goBack(backTo)}
onBackButtonPress={() => Navigation.goBack()}
/>
<FormProvider
formID={ONYXKEYS.FORMS.EXIT_SURVEY_RESPONSE_FORM}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ function ContactMethodsPage({loginList, session, route}: ContactMethodsPageProps
>
<HeaderWithBackButton
title={translate('contacts.contactMethods')}
onBackButtonPress={() => Navigation.goBack(navigateBackTo)}
onBackButtonPress={() => Navigation.goBack()}
/>
<ScrollView contentContainerStyle={styles.flexGrow1}>
<View style={[styles.ph5, styles.mv3, styles.flexRow, styles.flexWrap]}>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/Wallet/ExpensifyCardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ function ExpensifyCardPage({
<>
<HeaderWithBackButton
title={translate('cardPage.expensifyCard')}
onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}
onBackButtonPress={() => Navigation.goBack()}
/>
<ScrollView contentContainerStyle={safeAreaPaddingBottomStyle}>
<View style={[styles.flex1, styles.mb9, styles.mt9]}>
Expand Down
Loading