Feat: add check if pdf is corrupted #38384

kubabutkiewicz · 2024-03-15T10:34:48Z

Details

Fixed Issues

$ #34032

Tests

Login to app
Click on FAB and select Submit Expense
Go to Scan tab
Click on icon to upload a document
Select corrupted pdf file
Verify that you have been alerted that pdf is corrupted and did navigate to next step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login to app
Click on FAB and select Submit Expense
Go to Scan tab
Click on icon to upload a document
Select corrupted pdf file
Verify that you have been alerted that pdf is corrupted and did navigate to next step

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

… check on web if pdf is corrupted

# Conflicts: # src/pages/iou/request/step/IOURequestStepScan/index.js

…ix/error-message-when-uploading-corrupted-pdf

android/app/src/main/java/com/expensify/chat/CheckPDFDocument.java

android/app/src/main/java/com/expensify/chat/PdfUtils.java

ios/NewExpensify.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings

ios/RCTCheckPDFDocument.h

src/libs/CheckPDFDocument/index.native.ts

fabioh8010 · 2024-04-15T16:13:55Z

src/libs/CheckPDFDocument/index.ts

+if (!pdfjs.GlobalWorkerOptions.workerSrc) {
+    pdfjs.GlobalWorkerOptions.workerSrc = URL.createObjectURL(new Blob([pdfWorkerSource], {type: 'text/javascript'}));
+}


What's the purpose of this?

its needed for pdfjs to work, reference here https://mozilla.github.io/pdf.js/examples/

src/libs/CheckPDFDocument/types.ts

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

fabioh8010 · 2024-04-15T16:20:08Z

@kubabutkiewicz Also what about converting your module to Kotlin? 🙂

kubabutkiewicz · 2024-04-16T08:00:46Z

@fabioh8010 I created that originally as Kotlin module but then when I wanted to test it the app was not building, but when I rewrite it in Java everything was good so I left it as a Java module

…ix/error-message-when-uploading-corrupted-pdf

melvin-bot · 2024-04-19T14:58:29Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ix/error-message-when-uploading-corrupted-pdf

rushatgabhane · 2024-04-23T06:20:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rushatgabhane

@kubabutkiewicz bug: i don't see corrupted pdf message.

Upload a corrupted pdf. This is the file i uploaded -https://uploadnow.io/files/JGjhJ62
Click send

Expected:

Actual: console error and I'm able to send the corrupted pdf
InvalidPDFException

Screen.Recording.2024-04-23.at.15.02.34.mov

kubabutkiewicz · 2024-04-25T08:26:03Z

@rushatgabhane the check was added only to Money Request -> Scan flow. Since the bug was related to that flow, do you think we should add it also to scenario which you provided? or it can be done in separate issue?

rushatgabhane · 2024-04-25T09:19:02Z

@kubabutkiewicz yes, i think we should do it in add attachment flow too.

(Mainly because it'll be a small change)

rushatgabhane · 2024-05-13T11:04:48Z

@kubabutkiewicz in case you're back from OOO, could you please take a look at #38384 (comment)

kubabutkiewicz · 2024-05-13T14:52:42Z

Hi @rushatgabhane , issue get closed so I will also close this pr, sorry for that

kubabutkiewicz and others added 30 commits March 15, 2024 11:33

feat: added patch to pdfjs so it can be used with React native, added…

9343e1f

… check on web if pdf is corrupted

Merge branch 'main' into fix/error-message-when-uploading-corrupted-pdf

9b745b4

Merge branch 'main' into fix/error-message-when-uploading-corrupted-pdf

8928aed

# Conflicts: # src/pages/iou/request/step/IOURequestStepScan/index.js

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

8310b2d

…ix/error-message-when-uploading-corrupted-pdf

.

37d57eb

wip

2b797b7

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

84c1498

…ix/error-message-when-uploading-corrupted-pdf

wip

8ad04fd

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

eefd6bb

…ix/error-message-when-uploading-corrupted-pdf

feat: added android native module for checking if pdf is correct

f9a3c16

wip

f092ab2

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

20a99cc

…ix/error-message-when-uploading-corrupted-pdf

ios wip

d34d324

wip

4746025

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

ca61c76

…ix/error-message-when-uploading-corrupted-pdf

feat: added check if pdf is valid on ios side

0f8a479

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

400e529

…ix/error-message-when-uploading-corrupted-pdf

fix: lint

ca5a70f

fix: add implementation that is not using any external lib

3dafaf1

fix: removed unused things

305e5ea

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

e919403

…ix/error-message-when-uploading-corrupted-pdf

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

9d96213

…ix/error-message-when-uploading-corrupted-pdf

fix: revert changes in package-lock.json

cf3153f

fix: some adjustments

279d808

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

86bc3f3

…ix/error-message-when-uploading-corrupted-pdf

fix: adjustemts to web and desktop version

17a6c9f

fix: add ts support for native module

3797624

fix: typecheck

0161c34

fix: whitespaces

16804ce

fix: whitespaces

a9e6b46

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

5b5af4d

…ix/error-message-when-uploading-corrupted-pdf

fabioh8010 reviewed Apr 15, 2024

View reviewed changes

kubabutkiewicz added 7 commits April 16, 2024 10:24

fix: resolve comments

cb64f92

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

abd993b

…ix/error-message-when-uploading-corrupted-pdf

fix: issue with web after recent merge

cd140dc

fix: resolve comments

c203c3d

fix: added comments

f7ded6e

fix: resolve comments

0916021

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

e7341b5

…ix/error-message-when-uploading-corrupted-pdf

MrRefactor approved these changes Apr 19, 2024

View reviewed changes

kubabutkiewicz added 3 commits April 19, 2024 14:30

fix: remove unnecessary comments

58bddea

fix: change error message when pdf is corrupted

b17e911

fix: revert back to original Podfile.lock

1f299ac

fabioh8010 approved these changes Apr 19, 2024

View reviewed changes

kubabutkiewicz marked this pull request as ready for review April 19, 2024 14:58

kubabutkiewicz requested a review from a team as a code owner April 19, 2024 14:58

melvin-bot bot requested review from rushatgabhane and removed request for a team April 19, 2024 14:58

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

4c7e330

…ix/error-message-when-uploading-corrupted-pdf

rushatgabhane suggested changes Apr 23, 2024

View reviewed changes

kubabutkiewicz closed this May 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: add check if pdf is corrupted #38384

Feat: add check if pdf is corrupted #38384

kubabutkiewicz commented Mar 15, 2024 •

edited

Loading

fabioh8010 Apr 15, 2024

kubabutkiewicz Apr 16, 2024

fabioh8010 commented Apr 15, 2024

kubabutkiewicz commented Apr 16, 2024

melvin-bot bot commented Apr 19, 2024

rushatgabhane commented Apr 23, 2024

rushatgabhane left a comment

kubabutkiewicz commented Apr 25, 2024

rushatgabhane commented Apr 25, 2024 •

edited

Loading

rushatgabhane commented May 13, 2024

kubabutkiewicz commented May 13, 2024

Feat: add check if pdf is corrupted #38384

Feat: add check if pdf is corrupted #38384

Conversation

kubabutkiewicz commented Mar 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

fabioh8010 Apr 15, 2024

Choose a reason for hiding this comment

kubabutkiewicz Apr 16, 2024

Choose a reason for hiding this comment

fabioh8010 commented Apr 15, 2024

kubabutkiewicz commented Apr 16, 2024

melvin-bot bot commented Apr 19, 2024

rushatgabhane commented Apr 23, 2024

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

kubabutkiewicz commented Apr 25, 2024

rushatgabhane commented Apr 25, 2024 • edited Loading

rushatgabhane commented May 13, 2024

kubabutkiewicz commented May 13, 2024

kubabutkiewicz commented Mar 15, 2024 •

edited

Loading

rushatgabhane commented Apr 25, 2024 •

edited

Loading