Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing not found page after deleting a workspace #38488

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Fix showing not found page after deleting a workspace #38488

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f960ccc
Fix shouldShow in WorkspacePageWithSections
WojtekBoman Mar 18, 2024
7782d5e
Run prettier
WojtekBoman Mar 18, 2024
c98834f
Merge branch 'main' into fix/delete-workspace-not-found
WojtekBoman Mar 20, 2024
5ed9f31
Merge branch 'main' into fix/delete-workspace-not-found
WojtekBoman Mar 20, 2024
d8184b4
Fix showing not found page after deleting workspace
WojtekBoman Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/workspace/WorkspacePageWithSections.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ function WorkspacePageWithSections({
return true;
}

return (!isEmptyObject(policy) && !PolicyUtils.isPolicyAdmin(policy) && !shouldShowNonAdmin) || PolicyUtils.isPendingDeletePolicy(policy);
return !isEmptyObject(policy) && !PolicyUtils.isPolicyAdmin(policy) && !shouldShowNonAdmin;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will cause the regression

  1. Go to the workspace that we going to delete
  2. Press Reimbursements > Copy the URL
  3. Press workspace Profile > Press Delete
  4. Go to any chat paste the workspace reimbursements URL and send
  5. Press the link, it will show the reimbursements page and we can edit the Rate
regression.mov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To understand clearly the output I am attaching staging result.

staging.mov

// eslint-disable-next-line react-hooks/exhaustive-deps
}, [policy, shouldShowNonAdmin]);

Expand Down
Loading