Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediately show file size message for large attachments #39334

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Immediately show file size message for large attachments #39334

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1c2078c
Immediately show file size message for large attachments
ShridharGoel Mar 31, 2024
c509b2f
Update index.native.tsx
ShridharGoel Apr 1, 2024
f98b733
Update index.native.tsx
ShridharGoel Apr 2, 2024
a23585e
Update index.native.tsx
ShridharGoel Apr 2, 2024
2642935
Fix lint
ShridharGoel Apr 2, 2024
31384cf
Merge branch 'main' into attachment-fix
ShridharGoel Apr 2, 2024
1f1fd18
Move to alphabetical order in import type list
ShridharGoel Apr 2, 2024
31bdacc
Merge branch 'main' of https://github.com/Expensify/App into attachme…
ShridharGoel Apr 4, 2024
d1fd4e4
Merge
ShridharGoel Apr 10, 2024
685f6d5
Merge branch 'main' of https://github.com/Expensify/App into attachme…
ShridharGoel Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/AttachmentPicker/index.native.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import RNFetchBlob from 'react-native-blob-util';
import RNDocumentPicker from 'react-native-document-picker';
import type {DocumentPickerOptions, DocumentPickerResponse} from 'react-native-document-picker';
import {launchImageLibrary} from 'react-native-image-picker';
import type {Asset, Callback, CameraOptions, ImagePickerResponse} from 'react-native-image-picker';
import type {Asset, Callback, CameraOptions, ImageLibraryOptions, ImagePickerResponse} from 'react-native-image-picker';
import ImageSize from 'react-native-image-size';
import type {FileObject, ImagePickerResponse as FileResponse} from '@components/AttachmentModal';
import * as Expensicons from '@components/Icon/Expensicons';
Expand Down Expand Up @@ -41,11 +41,12 @@ type Item = {
* See https://github.com/react-native-image-picker/react-native-image-picker/#options
* for ImagePicker configuration options
*/
const imagePickerOptions = {
const imagePickerOptions: Partial<CameraOptions | ImageLibraryOptions> = {
includeBase64: false,
saveToPhotos: false,
selectionLimit: 1,
includeExtra: false,
assetRepresentationMode: 'current',
};

/**
Expand Down
Loading