-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] fix: Split btn for single contact became inactive when returned from final review #39383
Conversation
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
fix: Split btn for single contact became inactive when returned from final review (cherry picked from commit 008574a)
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.58-8 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀
|
Details
Fixed Issues
$#39320
PROPOSAL: #39320 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
39339744-17e7-4c50-a6b3-9c3baf444ea7.mp4
Android: mWeb Chrome
51b2893f-706e-4f32-a1b4-357c979c2f1d.mp4
iOS: Native
0fa445d4-5c8f-41ce-b576-3c1dce08665f.mp4
iOS: mWeb Safari
0b3cfcd2-5ad8-4fb2-a2d5-2cfe3be6aad8.mp4
MacOS: Chrome / Safari
155fe274-800e-4dca-9326-627ac55f5c92.mp4
MacOS: Desktop
2956e2f5-2439-4f84-8a50-535fe91b1405.mp4