-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Stag][Fix] One character jumps "after" cursor when typing fast #39621
[CP Stag][Fix] One character jumps "after" cursor when typing fast #39621
Conversation
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This PR is related to live markdown cc @shubham1206agra @c3024 @thienlnam |
@BartoszGrajdek Can you merge main here? |
Done! @shubham1206agra |
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariScreen.Recording.2024-04-04.at.10.06.32.PM.movMacOS: Chrome / SafariScreen.Recording.2024-04-04.at.10.05.10.PM.movMacOS: DesktopScreen.Recording.2024-04-04.at.10.09.54.PM.mov |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
@thienlnam Please merge here. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…cursor-position-when-typing-fast [Fix] One character jumps "after" cursor when typing fast (cherry picked from commit 90ac4ef)
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.60-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.60-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀
|
Details
This PR fixes a problem that happens when you type really fast and the cursor moves backwards a character.
Fixed Issues
$ #39360
Tests
Offline tests
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: mWeb Chrome
mweb.android.mov
iOS: mWeb Safari
mweb.ios.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov