Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Search Page Slow Issue (CMD+K) - 2nd solution #3975

Closed

Conversation

Looxor
Copy link
Contributor

@Looxor Looxor commented Jul 10, 2021

Details

  1. src/pages/SearchPage.js
  • added conditional render using didScreenTransitionEnd

Fixed Issues

$ #3601

Tests

  1. While using e.cash use the cmd+k command
  2. Type on the search field

QA Steps

  1. While using e.cash use the cmd+k command
  2. Type on the search field

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

expensify-fix-result.mp4

iOS

Android

I have read the CLA Document and I hereby sign the CLA.

@Looxor Looxor requested a review from a team as a code owner July 10, 2021 19:03
@MelvinBot MelvinBot requested review from timszot and removed request for a team July 10, 2021 19:03
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2021

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@Looxor
❌ @mac
mac seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@Looxor
Copy link
Contributor Author

Looxor commented Jul 10, 2021

I have read the CLA Document and I hereby sign the CLA.

@Looxor
Copy link
Contributor Author

Looxor commented Jul 10, 2021

I have read the CLA Document and I hereby sign the CLA

@Looxor
Copy link
Contributor Author

Looxor commented Jul 12, 2021

recheck

@Looxor Looxor closed this Jul 12, 2021
@Looxor
Copy link
Contributor Author

Looxor commented Jul 12, 2021

recheck

@Looxor Looxor reopened this Jul 12, 2021
@Looxor Looxor closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant