Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'isSearchingForReports' to control green circular loading #39865

Merged
merged 55 commits into from
May 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
acadbb3
add 'and use 'isSearchingForReports' to 'MoneyTemporaryForRefactorReq…
brunovjk Apr 4, 2024
5bac59f
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 8, 2024
6fa2e21
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 8, 2024
ce614a5
Add 'isSearchingForReports' prop and include it in component memoization
brunovjk Apr 8, 2024
fb8d4ff
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 9, 2024
61b2f51
Add 'isSearchingForReports' to 'TaskAssigneeSelectorModal'
brunovjk Apr 9, 2024
a58ace4
Add 'isSearchingForReports' to 'RoomInvitePage'
brunovjk Apr 9, 2024
1de5419
Add 'isSearchingForReports' to 'WorkspaceInvitePage'
brunovjk Apr 9, 2024
ad5e6f2
Add 'isSearchingForReports' to 'BaseShareLogList'
brunovjk Apr 9, 2024
97c0211
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 9, 2024
71972cb
Merge branch 'fix/37144' of https://github.com/brunovjk/Expensify-App…
brunovjk Apr 9, 2024
f5141f6
Add 'isSearchingForReports' to 'MoneyRequestParticipantsSelector'
brunovjk Apr 9, 2024
75ee88c
fix lint
brunovjk Apr 9, 2024
df280d9
run prettier
brunovjk Apr 9, 2024
0eb718d
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 10, 2024
cd0577f
remove unnecessary changes
brunovjk Apr 10, 2024
fb8e738
fix lint
brunovjk Apr 10, 2024
b8e636d
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 11, 2024
8f87bf5
Add 'isSearchingForReports' to 'RoomMembersPage'
brunovjk Apr 11, 2024
7f86e23
fix lint
brunovjk Apr 11, 2024
a8e28dc
Revert "fix lint"
brunovjk Apr 12, 2024
16edfab
Revert "Add 'isSearchingForReports' to 'RoomMembersPage'"
brunovjk Apr 12, 2024
900006a
Merged remote changes and resolved conflicts
brunovjk Apr 13, 2024
8069868
fix lint
brunovjk Apr 13, 2024
056c1ce
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 14, 2024
50cc16b
Merged remote changes and resolved conflicts
brunovjk Apr 15, 2024
20fd8d1
fix lint
brunovjk Apr 15, 2024
35558e3
fix lint
brunovjk Apr 15, 2024
7ffd26a
Merge branch 'main' into fix/37144
brunovjk Apr 16, 2024
2527d67
fix lint
brunovjk Apr 16, 2024
0a4a1a8
run prettier
brunovjk Apr 16, 2024
27fc28d
Merge branch 'main' into fix/37144
brunovjk Apr 17, 2024
508da04
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 17, 2024
1e651e7
updating workspace invite member page: useEffect dependency
brunovjk Apr 17, 2024
deca60f
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 18, 2024
5222fcf
resolve conflicts
brunovjk Apr 19, 2024
a5c0160
Merge remote-tracking branch 'origin/main' into fix/37144
brunovjk Apr 22, 2024
8f50ea1
fix lint
brunovjk Apr 22, 2024
904cc2a
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 24, 2024
04fe50a
Merged remote changes and resolved conflicts
brunovjk Apr 29, 2024
ea00647
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 30, 2024
cd447ca
use 'useOnyx' instead of 'withOnyx' to fetch 'isSearchingForReports'
brunovjk Apr 30, 2024
76c4a5d
fix performance test failure
brunovjk Apr 30, 2024
2df39ef
run prettier
brunovjk Apr 30, 2024
17a11e6
Revert 'fix performance test failure'
brunovjk Apr 30, 2024
bcf2ff2
Merge branch 'Expensify:main' into fix/37144
brunovjk Apr 30, 2024
cf92fd4
Merge branch 'Expensify:main' into fix/37144
brunovjk May 1, 2024
6146cc6
Move the key betas to use useOnyx in ChatFinderPage
brunovjk May 2, 2024
304faac
Merge branch 'Expensify:main' into fix/37144
brunovjk May 2, 2024
f26304c
fix lint
brunovjk May 2, 2024
18bbba2
Merge branch 'fix/37144' of https://github.com/brunovjk/Expensify-App…
brunovjk May 2, 2024
d2f1890
fix lint
brunovjk May 2, 2024
b647dea
run prettier
brunovjk May 2, 2024
ee82017
revert ChatFinderPage
brunovjk May 3, 2024
9590ff1
Merge branch 'Expensify:main' into fix/37144
brunovjk May 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run prettier
  • Loading branch information
brunovjk committed Apr 9, 2024
commit df280d90d319509fae946320e22e7248aef61592
3 changes: 1 addition & 2 deletions src/pages/tasks/TaskAssigneeSelectorModal.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable es/no-optional-chaining */
import type {RouteProp} from '@react-navigation/native';
import {useRoute} from '@react-navigation/native';
import React, {useEffect, useCallback, useMemo, useState} from 'react';
import React, {useCallback, useEffect, useMemo, useState} from 'react';
import {View} from 'react-native';
import {withOnyx} from 'react-native-onyx';
import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';
Expand Down Expand Up @@ -42,7 +42,6 @@ type TaskAssigneeSelectorModalOnyxProps = {

/** Whether or not we are searching for reports on the server */
isSearchingForReports: OnyxEntry<boolean>;

};

type TaskAssigneeSelectorModalProps = TaskAssigneeSelectorModalOnyxProps & WithCurrentUserPersonalDetailsProps & WithNavigationTransitionEndProps;
Expand Down
Loading