Hmm it is not here error appears briefly when enabling workflows

[ZhenjaHorbach]

Details

Fixed Issues

$ #39443
PROPOSAL: #39443 (comment)

Tests

1. Log in with a new expensify account
2. Create a workspace
3. Navigate to Workspace settings - More features
4. Enable workflows
5. Verify that "Hmm it is not here" is not showing

• Verify that no errors appear in the JS console

Offline tests

1. Log in with a new expensify account
2. Create a workspace
3. Navigate to Workspace settings - More features
4. Enable workflows
5. Verify that "Hmm it is not here" is not showing

QA Steps

1. Log in with a new expensify account
2. Create a workspace
3. Navigate to Workspace settings - More features
4. Enable workflows
5. Verify that "Hmm it is not here" is not showing

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-14.at.23.35.34.mov

Android: mWeb Chrome

Screen.Recording.2024-04-14.at.23.35.34.mov

iOS: Native

Screen.Recording.2024-04-14.at.23.39.27.mov

iOS: mWeb Safari

Screen.Recording.2024-04-14.at.23.39.27.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-14.at.23.33.41.mov

MacOS: Desktop

Screen.Recording.2024-04-14.at.23.37.30.mov

[melvin-bot]

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ZhenjaHorbach]

@hungvu193
Hello )
PR is ready )

[hungvu193]

BUG: Enable policy makes NotFound screen shows. Reproduce steps are in the video, or just create a ws offline, turn on Workflows, go online and reload the page.

Screen.Recording.2024-04-15.at.09.44.30.mov

[ZhenjaHorbach]

Contributor

BUG: Enable policy makes NotFound screen shows. Reproduce steps are in the video, or just create a ws offline, turn on Workflows, go online and reload the page.

Screen.Recording.2024-04-15.at.09.44.30.mov

I would like to ask about the second case that you described It looks as expected In the sense that when we create a workspace offline And then turn on the Internet and immediately reload the page

Our request to enable this feature will not be completed because it was in the queue
And as a result, we are in a state of disabled feature
Since we interrupted the feature enable process

Should we handle such cases?)

I fixed the bug )
And PR is ready )

And a little explanation
I added these changes because sometimes (extremely rarely) after enabling the function we see a not found for a couple of milliseconds

https://github.com/Expensify/App/pull/40219/files#diff-cd0dfd9f8af5bc7cd33ff4f0337ef70574d42424ceecd7692b193348d3d8ecd4R3922-R3924

The same thing happens on main
I think these changes will help
And after testing it looks like it really helped

[hungvu193]

I actually waited for all the requests to be called, so this is valid bug I believe. I didn't reload the page immediately.

Screen.Recording.2024-04-16.at.10.17.32.mov

[hungvu193]

Do you have any other solution for this? We avoid using setTimeout

[ZhenjaHorbach]

This is the problem I described here

#40219 (comment)

And this problem is mentioned here

App/src/libs/actions/Policy.ts

Lines 3915 to 3918 in 268b870

	/**
	* The app needs to set a navigation action to the microtask queue, it guarantees to execute Onyx.update first, then the navigation action.
	* More details - https://github.com/Expensify/App/issues/37785#issuecomment-1989056726.
	*/

It's still reproduce (even on main branch )
When we navigate
We have cases when isFeatureEnabled equals false for a couple of milliseconds

So why don't we make the navigation happen after the switch animation ends?

[hungvu193]

Let's take a look at my video, I posted. I waited for all the request were called, so why are you saying that

Our request to enable this feature will not be completed because it was in the queue

[ZhenjaHorbach]

Sorry
My fault, I didn't notice that you waited for all the request were called
In this case, I fixed the cases you described )

[hungvu193]

I don't think your explanation here is correct. Let's discuss our situation here, all APIs were called and we still saw the NotFound screen. That shouldn't happen and I think we can avoid using timeout to fix it.

[ZhenjaHorbach]

I want to fix a specific case with these changes

When, after enabling a feature, we navigate immediately
That Onyx.update sometimes does not change the value immediately
As result we have NotFound for a couple of milliseconds

I think problem related with Promise which we use

App/src/libs/actions/Policy.ts

Lines 3915 to 3921 in 268b870

	/**
	* The app needs to set a navigation action to the microtask queue, it guarantees to execute Onyx.update first, then the navigation action.
	* More details - https://github.com/Expensify/App/issues/37785#issuecomment-1989056726.
	*/
	new Promise<void>((resolve) => {
	resolve();
	}).then(() => {

But so as not to cause regression
I was thinking of using setTimeout inside Promise
To be sure that everything is called in the correct order

2024-04-17.13.39.19.mov

(Video is from main branch )

but okay )
I'll try to find an alternative solution )
Thank you for review )

[hungvu193]

Any update here?

[ZhenjaHorbach]

I'll look into this issue thoroughly over the weekend
If you do not mind

[hungvu193]

Yeah yeah, np. Please keep me posted

[ZhenjaHorbach]

I decided to update my GPG keys
But something went wrong during the merge
And in this case, it’s much faster to create a new PR instead of fixing a commit with all new commits after merge
So I close this PR
And open this
#40650