Code

[HOLD] Implement Uneven Splits#40386

Code

Merged

youssef-lr merged 118 commits intomainExpensify/App:mainfrom youssef_uneven_splits_2Expensify/App:youssef_uneven_splits_2Copy head branch name to clipboardMay 7, 2024

+650-249

Commits

Commits on Apr 15, 2024

• Add TS definitions

  youssef-lr

  committed
  d99170a

  Copy full SHA for d99170a

Commits on Apr 16, 2024

• Set split shares when first creating the split

  youssef-lr

  committed
  99efbb6

  Copy full SHA for 99efbb6

• Add IOU functions to set split shares and adjust them

  youssef-lr

  committed
  cf65044

  Copy full SHA for cf65044

Commits on Apr 17, 2024

• Allow configuring split amounts

  youssef-lr

  committed
  97ac991

  Copy full SHA for 97ac991

• Use temporary amount input

  youssef-lr

  committed
  4bc7142

  Copy full SHA for 4bc7142

• Pass custom styles

  youssef-lr

  committed
  e9cc173

  Copy full SHA for e9cc173

Commits on Apr 18, 2024

• Temporary updates to the amount input

  youssef-lr

  committed
  b24ff87

  Copy full SHA for b24ff87

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  6afe0e5

  Copy full SHA for 6afe0e5

• Allow setting individual shares

  youssef-lr

  committed
  9e53204

  Copy full SHA for 9e53204

• Show a form error if sum of shares don't match total

  youssef-lr

  committed
  00db6ff

  Copy full SHA for 00db6ff

• Prevent submitting form if total doesn't match

  youssef-lr

  committed
  23d8693

  Copy full SHA for 23d8693

• Adjust shares automatically

  youssef-lr

  committed
  cc3de14

  Copy full SHA for cc3de14

• Revert changes

  youssef-lr

  committed
  d98103f

  Copy full SHA for d98103f

• Use temporary input

  youssef-lr

  committed
  14c9ead

  Copy full SHA for 14c9ead

• Show even splits for workspace chat splits

  youssef-lr

  committed
  f032df0

  Copy full SHA for f032df0

• Send uneven splits to backend

  youssef-lr

  committed
  3d2e12e

  Copy full SHA for 3d2e12e

• Save splits array in the transaction optimistically

  youssef-lr

  committed
  eb5c8f1

  Copy full SHA for eb5c8f1

Commits on Apr 19, 2024

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  39fa362

  Copy full SHA for 39fa362

• Copy changes to MoneyRequestConfirmationList

  youssef-lr

  committed
  2001821

  Copy full SHA for 2001821

• Allow excluding group chat users from splits by setting amount to 0

  youssef-lr

  committed
  f8116b3

  Copy full SHA for f8116b3

Commits on Apr 20, 2024

• Reset split shares when amount changes

  youssef-lr

  committed
  756d11a

  Copy full SHA for 756d11a

• Display read only shares in splti details page

  youssef-lr

  committed
  1cd5bd1

  Copy full SHA for 1cd5bd1

• Show split share in split preview card

  youssef-lr

  committed
  2cb1d95

  Copy full SHA for 2cb1d95

• Allow easy tab navigation for inputs

  youssef-lr

  committed
  959d6d0

  Copy full SHA for 959d6d0

• Refactoring and TS fixes

  youssef-lr

  committed
  e75e56f

  Copy full SHA for e75e56f

• wip: Reset button

  youssef-lr

  committed
  7baa777

  Copy full SHA for 7baa777

• Allow resetting the amounts

  youssef-lr

  committed
  6712733

  Copy full SHA for 6712733

Commits on Apr 21, 2024

• Bug fix

  youssef-lr

  committed
  327624e

  Copy full SHA for 327624e

Commits on Apr 22, 2024

• Debounce form error in splits page

  youssef-lr

  committed
  e915d7c

  Copy full SHA for e915d7c

• Bug fix

  youssef-lr

  committed
  845d1a6

  Copy full SHA for 845d1a6

• Lint

  youssef-lr

  committed
  6d5762f

  Copy full SHA for 6d5762f

• Hide inputs for Smartscan splits

  youssef-lr

  committed
  5c1758e

  Copy full SHA for 5c1758e

Commits on Apr 23, 2024

• Fix currency not shown in split amounts in details page

  youssef-lr

  committed
  1579091

  Copy full SHA for 1579091

• Bug fix

  youssef-lr

  committed
  bca161b

  Copy full SHA for bca161b

• Filter out participants with shares equal to 0

  youssef-lr

  committed
  f5b0c10

  Copy full SHA for f5b0c10

• Prevent creating a split containing a single participant

  youssef-lr

  committed
  db455e5

  Copy full SHA for db455e5

• Prevent submitting form if there's an error

  youssef-lr

  committed
  cbe5d36

  Copy full SHA for cbe5d36

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  5dd0aed

  Copy full SHA for 5dd0aed

• Lint

  youssef-lr

  committed
  66c367d

  Copy full SHA for 66c367d

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  dc7f13d

  Copy full SHA for dc7f13d

• Add margin next to participant emails

  youssef-lr

  committed
  a22f42d

  Copy full SHA for a22f42d

Commits on Apr 25, 2024

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  57610d7

  Copy full SHA for 57610d7

• Always show confirmation for uneven splits

  youssef-lr

  committed
  ec56107

  Copy full SHA for ec56107

• Fix input style

  youssef-lr

  committed
  6cd30c2

  Copy full SHA for 6cd30c2

• Clean up code for section button

  youssef-lr

  committed
  4e71237

  Copy full SHA for 4e71237

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  076d99a

  Copy full SHA for 076d99a

• TS lint

  youssef-lr

  committed
  e064698

  Copy full SHA for e064698

• More lint

  youssef-lr

  committed
  e7ff3dc

  Copy full SHA for e7ff3dc

• Skip confirmation screen for smartscanned splits

  youssef-lr

  committed
  8f33768

  Copy full SHA for 8f33768

• Remove workaround for removing participants

  youssef-lr

  committed
  d5da181

  Copy full SHA for d5da181

• Bring back effect

  youssef-lr

  committed
  7eba6d0

  Copy full SHA for 7eba6d0

• Lint

  youssef-lr

  committed
  23e41fe

  Copy full SHA for 23e41fe

• Don't run unneeded logic unless we have modified shares

  youssef-lr

  committed
  061fcf1

  Copy full SHA for 061fcf1

• Translation

  youssef-lr

  committed
  946d75f

  Copy full SHA for 946d75f

• TS

  youssef-lr

  committed
  6590eb4

  Copy full SHA for 6590eb4

• More TS

  youssef-lr

  committed
  ed6f2e3

  Copy full SHA for ed6f2e3

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  624bad4

  Copy full SHA for 624bad4

• TS and comment imporvement

  youssef-lr

  committed
  af91070

  Copy full SHA for af91070

• Remove unintended changes

  youssef-lr

  committed
  2d0d0ba

  Copy full SHA for 2d0d0ba

• One last TS fix

  youssef-lr

  committed
  17c172b

  Copy full SHA for 17c172b

Commits on Apr 26, 2024

• Remove unintended change

  youssef-lr

  committed
  64a8525

  Copy full SHA for 64a8525

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  58da039

  Copy full SHA for 58da039

• Cleanup

  youssef-lr

  committed
  d49ab6d

  Copy full SHA for d49ab6d

• Cleanup

  youssef-lr

  committed
  d0ce531

  Copy full SHA for d0ce531

• Header new copy

  youssef-lr

  committed
  4df0953

  Copy full SHA for 4df0953

• Add comment

  youssef-lr

  committed
  dd6005f

  Copy full SHA for dd6005f

• Show current user's share in the split preview

  youssef-lr

  committed
  e46a6ce

  Copy full SHA for e46a6ce

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  1599a86

  Copy full SHA for 1599a86

• Fix form error disappearing

  youssef-lr

  committed
  0daec60

  Copy full SHA for 0daec60

• Fix merchant error missing when completing a split bill

  youssef-lr

  committed
  9a74508

  Copy full SHA for 9a74508

• Cleanup

  youssef-lr

  committed
  9dee700

  Copy full SHA for 9dee700

• Rename variable

  youssef-lr

  committed
  742e4e3

  Copy full SHA for 742e4e3

• Clean up code

  youssef-lr

  committed
  44ad9e1

  Copy full SHA for 44ad9e1

• Fix selection always moving to the end

  youssef-lr

  committed
  f3db250

  Copy full SHA for f3db250

Commits on Apr 28, 2024

• Proper fix for selection moving when amount changes

  youssef-lr

  committed
  f2b7bf6

  Copy full SHA for f2b7bf6

• Add comment

  youssef-lr

  committed
  7afaca5

  Copy full SHA for 7afaca5

• Clarify comment

  youssef-lr

  committed
  5c594aa

  Copy full SHA for 5c594aa

• Copy update

  youssef-lr

  committed
  fbad80a

  Copy full SHA for fbad80a

• Clean up code

  youssef-lr

  committed
  4deb9ec

  Copy full SHA for 4deb9ec

• Format amounts

  youssef-lr

  committed
  14d5775

  Copy full SHA for 14d5775

• Cleanup

  youssef-lr

  committed
  09cde3c

  Copy full SHA for 09cde3c

Commits on Apr 29, 2024

• Fix keyboard disabled on native

  youssef-lr

  committed
  51041d8

  Copy full SHA for 51041d8

• Update MoneyRequestAmountInput.tsx

  Show description for d00fb89
  

  youssef-lr

  and

  c3024

  authored
  d00fb89

  Copy full SHA for d00fb89

• Rename callback

  youssef-lr

  committed
  cea2cf8

  Copy full SHA for cea2cf8

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  4431b47

  Copy full SHA for 4431b47

• Bug fix

  youssef-lr

  committed
  dc97bfd

  Copy full SHA for dc97bfd

Commits on Apr 30, 2024

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  4b64601

  Copy full SHA for 4b64601

• TS fix

  youssef-lr

  committed
  3ac8cb3

  Copy full SHA for 3ac8cb3

Commits on May 1, 2024

• Fix input flickering

  youssef-lr

  committed
  9641c4d

  Copy full SHA for 9641c4d

• Bug fixes and add logic to native

  youssef-lr

  committed
  dbe50b9

  Copy full SHA for dbe50b9

• Style

  youssef-lr

  committed
  ce825c9

  Copy full SHA for ce825c9

• Add autoGrowDirection

  youssef-lr

  committed
  b3c6539

  Copy full SHA for b3c6539

• Cleanup

  youssef-lr

  committed
  eb81dff

  Copy full SHA for eb81dff

• Add a missing change to native

  youssef-lr

  committed
  36c5e35

  Copy full SHA for 36c5e35

• Cleanup

  youssef-lr

  committed
  fc3768b

  Copy full SHA for fc3768b

• TS

  youssef-lr

  committed
  c2303f0

  Copy full SHA for c2303f0

• Bug fix

  youssef-lr

  committed
  516f2de

  Copy full SHA for 516f2de

• Show dot in numeric keyboard

  youssef-lr

  committed
  9657b24

  Copy full SHA for 9657b24

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  1061dfd

  Copy full SHA for 1061dfd

Commits on May 2, 2024

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  0397b60

  Copy full SHA for 0397b60

Commits on May 3, 2024

• Add accessibility hit slope

  youssef-lr

  committed
  37deba6

  Copy full SHA for 37deba6

• Revert implementation of autgrow with direction to the left

  youssef-lr

  committed
  626ecda

  Copy full SHA for 626ecda

• Revert unintended changes

  youssef-lr

  committed
  7305b68

  Copy full SHA for 7305b68

• Don't format amount when text input is focused

  youssef-lr

  committed
  f745d48

  Copy full SHA for f745d48

• Don't break other existing amount inputs

  youssef-lr

  committed
  c4bc1fd

  Copy full SHA for c4bc1fd

• Remove unneeded prop

  youssef-lr

  committed
  188e7a2

  Copy full SHA for 188e7a2

• Remove unused param

  youssef-lr

  committed
  1332a1c

  Copy full SHA for 1332a1c

• Update styles and right-align input

  youssef-lr

  committed
  0d04ae4

  Copy full SHA for 0d04ae4

• Adjust padding based on prefix length relating to uppercase letters

  youssef-lr

  committed
  ceb81ed

  Copy full SHA for ceb81ed

• Replace comma input with period for native keyboards that show a comma

  youssef-lr

  committed
  ca87ee5

  Copy full SHA for ca87ee5

Commits on May 6, 2024

• Calculate exact width of the input based on total amount length

  youssef-lr

  committed
  c397762

  Copy full SHA for c397762

• Add callback removed by mistake

  youssef-lr

  committed
  8af33a4

  Copy full SHA for 8af33a4

• Allow editing formatted amount

  youssef-lr

  committed
  672e3ec

  Copy full SHA for 672e3ec

• Use fixed width for inputs and max length

  youssef-lr

  committed
  2b296bb

  Copy full SHA for 2b296bb

• Don't format amount on blur if it exceeds max length

  youssef-lr

  committed
  2056fb0

  Copy full SHA for 2056fb0

• Reset selection on blur on mobile

  youssef-lr

  committed
  d5ce4cf

  Copy full SHA for d5ce4cf

• Merge branch 'main' into youssef_uneven_splits_2

  youssef-lr

  committed
  209cac2

  Copy full SHA for 209cac2

Commits on May 7, 2024

• Fix paidBy section being sticky

  youssef-lr

  committed
  c9021df

  Copy full SHA for c9021df