-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix]: Bank account is not removed from wallet page if we remove it from workspace workflows page #40666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
DylanDylann
and removed request for
a team
April 21, 2024 22:55
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-04-22.at.16.25.29.movAndroid: mWeb ChromeScreen.Recording.2024-04-22.at.15.15.23.moviOS: NativeScreen.Recording.2024-04-22.at.16.30.20.moviOS: mWeb SafariScreen.Recording.2024-04-22.at.15.04.29.movMacOS: Chrome / SafariScreen.Recording.2024-04-22.at.16.05.18.movMacOS: DesktopScreen.Recording.2024-04-22.at.15.19.44.mov |
DylanDylann
approved these changes
Apr 22, 2024
puneetlath
approved these changes
Apr 22, 2024
Closing in favour of comment #39355 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Currently when we remove bank account from the workspace workflows page, it is not deleted from the wallet page, it is only reset, in this PR we fix that by deleting the Bank account
Fixed Issues
$ #39355
PROPOSAL: #39355 (comment)
Tests
Same as QA
Offline tests
Cannot be performed offline
QA Steps
Free Workspace
Free
workspace.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2024-04-22.at.4.22.33.AM.mov
MacOS: Desktop
Screen.Recording.2024-04-22.at.4.30.18.AM.mov
iOS: Native
Screen.Recording.2024-04-22.at.4.50.03.AM.mov
iOS: mWeb Safari
Screen.Recording.2024-04-22.at.6.42.28.AM.mov
Android: Native
Screen.Recording.2024-04-22.at.4.54.35.AM.mov
Android: mWeb Chrome