-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for viewing full screen Group Chat custom avatars #41586
Merged
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
7ce2242
enable view photo for group chat
nexarvo b12d3ef
create variable for filename
nexarvo 349ea43
Merge branch 'main' into feat/39850
nexarvo 5b6a7c6
add support for new chat view photo
nexarvo 66d8edc
revert removing extension
nexarvo 7d122da
use file name for new group chat draft
nexarvo 91f73c8
add newGroupChat query param for report avatar
nexarvo 20294f6
clean code
nexarvo c9993e8
Merge branch 'main' into feat/39850
nexarvo e4ae8b4
remove shouldDisableViewPhoto param
nexarvo b26a166
add: conditional for route depending on isNewGroupChat
nexarvo 1e29cab
add: parser to convert isNewGroupChat to boolean
nexarvo 0b0da6c
update: made isNewGroupChat query param optional
nexarvo 10eade0
refactor: clean code
nexarvo 232e787
fix: lint issues
nexarvo 8ff95be
fix: lint issues
nexarvo 284d1f0
fix: minor logic issues
nexarvo 3bf6bcf
fix: shouldShowNotFoundPage condition
nexarvo 2992240
Merge branch 'main' into feat/39850
nexarvo a4315b7
Merge branch 'main' into feat/39850
nexarvo f6f582c
fix: handle edge cases for group chat name
nexarvo cf3f942
fix: report title edge cases
nexarvo b91c010
fix: changes WIP
nexarvo 9c5b15e
Merge branch 'main' into feat/39850
nexarvo c0db9ef
fix: remove policy from not found
nexarvo 6d6953f
fix: lint issues
nexarvo 9d4a66f
add: originalFileName to report onyx
nexarvo 38d7f5b
fix: null checks for title
nexarvo 530df19
fix: lint issues
nexarvo bc18cf6
add: handle offline behaviour for view photo
nexarvo 55b8487
Merge branch 'main' into feat/39850
nexarvo db65135
add: isNewGroupChat to types after merge main
nexarvo 86fb5e7
fix: view photo when chat created offline(optimistic)
nexarvo 12d1da7
fix: lint issues
nexarvo 3695b6b
Merge branch 'main' into feat/39850
nexarvo 16ac2ff
Merge branch 'main' into feat/39850
nexarvo f2e6e7b
making a single getAllReports call and merging main
nexarvo 1c3e7db
verify parameters of buildOptimisticChatReport
nexarvo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add newGroupChat query param for report avatar
- Loading branch information
commit 91f73c8d5e1a6096c542819f7698719dfd26983a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -884,6 +884,7 @@ type AuthScreensParamList = SharedScreensParamList & { | |
}; | ||
[SCREENS.REPORT_AVATAR]: { | ||
reportID: string; | ||
newGroupChat: string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be boolean. Then in parse: {
newGroupChat: (newGroupChat: string) => newGroupChat === "true",
}, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is done. |
||
}; | ||
[SCREENS.NOT_FOUND]: undefined; | ||
[NAVIGATORS.LEFT_MODAL_NAVIGATOR]: NavigatorScreenParams<LeftModalNavigatorParamList>; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not pass the query param if the
newGroupChat
param is not trueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB. Change the param name to isNewGroupChat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Added conditional to return route based on isNewGroupChat here.