-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add possibility of excluding styles in useMarkdownStyles #41731
add possibility of excluding styles in useMarkdownStyles #41731
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb Chrome41731.mWeb-Chrome.mp4iOS: Native41731.iOS.moviOS: mWeb Safari41731.mWeb-Safari.movMacOS: Chrome / Safari41731.Web.mp4MacOS: Desktop41731.Desktop.mp4 |
@robertKozik The app is crashed on iOS and Android when typing on the 1:1 chat. iOS crashedTranslated Report (Full Report Below)Incident Identifier: 9AE09EB4-FA54-4CAC-A852-55007C1F95B9 Date/Time: 2024-05-11 22:01:19.3596 +0700 Exception Type: EXC_CRASH (SIGABRT) Triggered by Thread: 0 Last Exception Backtrace: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread Thread 1:: com.apple.uikit.eventfetch-thread Thread 2:: com.google.firebase.crashlytics.MachExceptionServer Thread 3:: com.facebook.react.JavaScript Thread 4:: hades Thread 5:: com.apple.NSURLConnectionLoader Thread 6:: com.apple.CFStream.LegacyThread Thread 7:: com.facebook.SocketRocket.NetworkThread Thread 8:: com.apple.CFSocket.private Thread 9:: hades Thread 10: Thread 11: Thread 12: Thread 13: Thread 14: Thread 15: Thread 16: Thread 17: Thread 18: Thread 19: Thread 20: Thread 21: Thread 22: Thread 23:: Dispatch queue: com.hackemist.SDWebImageDownloaderOperation.coderQueue (QOS: UNSPECIFIED) Thread 24: Thread 25: Thread 26:: JavaScriptCore libpas scavenger Thread 27:: JIT Worklist Helper Thread Thread 28:: JIT Worklist Helper Thread Thread 29:: JIT Worklist Helper Thread Thread 30:: Heap Helper Thread Thread 31:: Heap Helper Thread Thread 32:: Heap Helper Thread Thread 33:: Heap Helper Thread Thread 34:: Heap Helper Thread Thread 35:: Heap Helper Thread Thread 36:: Heap Helper Thread Thread 37: Thread 0 crashed with ARM Thread State (64-bit): Binary Images: EOF Full Report{"app_name":"New Expensify Dev","timestamp":"2024-05-11 22:01:24.00 +0700","app_version":"1.4.71","slice_uuid":"cc8ae1a4-e13e-3767-89f5-27370c1e80e1","build_version":"1.4.71.0","platform":7,"bundleID":"com.expensify.chat.dev","share_with_app_devs":1,"is_first_party":0,"bug_type":"309","os_version":"macOS 14.1.1 (23B81)","roots_installed":0,"name":"New Expensify Dev","incident_id":"9AE09EB4-FA54-4CAC-A852-55007C1F95B9"} ] Model: MacBookPro18,3, BootROM 10151.41.12, proc 8:6:2 processors, 16 GB, SMC Android crasheduntitled.2.mp4 |
This comment has been minimized.
This comment has been minimized.
Same thing happening in the adhoc build, @robertKozik can you merge main and check what is happening? |
That's fault of my changes - I'm on it right now, I'l should be able to resolve this in within couple of hours |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
Thanks for checking it out @rlinoz . I'm on it |
Should be resolved - now we are getting color value from the theme videoScreen.Recording.2024-05-14.at.18.37.05.mov |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I can't test the Android platform because of the current issue on the BE.
We did not find an internal engineer to review this PR, trying to assign a random engineer to #41597 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.75-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.75-1 🚀
|
Details
This PR adds additional argument to
useMarkdownStyle
which can be used to pass which styles should be disabled in particular context.We have to iterate over every object key and change it to undefined because in case of passing empty object instead, default styling from
react-native-live-markdown
would kick in.Fixed Issues
$ #41597
PROPOSAL: N/A
Tests
#room-name
)#room-name
)Offline tests
Same as test steps
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop