Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy category - Add GL Code #43149
Policy category - Add GL Code #43149
Changes from 45 commits
156a162
0fdc592
1a93283
2e34de5
e8f55eb
8e9262e
476161e
aa4bfb6
5790939
da4b4d0
7e455e1
09f10dc
e864c7e
6d8788f
17f33a8
ee455af
f92e72e
46ef1b4
92b7424
690f59c
17b9ca5
a1152d4
69c2ba1
3495676
1e4dd4d
1a26ba1
4062539
e1a58a0
e02ceae
4ca6c61
b4fb2aa
540a524
bfe2abc
0f5854a
9ffae3d
26615d5
df7a56e
ead9b90
c9ce122
48d1abb
bb0f7f0
84513ac
c519409
e4aabf8
ca614a4
6c7c294
16b6308
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB - damn i wish we could rename all of these to "Policy" for consistency...... But not really appropriate in this PR lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm why not
CONST.FORM_CHARACTER_LIMIT
? I didn't look at the doc recently, but i imagine GL codes are never > 50 characters in length?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Beamanator if im not wrong, in database the limit is 256 chars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merp sorry for not responding here - you def may be right, but the better question to me is: Can GL codes ever get anywhere near 50 characters even? If not, I'd prefer we limit to 50 chars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gonals any opinion here? 🤷