Update search to work with chat rooms with empty participants + prevent searching for chat rooms by participant #43626

jasperhuangg · 2024-06-12T23:55:26Z

Details

Needed for https://github.com/Expensify/Auth/pull/11238

When searching for reports we don't send back the participants since they aren't needed to display the search results and can be extremely large for certain types of rooms.

We need to allow chat rooms with empty participants to display in this case. There shouldn't ever be default rooms with empty participants in any other case.

We also don't add room participant logins/display names to the search value consideration when filtering search results.

Fixed Issues

$ Related to #42989
PROPOSAL:

Tests

Comment this line out so we don't load any reports after signing in.
Checkout and build https://github.com/Expensify/Auth/pull/11238

Create accountA on a domain that doesn't exist yet. Generate a domain for this account with ../script/clitools.sh generator:domain. Set a display name for this account that does not contain parts of the account's login.
Create accountB on the same domain. Set a display name for this account that does not contain parts of the account's login.
Sign back into accountA and create a workspace on this account. This should generate #announce and #admins rooms.
Invite accountB to this workspace as an employee.
Create public, workspace, and private rooms on this workspace.
Sign out of accountA to clear the Onyx store.
Sign back into accountA, and open the chat finder page (+).
Search for the #announce room's name (i.e. #announce). Verify the #announce room appears correctly. Open the #announce room, verify it displays correctly (namely that the participants are populated in the Members page).
Repeat steps 6-8 for all the #admins room, the public room, workspace room, private room, and the #domain.com room.
Sign out of accountA to clear the Onyx store.
Sign back into accountA, and search for accountB's login. Verify only a DM with them and their policy expense chat appear in the results.
Sign out of accountA to clear the Onyx store.
Search for accountB's display name. Verify only a DM with them and their policy expense chat appear in the results.

QA Steps

We're just verifying that the chat finder page still works as it does on production since there shouldn't be any change to the data that it's working with since this needs to be merged before the Auth PR.

Create accountA and set a display name for this account that does not contain parts of the account's login.
Create accountB and set a display name for this account that does not contain parts of the account's login.
Sign back into accountA and create a workspace on this account. This should generate #announce and #admins rooms.
Invite accountB to this workspace as an employee.
Create public, workspace, and private rooms on this workspace.
Sign out of accountA.
Sign back into accountA, and open the chat finder page (+).
Search for the #announce room's name (i.e. #announce). Verify the #announce room appears correctly. Open the #announce room, verify it displays correctly (namely that the participants are populated in the Members page).
Repeat steps 6-8 for all the #admins room, the public room, workspace room, private room, and the #domain.com room.
Sign out of accountA to clear the Onyx store.
Sign back into accountA, and search for accountB's login. Verify only a DM with them and their policy expense chat appear in the results.
Sign out of accountA to clear the Onyx store.
Search for accountB's display name. Verify only a DM with them and their policy expense chat appear in the results

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

… for reports

…omsEmptyParticipantsChatFinder

melvin-bot · 2024-06-17T19:39:33Z

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…lay names check

jasperhuangg · 2024-06-17T20:37:03Z

Converting to draft while I fix some bugs I noticed during testing @marcaaron

…'t have participants in Onyx

jasperhuangg · 2024-06-18T19:07:25Z

@marcaaron putting this on draft while the convo here is sorted

…omsEmptyParticipantsChatFinder

jasperhuangg · 2024-07-03T20:28:21Z

Sorry for the delay, been prioritizing #fireroom-2024-07-02-newdot-deploy-blocked, now that that's done I'll address the comments!

…omsEmptyParticipantsChatFinder

rlinoz

Looks good to me. Great job on this one you both!

Just that one NAB about adding the logs.

marcaaron · 2024-07-05T19:37:09Z

LGTM, not sure if we need such extensive commit history for the small number of changes that we landed on 😄

marcaaron · 2024-07-05T19:37:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

jasperhuangg · 2024-07-08T17:43:04Z

Just fixed the conflicts and ran through the manual tests again, we should be ready to merge @rlinoz @marcaaron 🙇

OSBotify · 2024-07-08T18:11:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-10T11:19:14Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:36:28Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-11T10:16:43Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-11T10:36:19Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-15T20:18:50Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-17T00:18:01Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

allow displaying default rooms with empty participants when searching…

30c08c8

… for reports

jasperhuangg self-assigned this Jun 12, 2024

jasperhuangg added 2 commits June 17, 2024 12:24

Merge branch 'main' of github.com:Expensify/App into jasper-defaultRo…

e85e860

…omsEmptyParticipantsChatFinder

add comment

72e3f6d

jasperhuangg marked this pull request as ready for review June 17, 2024 19:39

jasperhuangg requested a review from a team as a code owner June 17, 2024 19:39

melvin-bot bot removed the request for review from a team June 17, 2024 19:39

melvin-bot bot requested a review from marcaaron June 17, 2024 19:39

style

76b6469

jasperhuangg marked this pull request as draft June 17, 2024 20:36

prevent rooms from getting filtered out during participantLogins/disp…

57d3356

…lay names check

jasperhuangg added 2 commits June 17, 2024 14:44

style

932b8ce

ensure chat rooms don't get filtered out in the front-end if they don…

1464ba1

…'t have participants in Onyx

jasperhuangg marked this pull request as ready for review June 17, 2024 23:27

jasperhuangg marked this pull request as draft June 17, 2024 23:28

jasperhuangg added 2 commits June 17, 2024 16:29

update comment

e8cae10

remove unused

acc477f

jasperhuangg marked this pull request as ready for review June 18, 2024 00:16

jasperhuangg marked this pull request as draft June 18, 2024 19:07

jasperhuangg added 2 commits June 21, 2024 12:52

Merge branch 'main' of github.com:Expensify/App into jasper-defaultRo…

941748d

…omsEmptyParticipantsChatFinder

prevent all chat rooms from being searchable by participant

978ad3b

jasperhuangg changed the title ~~Allow displaying default rooms with empty participants when searching for reports~~ Update search to work with chat rooms with empty participants + prevent searching for chat rooms by participant Jun 21, 2024

jasperhuangg added 4 commits June 21, 2024 15:25

Allow empty rooms to show up when searching

3e6b24e

remove debug logs

6aebea1

remove debug logs

d0fb81d

update comment

76f675d

jasperhuangg marked this pull request as ready for review June 24, 2024 20:49

jasperhuangg added 3 commits July 1, 2024 12:03

condense logic and add comment

d1c6c00

Merge branch 'main' of github.com:Expensify/App into jasper-defaultRo…

9e4ab91

…omsEmptyParticipantsChatFinder

remove unused

f5dc4f7

jasperhuangg added 3 commits July 3, 2024 13:28

Merge branch 'main' of github.com:Expensify/App into jasper-defaultRo…

f8352cb

…omsEmptyParticipantsChatFinder

consolidate logic

505e31a

consolidate logic

86735ab

jasperhuangg requested review from marcaaron and rlinoz July 3, 2024 23:29

rlinoz previously approved these changes Jul 5, 2024

View reviewed changes

marcaaron previously approved these changes Jul 5, 2024

View reviewed changes

fix merge conflicts

31d0194

jasperhuangg dismissed stale reviews from marcaaron and rlinoz via 31d0194 July 8, 2024 17:18

jasperhuangg requested review from marcaaron and rlinoz July 8, 2024 17:20

rlinoz approved these changes Jul 8, 2024

View reviewed changes

jasperhuangg merged commit 6acc21c into main Jul 8, 2024
16 checks passed

jasperhuangg deleted the jasper-defaultRoomsEmptyParticipantsChatFinder branch July 8, 2024 18:01

github-actions bot mentioned this pull request Jul 10, 2024

Deploy Checklist: New Expensify 2024-07-10 #45144

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update search to work with chat rooms with empty participants + prevent searching for chat rooms by participant #43626

Update search to work with chat rooms with empty participants + prevent searching for chat rooms by participant #43626

jasperhuangg commented Jun 12, 2024 •

edited

Loading

melvin-bot bot commented Jun 17, 2024

jasperhuangg commented Jun 17, 2024

jasperhuangg commented Jun 18, 2024

jasperhuangg commented Jul 3, 2024

rlinoz left a comment

marcaaron commented Jul 5, 2024

marcaaron commented Jul 5, 2024 •

edited

Loading

jasperhuangg commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 11, 2024

OSBotify commented Jul 11, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

Update search to work with chat rooms with empty participants + prevent searching for chat rooms by participant #43626

Update search to work with chat rooms with empty participants + prevent searching for chat rooms by participant #43626

Conversation

jasperhuangg commented Jun 12, 2024 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 17, 2024

jasperhuangg commented Jun 17, 2024

jasperhuangg commented Jun 18, 2024

jasperhuangg commented Jul 3, 2024

rlinoz left a comment

Choose a reason for hiding this comment

marcaaron commented Jul 5, 2024

marcaaron commented Jul 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jasperhuangg commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 11, 2024

OSBotify commented Jul 11, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

jasperhuangg commented Jun 12, 2024 •

edited

Loading

marcaaron commented Jul 5, 2024 •

edited

Loading