-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Enable no-unsafe-assignment
eslint rule
#44003
Merged
mountiny
merged 45 commits into
Expensify:main
from
software-mansion-labs:ts/no-unsafe-assignment
Jul 4, 2024
Merged
Changes from 42 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
2f676e8
Pass generic parameter to all lottie requires
blazejkustra c2cbd8e
Remove unsafe assigment
blazejkustra dd47f88
Add asserts to JSON.parse
blazejkustra 711d028
Use assertion for @vue/preload-webpack-plugin require
blazejkustra 13f8c0f
Fix some of jest scripts and mocks
blazejkustra a7ab173
Add assertion to Console module
blazejkustra 7fa04b4
Add assertions to yaml parser
blazejkustra 680070a
Change assertion from any to a random actionName
blazejkustra af0beb8
Add type to Electron download event listener
blazejkustra 1c1b9c4
Remove unnecessary eslint no-unsafe-return comments
blazejkustra cc84252
Fix jest.requireActual usage
blazejkustra 4b6d7d4
Add assertion to other Json.parse
blazejkustra 582a0b4
Add generic types to requires
blazejkustra a7fee2d
Mock middleware properly
blazejkustra 14e4588
Assert that prop is a string
blazejkustra c3cab6b
Add missing args to octokit mocked functions
blazejkustra 88de71a
Add type for backgroundColor
blazejkustra 1f3cd34
Fix minor type issues
blazejkustra 1141173
Augment objectContaining and arrayContaining to return unknown instea…
blazejkustra 31f64f4
Fix minor errors
blazejkustra 3df3669
Add more assertions
blazejkustra 1b6e0a9
Merge branch 'ts/enable-no-unsafe-member-access' into ts/no-unsafe-as…
blazejkustra 267719f
Fix child props
blazejkustra 206cc3d
Rerun lint
blazejkustra 1c2b63b
Merge branch 'ts/enable-no-unsafe-member-access' into ts/no-unsafe-as…
blazejkustra 82c9d74
Fix more eslint errors
blazejkustra b9d363e
Merge branch 'ts/enable-no-unsafe-member-access' into ts/no-unsafe-as…
blazejkustra d6f851c
Merge branch 'main' into ts/no-unsafe-assignment
blazejkustra 021e09f
Merge branch 'main' into ts/no-unsafe-assignment
blazejkustra 99cffb5
Address review comments
blazejkustra bfb7032
Fix one more error in tests
blazejkustra f9578f9
Fix after internal review
blazejkustra 22fd2c6
Merge branch 'main' into ts/no-unsafe-assignment
blazejkustra e47f7e1
Disable rules in debug.ts
blazejkustra b8391ed
Fix prettier
blazejkustra 8ca6a9a
Merge branch 'main' into ts/no-unsafe-assignment
blazejkustra 825b310
Fix eslint errors
blazejkustra 2f656bf
Merge branch 'main' into ts/no-unsafe-assignment
blazejkustra 3d649b3
Add eslint disable to a todo comment
blazejkustra 0032c88
Merge branch 'main' into ts/no-unsafe-assignment
blazejkustra 45b02a7
Fix eslint
blazejkustra 20bb70c
Merge branch 'main' into ts/no-unsafe-assignment
blazejkustra 185901f
Cast to unknown
blazejkustra f9587a0
Merge branch 'main' into ts/no-unsafe-assignment
blazejkustra 0cc3676
Add eslint disable to a todo comment
blazejkustra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
/* eslint-disable @typescript-eslint/no-unsafe-assignment */ | ||
const {fs} = require('memfs'); | ||
|
||
module.exports = fs; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we renamed this, I think
PackageJSON
works better with out naming conventions