-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not refresh draft txn after redirect #44363
Merged
puneetlath
merged 15 commits into
Expensify:main
from
dominictb:fix/40936-init-money-req
Jul 11, 2024
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d10afcb
fix: do not refresh draft txn after redirect
dominictb 40bbcd7
Merge remote-tracking branch 'origin/main' into fix/40936-init-money-req
dominictb 5cd9f11
fix: update explanation comment
dominictb da44443
fix: navigate to scan page instead of start page
dominictb c857885
fix: move the user back to start page if no receipt upload
dominictb 26dd780
Revert "fix: move the user back to start page if no receipt upload"
dominictb fc9721d
Revert "fix: navigate to scan page instead of start page"
dominictb 7cc38de
Revert "fix: update explanation comment"
dominictb e77ee51
Revert "fix: do not refresh draft txn after redirect"
dominictb 78260a1
Merge remote-tracking branch 'origin/main' into fix/40936-init-money-req
dominictb e456298
fix: add a flag to keep the existing draft txn data
dominictb 23493ff
fix: update lint and prettier
dominictb db23adf
Merge remote-tracking branch 'origin/main' into fix/40936-init-money-req
dominictb 2f5cd9b
fix: update logic of checking shouldKeepData
dominictb 07e9c6e
fix: remove redundant comment
dominictb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we resetting all these props? Shouldn't be just the report id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that the transaction should look like it is re-created, so the data like
reportID
,created
,currency
, eventransactionID
(a bit redundant),isFromGlobalCreated
should be updated, but the other old data will be kept intact sinceiouRequestType
is the same