Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Show Unapprove button only for expense reports & not in transaction thread header if > 1 transaction #45049

Merged
merged 4 commits into from
Jul 9, 2024
Merged

[CP Staging] Show Unapprove button only for expense reports & not in transaction thread header if > 1 transaction #45049

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f881b0
Show unapprove only for expense reports
Beamanator Jul 9, 2024
37b2fe0
Also don't show unapproved for archived rooms duh
Beamanator Jul 9, 2024
8a8e5cd
Wait that's not necessary
Beamanator Jul 9, 2024
9fafd6b
Look at current report, not parent
Beamanator Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/ReportDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD
const shouldShowDeleteButton = shouldShowTaskDeleteButton || canDeleteRequest;

const canUnapproveRequest =
ReportUtils.isMoneyRequestReport(moneyRequestReport) &&
ReportUtils.isExpenseReport(moneyRequestReport) &&
Beamanator marked this conversation as resolved.
Show resolved Hide resolved
(ReportUtils.isReportManager(moneyRequestReport) || isPolicyAdmin) &&
(ReportUtils.isReportApproved(moneyRequestReport) || ReportUtils.isReportManuallyReimbursed(moneyRequestReport));

Expand Down
Loading