Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Revert "Add support for viewing full screen Group Chat custom avatars" #45863

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Jul 21, 2024

Staright revert #41586

Details

This revert fixes showing avatars in the full screen mode

Fixed Issues

$ #45842
$ #45824

Tests

QA confirmed this was fixed https://expensify.slack.com/archives/C9YU7BX5M/p1721651193695839?thread_ts=1721649904.456749&cid=C9YU7BX5M

  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Go to workspace chat.
  4. Click on the chat header.
  5. Click workspace avatar.
  6. Note that it opens avatar in full screen.
  7. Delete the workspace.
  8. Go to workspace chat.
  9. Click on the chat header.
  10. Click workspace avatar.
  11. Avatar for a deleted workspace will still display when viewed full screen.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

@mountiny mountiny self-assigned this Jul 21, 2024
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/45863/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45863/NewExpensify.dmg https://45863.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@mountiny mountiny changed the title Revert "Add support for viewing full screen Group Chat custom avatars" [CP Staging] Revert "Add support for viewing full screen Group Chat custom avatars" Jul 22, 2024
@mountiny mountiny marked this pull request as ready for review July 22, 2024 12:53
@mountiny mountiny requested a review from a team as a code owner July 22, 2024 12:53
@melvin-bot melvin-bot bot removed the request for review from a team July 22, 2024 12:53
Copy link

melvin-bot bot commented Jul 22, 2024

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from abdulrahuman5196 July 22, 2024 12:53
@mountiny mountiny removed the request for review from abdulrahuman5196 July 22, 2024 12:53
@mountiny mountiny merged commit a9a45ac into main Jul 22, 2024
12 of 18 checks passed
@mountiny mountiny deleted the revert-41586-feat/39850 branch July 22, 2024 12:54
@melvin-bot melvin-bot bot added the Emergency label Jul 22, 2024
Copy link

melvin-bot bot commented Jul 22, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Jul 22, 2024
[CP Staging] Revert "Add support for viewing full screen Group Chat custom avatars"

(cherry picked from commit a9a45ac)
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants