[Guided Setup: Stage 3] Send the Onboarding Message After Sign-In #46052

cdOut · 2024-07-23T16:26:54Z

Details

Added logic for sending onboarding messages through concierge after sign-in through a magic link sent via email for multiple cases.

Fixed Issues

$ #45044
PROPOSAL:

Tests

Workspace Non-admin:

On the first account create or use an existing worspace
Add a member using an email add an account that you know doesn't exist yet
Make sure the account you've invited is set as just a Member
Proceed to your email and press on the link on the bottom of the invitation email you've received
Confirm that that a Concierge message appears and it shows the correct content, as well as an onboarding video.

Workspace Admin:

On the first account create or use an existing worspace
Add a member using an email add an account that you know doesn't exist yet
Press on the newly invited user and make sure that his role is set to Admin
Proceed to your email and press on the link on the bottom of the invitation email you've received
Confirm that that a Concierge message appears and it shows the correct content, as well as an onboarding video.

DM / Group Chat:

On the first account create or use an existing DM or Group Chat
Add a member using an email add an account that you know doesn't exist yet, in the case of the room you can add by mentioning the user
Proceed to your email and press on the link on the bottom of the invitation email you've received
Confirm that that a Concierge message appears and it shows the correct content, as well as an onboarding video. Make sure the ~~Start a chat~~ is checked off & struck through.

User-created Room:

On the first account create or use an existing user-created room
Add a member using an email add an account that you know doesn't exist yet, do it by mentioning the gmail in the room chat
Proceed to your email and press on the link on the bottom of the invitation email you've received
Confirm that that a Concierge message appears and it shows the correct content, as well as an onboarding video.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Workspace Admin

WEB.WORKSPACE.ADMIN.low.res.mov

Workspace Non-Admin

WEB.WORKSPACE.NON-ADMIN.low.res.mov

merge main into @cdOut/guided-3-onboarding

melvin-bot · 2024-07-29T07:38:06Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

merge main into @cdOut/guided-3-onboarding

trjExpensify · 2024-07-29T16:02:22Z

👋 @getusha can you review this one today, please? Thanks!

getusha · 2024-07-29T20:46:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Workspace Admin

screen-recording-2024-09-26-at-45054-in-the-afternoon_GAIw0CSx.mp4

Workspace Non-Admin

Screen.Recording.2024-09-26.at.4.58.14.in.the.afternoon.mov

Android: mWeb Chrome

Workspace Admin

Workspace Non-Admin

iOS: Native

Workspace Admin

Screen.Recording.2024-09-26.at.5.11.22.in.the.afternoon.mov

iOS: mWeb Safari

Workspace Admin

Workspace Non-Admin

MacOS: Chrome / Safari

Workspace Non-Admin

screen-recording-2024-09-25-at-101910-in-the-morning_QRIpKXNH.mp4

Workspace Admin

Screen.Recording.2024-09-25.at.6.37.21.in.the.evening.mov

User-created Room / DM / Group Chat:

MacOS: Desktop

Workspace Non-Admin

User-created Room / DM / Group Chat:

getusha · 2024-07-30T04:29:49Z

src/CONST.ts

@@ -4297,7 +4332,7 @@ const CONST = {
                    type: 'meetGuide',
                    autoCompleted: false,
                    title: 'Meet your setup specialist',
-                    description: ({adminsRoomLink}: {adminsRoomLink: string}) =>


Why is this?

@kosmydel who originally worked on this wanted to have better typescript checks for the message types so this has been removed in favor of adding a satisfies Record<OnboardingPurposeType, OnboardingMessageType> to the whole message CONST definition just to be clear that the values defined there are correct.

src/libs/actions/Report.ts

getusha · 2024-07-30T04:57:38Z

Not able to get an invitation email after inviting new member to a workspace, is it working for you? @cdOut

cdOut · 2024-07-30T07:30:02Z

@getusha I've cleaned up the code after your review.

I did not encounter an issue with receiving the invitation emails, no. Did you check after by logging into the invited account if they are even being properly added to said workspace?

trjExpensify · 2024-07-30T17:40:52Z

@getusha let me know what email address you used to invite and invited.

getusha · 2024-07-30T18:28:41Z

Automated Tests

@cdOut Is this planned to be worked on separately? #45044

And lets make sure we are covering the cases in the feature description in test steps.

cdOut · 2024-07-30T20:56:26Z

Automated Tests
@cdOut Is this planned to be worked on separately? #45044

@deetergp should the automated tests for it be added here or handled separately?

And lets make sure we are covering the cases in the feature description in test steps.

Also I'm fairly sure all the cases are handled in test steps, I've separated them into three different sections.

merge main into @cdOut/guided-3-onboarding

…essage

deetergp · 2024-11-08T18:54:10Z

@getusha That pesky console error keeps popping back up and is on the back end. Let's not hold on that.

getusha · 2024-11-08T19:08:37Z

DM / Group Chat:

On the first account create or use an existing DM or Group Chat
Add a member using an email add an account that you know doesn't exist yet, in the case of the room you can add by mentioning the user
Proceed to your email and press on the link on the bottom of the invitation email you've received
Confirm that that a Concierge message appears and it shows the correct content, as well as an onboarding video. Make sure the Start a chat is checked off & struck through.

Not getting emails for this flow anymore ^, i got one the first time which didn't look right @deetergp

Edit: same with rooms, i tried with different account as well

trjExpensify · 2024-11-08T20:06:00Z

@trjExpensify the Hey 👋 seems duplicate in the case of admin invitation, does it look fine to you?

Hm, it looks a bit weird. @danielrvidal I'll defer to you though.

deetergp · 2024-11-08T21:00:19Z

@getusha For DM & Group Chats, did you add a comment in either chat?

danielrvidal · 2024-11-11T21:33:27Z

@getusha good find. I think we should remove the "Hey ✋" at the beginning of the admin copy and just start with "As an admin..."

Let's please make that update.

deetergp · 2024-11-11T22:08:16Z

@getusha To elaborate on my previous comment, for DMs & Group Chats, you might need to add a comment in the chat as the inviting user after inviting the new user, then wait for the normal "notify offline users of activity" time to elapse, which is about 10 minutes. They should get sent immediately, but we have a regression that is preventing that from happening, but it shouldn't hold this PR up. If you do the above and still do not get an invitation, then that's a new regression… But they should send.

zfurtak · 2024-11-12T02:02:34Z

Hi, I updated the admin message and merged latest main. Are we good to merge or do we want to dig into above issues? 🔍

cc: @deetergp @getusha

blazejkustra · 2024-11-12T16:37:33Z

@getusha Could you finalize Reviewer Checklist? I think we are good to merge this 😄

deetergp · 2024-11-12T18:56:01Z

@getusha I just went through testing DMs & Group Chat invites and in both cases, I had to add a comment after inviting the new user and then wait ten minutes in order for it to send a notification, but in both cases it sent. In the case of the DM, the link worked and the onboarding messages were created. In the case of Group Chat the link took me to a "Magic code expired" page, which is a regression, but if I signed in again as the user, requesting a new magic code, the onboarding messages were sent.

The regression should not hold us up and will be dealt with separately, let's get this merged!

getusha

LGTM, thanks!

deetergp

Woohoo! LGTM 🎉

OSBotify · 2024-11-13T16:47:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-14T00:52:35Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

IuliiaHerets · 2024-11-14T10:35:54Z

This PR is failing because of issues #52540 and #52546

blazejkustra · 2024-11-14T11:43:48Z

This PR is failing because of issues #52540 and #52546

@IuliiaHerets These are known issues, check the comment above: #46052 (comment)

@deetergp I'm guessing both are backend issues, so please handle it internally. If you need help on the FE side, let me know 🙇

deetergp · 2024-11-14T17:53:22Z

@IuliiaHerets Both issues are known, though I don't think we had GHs for them till now, so thanks for that. We will definitely want to add regression tests for both of them. But for now, use the workarounds from the comment @blazejkustra mentioned to verify that the onboarding messages are sent.

github-actions · 2024-11-15T14:15:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.62-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

allgandalf · 2024-11-25T07:14:05Z

src/libs/actions/Report.ts

+
+    const isInviteOnboardingComplete = introSelected?.isInviteOnboardingComplete ?? false;
+
+    if (introSelected && !isInviteOnboardingComplete) {


We should had also checked if the onboarding has been completed, this missed implementation caused the messages to be duplicated. This caused #52543

cdOut added 2 commits July 23, 2024 18:13

add onboarding message for newly created admins

2026504

Merge branch 'main' into @cdOut/guided-3-onboarding

8dd7c27

trjExpensify mentioned this pull request Jul 23, 2024

[WIP] [Guided Setup: Stage 3] Send the Onboarding Message After Sign-In #45267

Closed

50 tasks

cdOut added 4 commits July 26, 2024 10:16

Merge branch 'main' into @cdOut/guided-3-onboarding

cee209d

separate selectable onboarding choices from ones sent through API

9610a9f

correct indexing of onboarding messages for admin and employer

2b923ce

Merge branch 'main' into @cdOut/guided-3-onboarding

e139d38

merge main into @cdOut/guided-3-onboarding

cdOut marked this pull request as ready for review July 29, 2024 07:38

cdOut requested a review from a team as a code owner July 29, 2024 07:38

melvin-bot bot requested review from getusha and removed request for a team July 29, 2024 07:38

cdOut added 2 commits July 29, 2024 11:10

clean-up comment and correct CONST onboarding message selector

0089f73

Merge branch 'main' into @cdOut/guided-3-onboarding

cb724a5

merge main into @cdOut/guided-3-onboarding

getusha reviewed Jul 30, 2024

View reviewed changes

code review cleanup

bccc3b4

fix lint errors

8b1e02f

cdOut added 6 commits August 7, 2024 12:04

Merge branch 'main' into @cdOut/guided-3-onboarding

e0a93d8

merge main into @cdOut/guided-3-onboarding

fix CONST definition for multiple onboarding choices using the same m…

7a507fb

…essage

correct guidedSetupParams for this onboarding flow

2cb743c

Merge branch 'main' into @cdOut/guided-3-onboarding

99cc4fa

Merge branch 'main' into @cdOut/guided-3-onboarding

2b4e248

set as const and fix typing, remove unused imports

bc16df0

zfurtak added 2 commits November 12, 2024 01:43

Adjusted message for admin

c3c6e44

Merge main

346157d

getusha approved these changes Nov 13, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp November 13, 2024 06:10

Merge branch 'main' into @cdOut/guided-3-onboarding

54c71f8

deetergp approved these changes Nov 13, 2024

View reviewed changes

deetergp merged commit e6b4167 into Expensify:main Nov 13, 2024
16 checks passed

github-actions bot mentioned this pull request Nov 14, 2024

Deploy Checklist: New Expensify 2024-11-14 #52512

Closed

47 tasks

bernhardoj mentioned this pull request Nov 14, 2024

[HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] [$250] mweb/Chrome - Thread - Not here page when open multi level threads #52204

Closed

8 tasks

IuliiaHerets mentioned this pull request Nov 14, 2024

[$250] Web - Guided Setup - No email received for a new account added in a group chat #52540

Closed

8 tasks

IuliiaHerets mentioned this pull request Nov 14, 2024

Web - Invitation bottom link leads to magic code expired page when invited in a room #52546

Closed

8 tasks

This was referenced Nov 14, 2024

[Awaiting checklist] [$250] Web - Concierge - Onboarding tasks in Concierge chat is duplicated when switch chat #52543

Closed

Concierge - Start a chat task is marked as comleted when select Chat and split expenses option #52544

Closed

blazejkustra mentioned this pull request Nov 14, 2024

Fix that onboarding tasks are duplicated when switching chat #52585

Merged

48 tasks

allgandalf reviewed Nov 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Guided Setup: Stage 3] Send the Onboarding Message After Sign-In #46052

[Guided Setup: Stage 3] Send the Onboarding Message After Sign-In #46052

cdOut commented Jul 23, 2024 •

edited

Loading

melvin-bot bot commented Jul 29, 2024

trjExpensify commented Jul 29, 2024

getusha commented Jul 29, 2024 •

edited

Loading

getusha Jul 30, 2024

cdOut Jul 30, 2024

getusha commented Jul 30, 2024

cdOut commented Jul 30, 2024

trjExpensify commented Jul 30, 2024

getusha commented Jul 30, 2024

cdOut commented Jul 30, 2024

deetergp commented Nov 8, 2024

getusha commented Nov 8, 2024 •

edited

Loading

trjExpensify commented Nov 8, 2024

deetergp commented Nov 8, 2024

danielrvidal commented Nov 11, 2024

deetergp commented Nov 11, 2024

zfurtak commented Nov 12, 2024

blazejkustra commented Nov 12, 2024

deetergp commented Nov 12, 2024

getusha left a comment

deetergp left a comment

OSBotify commented Nov 13, 2024

github-actions bot commented Nov 14, 2024

IuliiaHerets commented Nov 14, 2024 •

edited

Loading

blazejkustra commented Nov 14, 2024 •

edited

Loading

deetergp commented Nov 14, 2024

github-actions bot commented Nov 15, 2024

allgandalf Nov 25, 2024 •

edited

Loading


		const isInviteOnboardingComplete = introSelected?.isInviteOnboardingComplete ?? false;

		if (introSelected && !isInviteOnboardingComplete) {

[Guided Setup: Stage 3] Send the Onboarding Message After Sign-In #46052

[Guided Setup: Stage 3] Send the Onboarding Message After Sign-In #46052

Conversation

cdOut commented Jul 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Workspace Non-admin:

Workspace Admin:

DM / Group Chat:

User-created Room:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Workspace Admin

Workspace Non-Admin

melvin-bot bot commented Jul 29, 2024

trjExpensify commented Jul 29, 2024

getusha commented Jul 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

getusha Jul 30, 2024

Choose a reason for hiding this comment

cdOut Jul 30, 2024

Choose a reason for hiding this comment

getusha commented Jul 30, 2024

cdOut commented Jul 30, 2024

trjExpensify commented Jul 30, 2024

getusha commented Jul 30, 2024

cdOut commented Jul 30, 2024

deetergp commented Nov 8, 2024

getusha commented Nov 8, 2024 • edited Loading

trjExpensify commented Nov 8, 2024

deetergp commented Nov 8, 2024

danielrvidal commented Nov 11, 2024

deetergp commented Nov 11, 2024

zfurtak commented Nov 12, 2024

blazejkustra commented Nov 12, 2024

deetergp commented Nov 12, 2024

getusha left a comment

Choose a reason for hiding this comment

deetergp left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 13, 2024

github-actions bot commented Nov 14, 2024

IuliiaHerets commented Nov 14, 2024 • edited Loading

blazejkustra commented Nov 14, 2024 • edited Loading

deetergp commented Nov 14, 2024

github-actions bot commented Nov 15, 2024

allgandalf Nov 25, 2024 • edited Loading

Choose a reason for hiding this comment

cdOut commented Jul 23, 2024 •

edited

Loading

getusha commented Jul 29, 2024 •

edited

Loading

getusha commented Nov 8, 2024 •

edited

Loading

IuliiaHerets commented Nov 14, 2024 •

edited

Loading

blazejkustra commented Nov 14, 2024 •

edited

Loading

allgandalf Nov 25, 2024 •

edited

Loading