-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] e2e: handle process id has changed #46279
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
45 changes: 45 additions & 0 deletions
45
patches/@perf-profiler+android+0.13.0+001+pid-changed.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
diff --git a/node_modules/@perf-profiler/android/dist/src/commands/platforms/UnixProfiler.js b/node_modules/@perf-profiler/android/dist/src/commands/platforms/UnixProfiler.js | ||
index 657c3b0..c97e363 100644 | ||
--- a/node_modules/@perf-profiler/android/dist/src/commands/platforms/UnixProfiler.js | ||
+++ b/node_modules/@perf-profiler/android/dist/src/commands/platforms/UnixProfiler.js | ||
@@ -113,7 +113,7 @@ class UnixProfiler { | ||
} | ||
pollPerformanceMeasures(bundleId, { onMeasure, onStartMeasuring = () => { | ||
// noop by default | ||
- }, }) { | ||
+ }, onPidChanged = () => {}}) { | ||
let initialTime = null; | ||
let previousTime = null; | ||
let cpuMeasuresAggregator = new CpuMeasureAggregator_1.CpuMeasureAggregator(this.getCpuClockTick()); | ||
@@ -170,6 +170,7 @@ class UnixProfiler { | ||
previousTime = timestamp; | ||
}, () => { | ||
logger_1.Logger.warn("Process id has changed, ignoring measures until now"); | ||
+ onPidChanged(); | ||
reset(); | ||
}); | ||
} | ||
diff --git a/node_modules/@perf-profiler/android/src/commands/platforms/UnixProfiler.ts b/node_modules/@perf-profiler/android/src/commands/platforms/UnixProfiler.ts | ||
index be26fe6..0473f78 100644 | ||
--- a/node_modules/@perf-profiler/android/src/commands/platforms/UnixProfiler.ts | ||
+++ b/node_modules/@perf-profiler/android/src/commands/platforms/UnixProfiler.ts | ||
@@ -105,9 +105,11 @@ export abstract class UnixProfiler implements Profiler { | ||
onStartMeasuring = () => { | ||
// noop by default | ||
}, | ||
+ onPidChanged = () => {}, | ||
}: { | ||
onMeasure: (measure: Measure) => void; | ||
onStartMeasuring?: () => void; | ||
+ onPidChanged?: () => void; | ||
} | ||
) { | ||
let initialTime: number | null = null; | ||
@@ -187,6 +189,7 @@ export abstract class UnixProfiler implements Profiler { | ||
}, | ||
() => { | ||
Logger.warn("Process id has changed, ignoring measures until now"); | ||
+ onPidChanged(); | ||
reset(); | ||
} | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
diff --git a/node_modules/@perf-profiler/types/dist/index.d.ts b/node_modules/@perf-profiler/types/dist/index.d.ts | ||
index 0d0f55f..ef7f864 100644 | ||
--- a/node_modules/@perf-profiler/types/dist/index.d.ts | ||
+++ b/node_modules/@perf-profiler/types/dist/index.d.ts | ||
@@ -80,6 +80,7 @@ export interface ScreenRecorder { | ||
export interface ProfilerPollingOptions { | ||
onMeasure: (measure: Measure) => void; | ||
onStartMeasuring?: () => void; | ||
+ onPidChanged?: () => void; | ||
} | ||
export interface Profiler { | ||
pollPerformanceMeasures: (bundleId: string, options: ProfilerPollingOptions) => { |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a upstream PR for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hannojg not yet. I'd like to test how stable this fix will be in Expensify codebase and if it's pretty stable, then I'll create upstream PR