Increase emoji size within text messages on web #46398

VickyStash · 2024-07-29T08:42:03Z

Details

This PR is a follow-up of #40692. It increases emojis size within the text messages on the web platform.
It should fix this issue.

Fixed Issues

$ #4114
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Send a message with emojis and text
Verify that emojis are larger (19px) compared to the default size of the text (15pt) in the chat history and vertically centered.

Offline tests

Same as in the Tests section.

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: mWeb Chrome

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-29T08:58:12Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2024-07-29T09:18:30Z

src/pages/home/report/comment/TextCommentFragment.tsx

@@ -57,7 +59,14 @@ function TextCommentFragment({fragment, styleAsDeleted, styleAsMuted = false, so
        const editedTag = fragment?.isEdited ? `<edited ${styleAsDeleted ? 'deleted' : ''} ${doesTextContainOnlyEmojis ? 'islarge' : ''}></edited>` : '';
        const htmlWithDeletedTag = styleAsDeleted ? `<del>${html}</del>` : html;

-        const htmlContent = doesTextContainOnlyEmojis ? Str.replaceAll(htmlWithDeletedTag, '<emoji>', '<emoji islarge>') : htmlWithDeletedTag;
+        let htmlContent = doesTextContainOnlyEmojis ? Str.replaceAll(htmlWithDeletedTag, '<emoji>', '<emoji islarge>') : htmlWithDeletedTag;


This String.replaceAll is duplicate.

dubielzyk-expensify · 2024-07-29T09:32:00Z

Sorry as I'm definitely missing something, but I have no idea what this is fixing 😂 Your test case doesn't look to be the same as your screenshots!? Again, sorry if I'm being stupid here haha.

VickyStash · 2024-07-29T09:37:10Z

@dubielzyk-expensify This PR increases emojis font size in the messages where text and emojis are mixed on the web platforms. Does it look more clear to you?

Before	After

dubielzyk-expensify · 2024-07-29T09:44:53Z

I see. Thanks for that clarification 😄 Looks good to me, but I'll let @shawnborton chime in incase he's seeing something I'm not.

shawnborton · 2024-07-29T10:20:03Z

Hmm at first glance it feels like the emojis are making the line height of the paragraph too large:

What line height is being used here? I think we only want a line height of 20px.

VickyStash · 2024-07-29T10:36:52Z

@shawnborton I've reused the existing styles.emojisWithinText style, which has lineHeight: 24. I can make it use the same line height as the text (20px), that's how it will look:

20px	24px

shawnborton · 2024-07-29T10:39:29Z

Yeah, I think we want all of our normal paragraph text to have a line height of 20px. This way the paragraphs all look like they have the same line height matter if there are emojis or not. Thanks!

github-actions · 2024-07-29T12:47:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/46398/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/46398/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/46398/NewExpensify.dmg	https://46398.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-07-29T13:13:38Z

Hmm seeing some strange behavior while testing.

when I paste an emoji into a line, you can see how much it changes the line height
when I have an emoji towards the end of my blurb, it somehow triggers the expand icon? which causes a big jump in the size of the composer. Even if the blurb is smaller, adding the emoji still triggers this

Is there any way to make adding an emoji here feel as smooth as adding any character?

VickyStash · 2024-07-29T13:15:44Z

@shawnborton Could you please provide a video as well so I'm sure we are on the same line

shawnborton · 2024-07-29T13:52:40Z

Ah apologies I totally forgot to attach this:

CleanShot.2024-07-29.at.15.11.24.mp4

VickyStash · 2024-07-29T16:31:05Z

@shawnborton I've updated it a little. Could you give it another try?

shawnborton · 2024-07-29T16:34:57Z

Will run a test build again

github-actions · 2024-07-29T17:10:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/46398/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/46398/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/46398/NewExpensify.dmg	https://46398.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-07-29T17:13:39Z

Definitely better, but it still jumps a little bit:

CleanShot.2024-07-29.at.19.12.51.mp4

Any ideas how to solve that?

VickyStash · 2024-07-30T15:32:51Z

Closing, since #40692 got reverted. The updates from this PR will be implemented in the new PR for #4114 issue

Increase emoji size within text messages on web

d0aae8b

VickyStash changed the title ~~[WIP] Increase emoji size within text messages on web~~ Increase emoji size within text messages on web Jul 29, 2024

VickyStash marked this pull request as ready for review July 29, 2024 08:58

VickyStash requested review from a team as code owners July 29, 2024 08:58

melvin-bot bot requested review from parasharrajat and removed request for a team July 29, 2024 08:58

VickyStash mentioned this pull request Jul 29, 2024

Emojis larger in other contexts than just single character messages #40692

Merged

53 tasks

parasharrajat suggested changes Jul 29, 2024

View reviewed changes

Minor improvement

5af5830

shawnborton added the Ready To Build label Jul 29, 2024

This comment has been minimized.

Sign in to view

Use default line height

1e27458

Improve emojis display

bd428bd

VickyStash closed this Jul 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increase emoji size within text messages on web #46398

Increase emoji size within text messages on web #46398

VickyStash commented Jul 29, 2024 •

edited

Loading

melvin-bot bot commented Jul 29, 2024

parasharrajat Jul 29, 2024

VickyStash Jul 29, 2024

dubielzyk-expensify commented Jul 29, 2024

VickyStash commented Jul 29, 2024

dubielzyk-expensify commented Jul 29, 2024

shawnborton commented Jul 29, 2024

VickyStash commented Jul 29, 2024

shawnborton commented Jul 29, 2024

This comment has been minimized.

github-actions bot commented Jul 29, 2024

shawnborton commented Jul 29, 2024

VickyStash commented Jul 29, 2024

shawnborton commented Jul 29, 2024

VickyStash commented Jul 29, 2024

shawnborton commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

shawnborton commented Jul 29, 2024

VickyStash commented Jul 30, 2024

Increase emoji size within text messages on web #46398

Increase emoji size within text messages on web #46398

Conversation

VickyStash commented Jul 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 29, 2024

parasharrajat Jul 29, 2024

Choose a reason for hiding this comment

VickyStash Jul 29, 2024

Choose a reason for hiding this comment

dubielzyk-expensify commented Jul 29, 2024

VickyStash commented Jul 29, 2024

dubielzyk-expensify commented Jul 29, 2024

shawnborton commented Jul 29, 2024

VickyStash commented Jul 29, 2024

shawnborton commented Jul 29, 2024

This comment has been minimized.

github-actions bot commented Jul 29, 2024

shawnborton commented Jul 29, 2024

VickyStash commented Jul 29, 2024

shawnborton commented Jul 29, 2024

VickyStash commented Jul 29, 2024

shawnborton commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

shawnborton commented Jul 29, 2024

VickyStash commented Jul 30, 2024

VickyStash commented Jul 29, 2024 •

edited

Loading