Use medium button by default #47238

luacmartins · 2024-08-12T14:56:24Z

Details

Makes medium the default button size

Fixed Issues

$ #47454

Tests

Inspect buttons throughout the App
Verify they are the correct size

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-08-14T20:22:16Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mkhutornyi · 2024-08-19T19:17:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

mkhutornyi

This PR makes all buttons medium. Is that discussed?

i.e. these buttons are not medium:

App/src/components/AttachmentModal.tsx

Lines 561 to 571 in 7b4605a

    
           <Button 
        
               ref={viewRef(submitRef)} 
        
               success 
        
               large 
        
               style={[styles.buttonConfirm, shouldUseNarrowLayout ? {} : styles.attachmentButtonBigScreen]} 
        
               textStyles={[styles.buttonConfirmText]} 
        
               text={translate('common.send')} 
        
               onPress={submitAndClose} 
        
               isDisabled={isConfirmButtonDisabled} 
        
               pressOnEnter 
        
           />

App/src/components/ConfirmationPage.tsx

Lines 81 to 88 in 7b4605a

    
           <Button 
        
               success 
        
               large 
        
               text={buttonText} 
        
               style={styles.mt6} 
        
               pressOnEnter 
        
               onPress={onButtonPress} 
        
           />

Before:

After:

luacmartins · 2024-08-20T13:46:06Z

Adding @Expensify/design for review

shawnborton · 2024-08-20T13:55:25Z

I don't think we want to make all buttons medium. The goal though is that if someone doesn't pass in a size prop, we should make the default button use the medium size.

luacmartins · 2024-08-20T14:13:29Z

Yea, that's where the rabbit hole part of this PR comes in. By passing the default, we will change any buttons that don't specify a size and were large before. I can update the instances @mkhutornyi found above, but we might have others. We'd have to test all buttons to make sure none get a different size though

shawnborton · 2024-08-20T14:19:12Z

Ah but if those buttons didn't have a size passed in, how were they actually large buttons?

luacmartins · 2024-08-20T14:24:13Z

They do have a large size passed in, which is weird that they changed after we applied the default. I'll have to take a look at the rest of the logic.

luacmartins · 2024-09-06T18:10:03Z

Finally had a chance to get back to this. I updated the logic and I believe this should be working properly now.

luacmartins · 2024-09-06T18:13:18Z

@mkhutornyi this is ready for review again

mkhutornyi · 2024-09-10T21:34:14Z

Keep testing all affected pages which have button.
Meanwhile please fix conflict.

luacmartins · 2024-09-10T21:38:48Z

Updated!

mkhutornyi · 2024-09-12T19:17:36Z

completing review today

luacmartins · 2024-09-12T19:17:37Z

Resolved conflicts. @mkhutornyi how's review going? I'd like to get this one merged soon before more conflicts show up

mkhutornyi · 2024-09-12T20:55:22Z

1 occurrence found:
https://github.com/Expensify/App/pull/48862/files#diff-25293ed1eb98a18bb5d04421e453a9833db097e4e5aaf045e57e00062446b6b4R319

Otherwise looks good.

luacmartins · 2024-09-12T21:18:33Z

@mkhutornyi removed!

melvin-bot · 2024-09-12T21:30:39Z

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-09-12T22:23:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-13T23:05:24Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-16T18:21:21Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.35-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

use medium by default

839c365

luacmartins self-assigned this Aug 12, 2024

rm medium prop

a9ce64a

luacmartins marked this pull request as ready for review August 14, 2024 20:22

luacmartins requested a review from a team as a code owner August 14, 2024 20:22

melvin-bot bot requested review from mkhutornyi and removed request for a team August 14, 2024 20:22

mkhutornyi reviewed Aug 19, 2024

View reviewed changes

luacmartins requested a review from a team August 20, 2024 13:45

Merge branch 'main' into cmartins-useMediumBydefault

ba2ac6e

mkhutornyi mentioned this pull request Aug 29, 2024

[HOLD for payment 2024-09-23] Make medium the default button size #47454

Closed

luacmartins added 2 commits September 6, 2024 12:04

resolve conflicts, update logic

00ec2e8

update logic, rm more unnecessary props

a7f1087

luacmartins requested a review from mkhutornyi September 6, 2024 18:10

revert bad conflict resolution

359ddc9

resolve conflicts

60124fc

resolve conflicts

ea9c052

rm instance

14f952a

mkhutornyi approved these changes Sep 12, 2024

View reviewed changes

melvin-bot bot requested a review from nkuoch September 12, 2024 21:30

francoisl approved these changes Sep 12, 2024

View reviewed changes

francoisl merged commit b454d0d into main Sep 12, 2024
16 checks passed

francoisl deleted the cmartins-useMediumBydefault branch September 12, 2024 22:11

github-actions bot mentioned this pull request Sep 13, 2024

Deploy Checklist: New Expensify 2024-09-13 #49195

Closed

55 tasks

CyberAndrii mentioned this pull request Sep 14, 2024

Bank account - "Continue setup" text is smaller than "Start over" #49211

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use medium button by default #47238

Use medium button by default #47238

luacmartins commented Aug 12, 2024 •

edited

Loading

melvin-bot bot commented Aug 14, 2024

mkhutornyi commented Aug 19, 2024 •

edited

Loading

mkhutornyi left a comment

luacmartins commented Aug 20, 2024

shawnborton commented Aug 20, 2024

luacmartins commented Aug 20, 2024

shawnborton commented Aug 20, 2024

luacmartins commented Aug 20, 2024 •

edited

Loading

luacmartins commented Sep 6, 2024

luacmartins commented Sep 6, 2024

mkhutornyi commented Sep 10, 2024

luacmartins commented Sep 10, 2024

mkhutornyi commented Sep 12, 2024

luacmartins commented Sep 12, 2024

mkhutornyi commented Sep 12, 2024

luacmartins commented Sep 12, 2024

melvin-bot bot commented Sep 12, 2024

OSBotify commented Sep 12, 2024

OSBotify commented Sep 13, 2024

OSBotify commented Sep 16, 2024

	<Button
	ref={viewRef(submitRef)}
	success
	large
	style={[styles.buttonConfirm, shouldUseNarrowLayout ? {} : styles.attachmentButtonBigScreen]}
	textStyles={[styles.buttonConfirmText]}
	text={translate('common.send')}
	onPress={submitAndClose}
	isDisabled={isConfirmButtonDisabled}
	pressOnEnter
	/>

Use medium button by default #47238

Use medium button by default #47238

Conversation

luacmartins commented Aug 12, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 14, 2024

mkhutornyi commented Aug 19, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mkhutornyi left a comment

Choose a reason for hiding this comment

luacmartins commented Aug 20, 2024

shawnborton commented Aug 20, 2024

luacmartins commented Aug 20, 2024

shawnborton commented Aug 20, 2024

luacmartins commented Aug 20, 2024 • edited Loading

luacmartins commented Sep 6, 2024

luacmartins commented Sep 6, 2024

mkhutornyi commented Sep 10, 2024

luacmartins commented Sep 10, 2024

mkhutornyi commented Sep 12, 2024

luacmartins commented Sep 12, 2024

mkhutornyi commented Sep 12, 2024

luacmartins commented Sep 12, 2024

melvin-bot bot commented Sep 12, 2024

OSBotify commented Sep 12, 2024

OSBotify commented Sep 13, 2024

OSBotify commented Sep 16, 2024

luacmartins commented Aug 12, 2024 •

edited

Loading

mkhutornyi commented Aug 19, 2024 •

edited

Loading

luacmartins commented Aug 20, 2024 •

edited

Loading