Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UpdatePolicyConnectionConfiguration to be 1:1:1 Part-3 #47628

Conversation

ZhenjaHorbach
Copy link
Contributor

@ZhenjaHorbach ZhenjaHorbach commented Aug 19, 2024

Details

Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 3

Fixed Issues

$ #47521
PROPOSAL: NA

Tests

  1. Open App
  2. Open Account settings and then Workspaces
  3. Choose any Workspace that has Quickbooks Online connection
  4. Open Accounting
  5. Open Import in Quickbooks Online
  6. Choose classes
  7. Verify that Import can be turned on and off and the request is sent correctly without errors
  8. Press go back
  9. Choose Customers/projects
  10. Verify that Import can be turned on and off and the request is sent correctly without errors
  11. Press go back
  12. Choose Locations
  13. Verify that Import can be turned on and off and the request is sent correctly without errors
  14. Press go back
  15. Choose Taxes
  16. Verify that Import can be turned on and off and the request is sent correctly without errors
  17. Return to Accounting screen
  18. Open Export in Quickbooks Online
  19. Open Export company card expenses as and choose Vendor bill in Export as
  20. Open Default vendor
  21. Verify that vendor can be selected and the request is sent correctly without errors
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
2024-08-27.10.52.53.mov
Android: mWeb Chrome
2024-08-27.10.56.55.mov
iOS: Native
2024-08-27.10.43.22.mov
iOS: mWeb Safari
2024-08-27.10.49.30.mov
MacOS: Chrome / Safari
web-vendors.mov
web-taxes.mov
web-locations.mov
web-customers.mov
web-classes.mov
web-reimbursableExpensesAccount.mov
web-enableNewCategories.mov
web-autoCreateVendor.mov
MacOS: Desktop
desktop.mov

@ZhenjaHorbach ZhenjaHorbach marked this pull request as ready for review August 27, 2024 09:11
@ZhenjaHorbach ZhenjaHorbach requested a review from a team as a code owner August 27, 2024 09:11
@melvin-bot melvin-bot bot requested a review from ishpaul777 August 27, 2024 09:11
Copy link

melvin-bot bot commented Aug 27, 2024

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team August 27, 2024 09:11
@ZhenjaHorbach
Copy link
Contributor Author

@ishpaul777
PR is ready !

@ishpaul777
Copy link
Contributor

ishpaul777 commented Aug 27, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Screen.Recording.2024-08-27.at.10.17.19.PM.mov
Android: mWeb Chrome
Screen.Recording.2024-08-27.at.10.09.07.PM.mov
iOS: Native
Screen.Recording.2024-08-27.at.9.30.04.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-08-27.at.9.26.33.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-27.at.9.18.05.PM-1.mov
MacOS: Desktop
Screen.Recording.2024-08-27.at.10.45.10.PM-1.mov
Screen.Recording.2024-08-30.at.5.47.37.PM.mov

@ishpaul777
Copy link
Contributor

@ZhenjaHorbach Do you have a free trial test account for QBO which you are comfortable sharing in DM? apparently QBO is discontinued in India

@ZhenjaHorbach
Copy link
Contributor Author

@ZhenjaHorbach Do you have a free trial test account for QBO which you are comfortable sharing in DM? apparently QBO is discontinued in India

I don't mind !
I will write you in slack

Copy link
Contributor

@ishpaul777 ishpaul777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot melvin-bot bot requested a review from dangrous August 27, 2024 17:35
Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Love the simplification of it. Do you want to go ahead and update the other ones to that format too? EnableNewCategories, AutoCreateVendor, ReimbursableExpensesAccount?

Also @aldo-expensify was AutoCreateVendor the one we needed to update into the new format with two params? I forget.

@ZhenjaHorbach
Copy link
Contributor Author

No problem !
I will update today or tomorrow

@aldo-expensify
Copy link
Contributor

Also @aldo-expensify was AutoCreateVendor the one we needed to update into the new format with two params? I forget.

Yep, UpdateQuickbooksOnlineAutoCreateVendor needs the following params:

autoCreateVendor: boolean
nonReimbursableBillDefaultVendor: string

I think it should work like what we have here:

Connections.updateManyPolicyConnectionConfigs(
policyID,
CONST.POLICY.CONNECTIONS.NAME.QBO,
{
[CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: isOn,
[CONST.QUICK_BOOKS_CONFIG.NON_REIMBURSABLE_BILL_DEFAULT_VENDOR]: isOn
? policy?.connections?.quickbooksOnline?.data?.vendors?.[0]?.id ?? CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE
: CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE,
},
{
[CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: autoCreateVendor,
[CONST.QUICK_BOOKS_CONFIG.NON_REIMBURSABLE_BILL_DEFAULT_VENDOR]:
nonReimbursableBillDefaultVendorObject?.id ?? CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE,
},
)

@dangrous
Copy link
Contributor

oh yeah so let's update that ^^ call to updateManyPolicyConnectionConfigs as well!

Sorry to throw extra work on you @ZhenjaHorbach

@ZhenjaHorbach
Copy link
Contributor Author

Done !

@dangrous
Copy link
Contributor

Oops sorry I phrased that poorly. I meant - can we change the previous call to updateManyPolicyConnectionConfigs to call instead UpdateQuickbooksOnlineAutoCreateVendor with both parameters (autoCreateVendor and nonReimbursableBillDefaultVendor). It will accept it on the backend.

And @aldo-expensify I believe you were saying that we needed to update where we call autoCreateVendor with only true/false to also send a nonReimbursableBillDefaultVendor? That it was an existing bug? If so (or if not) can you clarify how we should go about that one?

@dangrous
Copy link
Contributor

oh so @ZhenjaHorbach I think you basically did the right thing, but instead of UpdateMany... we're using AutoCreateVendor but with two parameters.

@ZhenjaHorbach
Copy link
Contributor Author

ZhenjaHorbach commented Aug 28, 2024

oh so @ZhenjaHorbach I think you basically did the right thing, but instead of UpdateMany... we're using AutoCreateVendor but with two parameters.

Actually At first I did just that using onyxData like for updateManyPolicyConnectionConfigs

And then passed onyxData with this parameters

    const parameters = {
        policyID,
        configUpdate: JSON.stringify(configUpdate),
        idempotencyKey: Object.keys(configUpdate).join(','),
    };

For this command

API.write(WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_AUTO_CREATE_VENDOR, parameters, {optimisticData, failureData, successData});

But unfortunately UPDATE_QUICKBOOKS_ONLINE_AUTO_CREATE_VENDOR does not support configUpdate where we pass object with new values

As result I have 400 error

@dangrous
Copy link
Contributor

oh got it yeah we have it as separate params - so instead of configUpdate do individually autoCreateVendor and nonReimbursableBillDefaultVendor

@ZhenjaHorbach
Copy link
Contributor Author

Done !

Only have issue with react-compiler

Failed to compile src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx:113:25. Reason: (BuildHIR::lowerExpression) Expected Identifier, got MemberExpression key in ObjectExpression

Because we use a constant as a key

https://github.com/Expensify/App/pull/47628/files#diff-0026d01286916fb45777d8b20324c8bf3b6c31e95f10a79939d2c19a01365e21R113-R118

But I'm not sure what we should fix since this is normal practice

Or at least I can do it this way
But it looks weird 😅

25a21b0

Copy link
Contributor

@ishpaul777 ishpaul777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot melvin-bot bot requested a review from dangrous August 30, 2024 12:23
@aldo-expensify
Copy link
Contributor

you have some "React Compiler" error:


Error: Some files could be compiled with react-compiler before successfully, but now they can not be compiled. Check https://github.com/Expensify/App/blob/main/contributingGuides/REACT_COMPILER.md documentation to see how you can fix this.

There are some instructions on how to run it locally and find the cause of the problem: https://github.com/Expensify/App/blob/main/contributingGuides/REACT_COMPILER.md

@ishpaul777
Copy link
Contributor

I thought we are ignoring this #47628 (comment) but yeah if we can fix that would be great

@aldo-expensify
Copy link
Contributor

I thought we are ignoring this #47628 (comment) but yeah if we can fix that would be great

ahh I wasn't aware 👍

dangrous
dangrous previously approved these changes Aug 30, 2024
Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good! One potential rename but otherwise works for me. @aldo-expensify do you want to give this one a review as well?

@@ -21,7 +22,11 @@ function getQuickbooksOnlineSetupLink(policyID: string) {
return commandURL + new URLSearchParams(params).toString();
}

function updateQuickbooksOnlineEnableNewCategories(policyID: string, settingValue: boolean) {
function updateManyQuickbooksOnyxData<TConfigUpdate extends Partial<Connections['quickbooksOnline']['config']>>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function updateManyQuickbooksOnyxData<TConfigUpdate extends Partial<Connections['quickbooksOnline']['config']>>(
function buildOnyxDataForMultipleQuickbooksConfigurations<TConfigUpdate extends Partial<Connections['quickbooksOnline']['config']>>(

NAB! This is also not a good name but is a little clearer?

Copy link
Contributor Author

@ZhenjaHorbach ZhenjaHorbach Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it !

In this case I think we need to rename this to buildOnyxDataForQuickbooksConfiguration or something like this

@aldo-expensify
Copy link
Contributor

@aldo-expensify do you want to give this one a review as well?

Sure, I'll review asap

aldo-expensify
aldo-expensify previously approved these changes Aug 30, 2024
Copy link
Contributor

@aldo-expensify aldo-expensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@@ -21,7 +22,11 @@ function getQuickbooksOnlineSetupLink(policyID: string) {
return commandURL + new URLSearchParams(params).toString();
}

function updateQuickbooksOnlineEnableNewCategories(policyID: string, settingValue: boolean) {
function buildOnyxDataForMultipleQuickbooksConfigurations<TConfigUpdate extends Partial<Connections['quickbooksOnline']['config']>>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I see you were able to avoid a lot of code repetition by creating this helper method

@ishpaul777
Copy link
Contributor

Anything left to do here ?

dangrous
dangrous previously approved these changes Sep 3, 2024
Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @aldo-expensify do you know what we can do about ignoring that compiler check? Just merge anyway and call it out in a comment?

@ZhenjaHorbach
Copy link
Contributor Author

LGTM! @aldo-expensify do you know what we can do about ignoring that compiler check? Just merge anyway and call it out in a comment?

Since we have a lot of similar issues on the project

Снимок экрана 2024-09-03 в 16 46 17

And following this comment
I think we can just merge !

@aldo-expensify
Copy link
Contributor

Just merge anyway and call it out in a comment?

Yes, that is my understanding. I think an "Emergency" label will be added and we have to remove it and comment why.

@dangrous dangrous merged commit f270b04 into Expensify:main Sep 3, 2024
17 of 18 checks passed
@melvin-bot melvin-bot bot added the Emergency label Sep 3, 2024
Copy link

melvin-bot bot commented Sep 3, 2024

@dangrous looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@dangrous dangrous removed the Emergency label Sep 3, 2024
@dangrous
Copy link
Contributor

dangrous commented Sep 3, 2024

Removing label - react-compiler check is known and is not a blocker - see #47628 (comment)

@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2024

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.29-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@@ -127,12 +123,12 @@ function updateQuickbooksOnlineAutoCreateVendor(policyID: string, settingValue:
connections: {
[CONST.POLICY.CONNECTIONS.NAME.QBO]: {
config: {
[CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR]: settingValue ?? null,
[settingName]: settingValue ?? null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZhenjaHorbach Can you tell me why we should not revert to old value on failure?

Copy link
Contributor Author

@ZhenjaHorbach ZhenjaHorbach Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I used code which we already had for QBO
But this proposal make sense to me to use old value on failure
I can create a little PR to update it !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But just realized
We are updating errorFields but we don't use these values anywhere in case of failure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dangrous @aldo-expensify
What do you think
Should we just use the previous values ​​in case of failure?
Or should we also add error texts ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldo-expensify you're working on QBO errors right? I'd defer to you for this one. My naive opinion is show the error text and revert to the previous value (so, both?).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 @zfurtak is working on the QBO offline and errors refactor here so let's wait for her opinion 🙏

Copy link
Contributor

@zfurtak zfurtak Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys 😊 The new strategy for errors that we were introducing is that after an error appears the value is reverting to the previous one.
If you want to, take a look into my PR where I adjusted already changed functions to this pattern. I hope it will be merged soon 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh okay great! @ZhenjaHorbach can you take a look at that and update your update PR accordingly? Thank you!

Copy link
Contributor Author

@ZhenjaHorbach ZhenjaHorbach Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @zfurtak's PR cover all cases
So we just have to wait a little bit when PR will be merged !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋 FYI my PR was merged 😃

@OSBotify
Copy link
Contributor

OSBotify commented Sep 5, 2024

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.29-12 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants