Require a 2FA code to disable 2FA #48030
Conversation
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/languages/es.ts
Outdated
| @@ -1119,7 +1119,7 @@ export default { | |||
| whatIsTwoFactorAuth: | |||
| 'La autenticación de dos factores (2FA) ayuda a mantener tu cuenta segura. Al iniciar sesión, deberás ingresar un código generado por tu aplicación de autenticación preferida.', | |||
| disableTwoFactorAuth: 'Deshabilitar la autenticación de dos factores', | |||
| disableTwoFactorAuthConfirmation: 'La autenticación de dos factores mantiene tu cuenta más segura. ¿Estás seguro de que quieres desactivarla?', | |||
| explainProcessToRemove: 'In order to disable Two-factor authentication, please enter a valid code from your authentication app.', | |||
There was a problem hiding this comment.
I'm still holding for the official translation for this
|
Do you want me to review it now? |
|
Yep, you can go ahead and review it, please! |
The typescript error must be coming from |
|
|
||
| type CodesStepProps = BaseTwoFactorAuthFormOnyxProps & BackToParams; | ||
|
|
||
| function CodesStep({account}: CodesStepProps) { |
There was a problem hiding this comment.
Shouldn't the component name match the file name?
| > | ||
| <ScrollView contentContainerStyle={styles.flexGrow1}> | ||
| <View style={[styles.ph5, styles.mt3]}> | ||
| <Text style={styles.textLabel}>{translate('twoFactorAuth.explainProcessToRemove')}</Text> |
There was a problem hiding this comment.
This should be normal text. Check other pages like the Close account page.
There was a problem hiding this comment.
I'll check that out, thanks.
| validateInsteadOfDisable={false} | ||
| /> | ||
| </View> | ||
| <Button |
There was a problem hiding this comment.
Technically, it should have bottom margin. I think we can leave this as it is as all of the page for 2FA flow does not have this.
There was a problem hiding this comment.
Hm, OK. We should maybe make a followup GH issue to have someone fix that.
Screenshots🔲 iOS / native30.08.2024_17.58.04_REC.mp4🔲 iOS / Safari30.08.2024_18.34.44_REC.mp4🔲 MacOS / Desktop30.08.2024_18.30.42_REC.mp4🔲 MacOS / Chrome30.08.2024_17.59.55_REC.mp4🔲 Android / Chrome30.08.2024_18.36.22_REC.mp4🔲 Android / native30.08.2024_18.02.53_REC.mp4 |
|
BUG: (Might be unrelated) After disabling the 2FA, the 2FA setup does not work sometimes. The backup codes are blank and the secret key is null during QR code scanning. Steps:
|
|
I noticed that same bug, however, I was able to reproduce it in |
|
Updated the component name and text styling. I looked at the bottom margin, and it looks the same as the close account screens and a few other RHP screens I looked at, so I think it's OK?
|
|
Yeah, same on web. But It is not same on iOS. |
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
🎯 @parasharrajat, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #48352. |
src/pages/settings/Security/TwoFactorAuth/Steps/EnabledStep.tsx
Outdated
Show resolved
Hide resolved
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.28-0 🚀
|
|
Hey all, just sharing a bug that was noticed by QA. The input form is hidden by soft keyboard. I don't think it's a blocker as users can still use the form, and we want to ship this security improvement. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.28-3 🚀
|
| return ( | ||
| <StepWrapper | ||
| title={translate('twoFactorAuth.disableTwoFactorAuth')} | ||
| shouldEnableKeyboardAvoidingView={false} |
There was a problem hiding this comment.
shouldEnableKeyboardAvoidingView caused an issue here. where code input was left behind keyboard
Details
At first, the 2FA code won't actually be validated on the server. Once this has been deployed to production, then I will update the server to start validating the 2FA tokens. If you want to test out the actual validation you will need both of these PRs checked out locally:
Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/422144
Tests
Offline tests
None, this must be done online.
QA Steps
Same as the above tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Android: Native
2024-08-28_13-07-27.mp4
Android: mWeb Chrome
iOS: Native
2024-08-26_15-42-01.mp4
iOS: mWeb Safari
2024-08-28_13-57-26.mp4
MacOS: Chrome / Safari
2024-08-26_14-40-31.mp4
MacOS: Desktop
2024-08-26_14-45-54.mp4