chore: update task preview UI #48552

dominictb · 2024-09-04T12:48:00Z

Details

Fixed Issues

$ #48409
PROPOSAL: #48409 (comment)

Tests

Sign-up on NewDot with a new account
Choose an onboarding intent (i.e "Get paid back by my employer")
Complete the onboarding steps
Navigate to the Concierge DM to view the onboarding tasks created

Verify that: all assigned task previews should

Not include a mention
Use only the avatar of the assigned user instead
Clicking on the task preview row (incl. the avatar) will navigate to the task, not the profile.
Verify that no errors appear in the JS console

Offline tests

QA Steps

Sign-up on NewDot with a new account
Choose an onboarding intent (i.e "Get paid back by my employer")
Complete the onboarding steps
Navigate to the Concierge DM to view the onboarding tasks created

Verify that: all assigned task previews should

Not include a mention
Use only the avatar of the assigned user instead
Clicking on the task preview row (incl. the avatar) will navigate to the task, not the profile.
Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-09-04T12:48:05Z

@dannymcclain @dukenv0307 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain · 2024-09-04T14:23:53Z

Screenshots are looking good so far. cc'ing @Expensify/design because this is a decently significant visual change to the product and I want them to be able to review too if they want.

dukenv0307 · 2024-09-04T15:01:10Z

Codes look good

dukenv0307 · 2024-09-04T15:01:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

dukenv0307 · 2024-09-04T15:58:41Z

LGTM

shawnborton · 2024-09-04T17:16:26Z

Small nitpick but I wonder if we should be reusing the same exact avatar size as the thread indicator? Just to try to reduce the amount of sizes we have on the screen for the same kind of thing.

dannymcclain · 2024-09-04T18:09:45Z

@shawnborton Ah snap, not a bad idea at all!!

Here's a mock comparing thread indicator (28px), your proposed task avatar size (28px), and the original task avatar size (24px).

Whatcha think? To me they are like... barely different at all. So I'd be down to use the 28px size (which is the size for the thread indicator AND focus LHN)

shawnborton · 2024-09-04T19:31:26Z

Dope, thanks for laying it out like that! I like going with 28px as well, I like that it's a size we're using in other places as well. Let's see what @dubielzyk-expensify thinks too!

dubielzyk-expensify · 2024-09-05T03:22:10Z

Great call. Dig it. Just on the completed task look. We don't want any sort of strikethrough on the avatar right? Or fade of the avatar? A part of me kinda wishes there was some visual indication that the task is done on the avatar too. But maybe it's just better to leave it for now?

Probably just do nothing, right? I could see the fade, but I'm not super passionate

trjExpensify · 2024-09-05T09:14:02Z

Yeah, I think it looks too much like offline pending delete tbh.

shawnborton · 2024-09-05T11:45:53Z

Yeah, I think the Nothin' version feels the most correct to me

shawnborton · 2024-09-05T11:46:24Z

I don't mind the Fade version though... happy to go with whatever you all think is best!

dominictb · 2024-09-05T12:09:26Z

Updated with 28px avatar size.

dannymcclain · 2024-09-05T13:13:20Z

Man I actually really like the Fade version for completed task, but I also am 100% down with Nothin' if we don't want to be messing about with it.

Seems like all the designers like that version but don't feel super duper passionate. How shall we decide?

shawnborton · 2024-09-05T15:43:41Z

If we're all really feeling the fade version, then I think it's totally okay if we do it personally.

shawnborton · 2024-09-05T15:44:16Z

I can see where it looks a bit like pending delete but pending delete should look even more faded out, right?

dannymcclain · 2024-09-05T15:45:44Z

If we're all really feeling the fade version, then I think it's totally okay if we do it personally.

#send-it

I can see where it looks a bit like pending delete but pending delete should look even more faded out, right?

Yeah I think the whole entire row/message would be faded. I think it would probably be fine.

blimpich · 2024-09-05T17:07:38Z

Sounds like @Expensify/design wants the fade?

@dominictb could you update your PR to make this a reality?

trjExpensify · 2024-09-05T18:18:33Z

Not gunna' fight it. Fifty Shades of Fade™️

dukenv0307 · 2024-09-06T02:36:52Z

@shawnborton @dannymcclain What should the opacity be?

dubielzyk-expensify · 2024-09-06T02:44:46Z

Let's do 0.5 or 50% :)

dominictb · 2024-09-06T05:09:58Z

Just to confirm this is the expected look right?

shawnborton · 2024-09-06T08:56:42Z

This portion here:

It should just use our textSupporting color and it shouldn't have reduced opacity. I think only the avatar would have reduced opacity. Is that what you were thinking Danny?

trjExpensify · 2024-09-06T13:23:49Z

It should just use our textSupporting color and it shouldn't have reduced opacity. I think only the avatar would have reduced opacity. Is that what you were thinking Danny?

I hope so otherwise it does look exactly like pending delete... 🙈🏃‍♂️

trjExpensify · 2024-09-06T13:26:46Z

Also, I think in Jon's mock above the checkbox doesn't get reduced opacity either:

dannymcclain · 2024-09-06T13:27:35Z

Haha yes Shawn and Tom are absolutely right. Only the avatar should get reduced opacity when it's done. It looks like in your screenshot the whole row is getting reduced opacity which is not what we want here (as that is the pending offline pattern as Tom pointed out).

So checkmark and text should be full opacity, just the avatar should be reduced to 50% opacity.

dominictb · 2024-09-08T16:01:11Z

Just to confirm here:

The checkbox and the text won't be faded off
The avatar will be faded off
The text will be strikethrough

right @dannymcclain @shawnborton @trjExpensify ?

shawnborton · 2024-09-08T16:02:37Z

Sounds correct to me.

…

On Sun, Sep 8, 2024 at 6:01 PM Dominic ***@***.***> wrote: Just to confirm here: - The checkbox and the text won't be faded off - The avatar will be faded off - The text will be strikethrough right @dannymcclain <https://github.com/dannymcclain> @shawnborton <https://github.com/shawnborton> @trjExpensify <https://github.com/trjExpensify> ? — Reply to this email directly, view it on GitHub <#48552 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARWH5VFMTGOF2IZL2GQA4LZVRYF3AVCNFSM6AAAAABNUH46EWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWG4ZTMNRVHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

dubielzyk-expensify · 2024-09-09T03:32:53Z

Just to confirm here:
The checkbox and the text won't be faded off
The avatar will be faded off
The text will be strikethrough

Exactly!

dominictb · 2024-09-09T08:51:54Z

New screenshot

cc @dukenv0307

shawnborton · 2024-09-09T08:55:51Z

That looks better!

dubielzyk-expensify · 2024-09-09T09:14:12Z

Looks great 🥲

trjExpensify · 2024-09-09T09:16:13Z

Great stuff, let's get this thing merged!

dannymcclain · 2024-09-09T13:33:09Z

Looking good!

@Expensify/design seeing these tasks with the bigger avatar... I'm starting to wonder if we should just use our default size checkbox (20px) instead of the smaller one we're currently using (16px).

Here are some side-by-sides (Current 16px on the left, 20px on the right):

Note

If we want to make a change like this, I would propose it being a follow-up and not getting in the way of merging this avatar change.

EDIT: I updated the mocks because I realized there was a goof in them—I didn't have all the avatars correctly shown for completed tasks.

shawnborton · 2024-09-09T13:34:14Z

Super down to standardize on the... standard size of 20px here!

OSBotify · 2024-09-09T16:54:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

rayane-djouah · 2024-10-07T22:44:07Z

src/components/ReportActionItem/TaskPreview.tsx

+                    <View style={[styles.alignSelfCenter]}>
+                        <RenderHTML html={isTaskCompleted ? `<completed-task>${htmlForTaskPreview}</completed-task>` : htmlForTaskPreview} />
+                    </View>


FYI, This caused this issue: #49086. More info in this proposal: #49086 (comment)

This also causes the issue #50267

chore: update task preview UI

e6ad88f

dominictb requested a review from a team as a code owner September 4, 2024 12:48

melvin-bot bot requested review from dannymcclain and dukenv0307 September 4, 2024 12:48

melvin-bot bot removed the request for review from a team September 4, 2024 12:48

dukenv0307 approved these changes Sep 4, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich September 4, 2024 15:58

feat: use 28px avatar size for task preview

1eaeb44

blimpich previously approved these changes Sep 5, 2024

View reviewed changes

fix: dim the avatar in completed task preview

fa88697

dominictb dismissed blimpich’s stale review via fa88697 September 9, 2024 08:51

blimpich approved these changes Sep 9, 2024

View reviewed changes

blimpich merged commit 1bc85f2 into Expensify:main Sep 9, 2024
16 checks passed

blimpich mentioned this pull request Sep 9, 2024

[$100] Increase size of checkbox to default size of 20px #48839

Closed

rushatgabhane mentioned this pull request Sep 9, 2024

[$250] Task – Assignee avatar is greyed out in main chat when complete a task #48834

Closed

6 tasks

thienlnam mentioned this pull request Sep 12, 2024

[HOLD for payment 2024-10-16] [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] [$250] Task - Long Task title is overlapped by task arrow #49086

Closed

6 tasks

dominictb mentioned this pull request Sep 18, 2024

[$250] [CVP] Replace the mention in the task preview with the assigned user's avatar #48409

Closed

6 tasks

rayane-djouah reviewed Oct 7, 2024

View reviewed changes

dukenv0307 mentioned this pull request Oct 24, 2024

[HOLD for payment 2024-10-24] [$250] Web -Tooltip -Tooltip is not displayed when hovering over the avatar in the main conversation #50267

Closed

6 tasks

chore: update task preview UI #48552

chore: update task preview UI #48552

Conversation

dominictb commented Sep 4, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 4, 2024

dannymcclain commented Sep 4, 2024

dukenv0307 commented Sep 4, 2024

dukenv0307 commented Sep 4, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

dukenv0307 commented Sep 4, 2024

shawnborton commented Sep 4, 2024

dannymcclain commented Sep 4, 2024 • edited Loading

shawnborton commented Sep 4, 2024

dubielzyk-expensify commented Sep 5, 2024 • edited Loading

trjExpensify commented Sep 5, 2024

shawnborton commented Sep 5, 2024

shawnborton commented Sep 5, 2024

dominictb commented Sep 5, 2024

dannymcclain commented Sep 5, 2024

shawnborton commented Sep 5, 2024

shawnborton commented Sep 5, 2024

dannymcclain commented Sep 5, 2024

blimpich commented Sep 5, 2024

trjExpensify commented Sep 5, 2024

dukenv0307 commented Sep 6, 2024

dubielzyk-expensify commented Sep 6, 2024

dominictb commented Sep 6, 2024

shawnborton commented Sep 6, 2024

trjExpensify commented Sep 6, 2024

trjExpensify commented Sep 6, 2024

dannymcclain commented Sep 6, 2024

dominictb commented Sep 8, 2024

shawnborton commented Sep 8, 2024 via email

dubielzyk-expensify commented Sep 9, 2024

dominictb commented Sep 9, 2024

shawnborton commented Sep 9, 2024

dubielzyk-expensify commented Sep 9, 2024

trjExpensify commented Sep 9, 2024

dannymcclain commented Sep 9, 2024 • edited Loading

shawnborton commented Sep 9, 2024

OSBotify commented Sep 9, 2024

rayane-djouah Oct 7, 2024

Choose a reason for hiding this comment

dukenv0307 Oct 24, 2024

Choose a reason for hiding this comment

dukenv0307 commented Sep 4, 2024 •

edited

Loading

dannymcclain commented Sep 4, 2024 •

edited

Loading

dubielzyk-expensify commented Sep 5, 2024 •

edited

Loading

dannymcclain commented Sep 9, 2024 •

edited

Loading