Code

Search suffix tree implementation#48652

Code

Merged

marcaaron merged 101 commits intoExpensify:mainExpensify/App:mainfrom margelo:perf/search-suffix-ukkonen-treemargelo/expensify-app-fork:perf/search-suffix-ukkonen-treeCopy head branch name to clipboardOct 17, 2024

+736-14

Commits

Commits on Sep 11, 2024

• suffix tree impl

  

  hannojg

  authored and

  kirillzyusko

  committed
  5425082

• add some helpful comments

  

  hannojg

  authored and

  kirillzyusko

  committed
  54a7b60

• example implementation usage of Suffixtree

  

  hannojg

  authored and

  kirillzyusko

  committed
  8622670

• fix: resolved one TODO

  kirillzyusko

  committed
  01162fe

Commits on Sep 12, 2024

• fix: reduce code duplication

  kirillzyusko

  committed
  09e8aa7

• refactor: O(2) -> O(1)

  kirillzyusko

  committed
  fa81e13

• refactor: minus one TODO

  kirillzyusko

  committed
  e33142f

Commits on Sep 13, 2024

• fix: bring back userToInvite

  kirillzyusko

  committed
  30424a9

• fix: make Marc discoverable again (when we search in second array, then we will always get - so we add +1 bias)

  kirillzyusko

  committed
  1d11ed2

Commits on Sep 20, 2024

• Merge branch 'main' into perf/search-suffix-ukkonen-tree

  kirillzyusko

  committed
  b502edc

Commits on Sep 24, 2024

• add debug timings

  hannojg

  committed
  c0e38b8

• Merge branch 'main' of github.com:Expensify/App into perf/search-suffix-ukkonen-tree

  hannojg

  committed
  16e4078

• adjust values for search

  hannojg

  committed
  955cdcb

• correct display name for personal details search

  hannojg

  committed
  d7c8d88

• deduplicate search results

  hannojg

  committed
  d07940d

• unify string cleaning

  hannojg

  committed
  84d3231

• fix search function temporarily

  hannojg

  committed
  eb6b371

Commits on Sep 25, 2024

• make it work with numbers by base26 everything thats bigger than our alphabet

  hannojg

  committed
  6002101

• don't add delimiter char at the end

  hannojg

  committed
  131c303

• support for unicode

  hannojg

  committed
  0a89089

• extended test case to make sure right item is returned

  hannojg

  committed
  def772b

• use concat instead of for-loop

  hannojg

  committed
  0806fb0

• Revert "use concat instead of for-loop"

  Show description for c660312
  hannojg

  committed
  c660312

• add note

  hannojg

  committed
  24a59b7

• wip: make t dynamic instead of preallocating

  hannojg

  committed
  146d51b

• wip: refactor r list

  hannojg

  committed
  a2cdaf9

• wip: refactor l list

  hannojg

  committed
  f6dbecf

• wip: refactor p list

  hannojg

  committed
  bda1e34

• wip: refactor s list

  hannojg

  committed
  2508d55

• removed preallocations!

  hannojg

  committed
  c32d57f

• better naming

  hannojg

  committed
  f4812c0

• renamings

  hannojg

  committed
  de0b467

• add userToToInvite to header count back

  hannojg

  committed
  c17a95b

• remove debug logs

  hannojg

  committed
  0f94c05

• cleanup

  hannojg

  committed
  fc54faa

• add unit test for special char handling

  hannojg

  committed
  96c93e7

• wip: document suffix tree functions

  hannojg

  committed
  81dffdd

• fix recursive search function

  hannojg

  committed
  25909ba

• small cleanup

  hannojg

  committed
  b85cfd4

• clean search input string

  hannojg

  committed
  5de310c

• fixed flaky test

  hannojg

  committed
  d51a4c3

• made test more reliable

  hannojg

  committed
  9e9b574

• migrate to useOnyx

  hannojg

  committed
  4fa8390

• ignore warning, this algorithm is optimized for speed

  hannojg

  committed
  8e583cb

• add timings to new search

  hannojg

  committed
  56a1e8a

• refactor: separate suffix tree from search logic

  hannojg

  committed
  309556a

• add explanations + fix test

  hannojg

  committed
  f7528f4

• code documentation

  hannojg

  committed
  8b5b77f

• add test verifying identical words work in suffix tree

  hannojg

  committed
  a6b7939

• add failing unit tests for duplicated string issue

  hannojg

  committed
  8b41e88

• add comment

  hannojg

  committed
  4e273df

Commits on Sep 26, 2024

• fix search not returning results with same search value

  hannojg

  committed
  57af9b1

• perf: precalculate base26 map, optimize math operations, letter lookup table instead of charCodeAt, optimize push operations away

  hannojg

  committed
  8b26a1f

• experiment: use array buffers

  hannojg

  committed
  af43c93

• add correctChar optimization back

  hannojg

  committed
  615a237

• wip: optimizing search string construction

  hannojg

  committed
  2ededdd

• add unit test

  hannojg

  committed
  02f562d

Commits on Sep 27, 2024

• Optimize performance by using one ArrayBuffer for search values and sharing that between operations

  Show description for e894a7f
  hannojg

  committed
  e894a7f

• ignore eslint warning; performance optimization

  hannojg

  committed
  54dcea8

• rename test file

  hannojg

  committed
  8bb5b1e

• add note

  hannojg

  committed
  b331193

• Update src/pages/ChatFinderPage/index.tsx

  Show description for 18de46d
  

  hannojg

  and

  allgandalf

  authored
  18de46d

• wording

  hannojg

  committed
  a91ffc9

Commits on Sep 30, 2024

• Update src/libs/SuffixUkkonenTree/utils.ts

  Show description for 8277d37
  

  hannojg

  and

  roryabraham

  authored
  8277d37

• Update src/libs/FastSearch.ts

  Show description for d1d028a
  

  hannojg

  and

  roryabraham

  authored
  d1d028a

• Update src/libs/SuffixUkkonenTree/utils.ts

  Show description for e829066
  

  hannojg

  and

  roryabraham

  authored
  e829066

• Update src/libs/SuffixUkkonenTree/utils.ts

  Show description for 3b69cf4
  

  hannojg

  and

  roryabraham

  authored
  3b69cf4

• Update src/libs/SuffixUkkonenTree/index.ts

  Show description for 8951708
  

  hannojg

  and

  roryabraham

  authored
  8951708

• Update src/libs/SuffixUkkonenTree/index.ts

  Show description for 4c4f1dc
  

  hannojg

  and

  roryabraham

  authored
  4c4f1dc

Commits on Oct 1, 2024

• use Uint8Array for search numeric representation

  hannojg

  committed
  050a320

• fix utils

  hannojg

  committed
  017e9f6

• add comment

  hannojg

  committed
  4d5ad3d

• Update src/libs/SuffixUkkonenTree/index.ts

  Show description for 1dc2a5e
  

  hannojg

  and

  roryabraham

  authored
  1dc2a5e

• implementation using none negative values

  Show description for fdac05f
  

  hannojg

  and

  Szymon20000

  committed
  fdac05f

• adjust array sizes to be correct

  hannojg

  committed
  e8fdd5c

• fix: can't find by first letter

  hannojg

  committed
  418e2cd

• remove unnecessary initializations

  hannojg

  committed
  49692fd

• fix: can't find by first letter was only a problem in the unit test

  hannojg

  committed
  1f90a13

• cleanup

  hannojg

  committed
  ee553da

• explain in comments

  hannojg

  committed
  29a1934

• +1 not +2

  hannojg

  committed
  1aec94a

• order options

  hannojg

  committed
  55acdc5

• skip white spaces

  hannojg

  committed
  a1103a3

• don't return PD, concat with recentReports

  hannojg

  committed
  41207c6

Commits on Oct 3, 2024

• Update src/libs/SuffixUkkonenTree/index.ts

  Show description for 736650f
  

  hannojg

  and

  roryabraham

  authored
  736650f

• Merge branch 'main' of github.com:Expensify/App into perf/search-suffix-ukkonen-tree

  hannojg

  committed
  4d115ed

• Merge branch 'perf/search-suffix-ukkonen-tree' of github.com:margelo/expensify-app-fork into perf/search-suffix-ukkonen-tree

  hannojg

  committed
  35b2555

• disable .at() rule

  hannojg

  committed
  6f5be58

• rename parameter

  hannojg

  committed
  34d2dbd

• step A: bring changes over to SearchRouter

  Show description for 6160173
  hannojg

  committed
  6160173

• reorder

  hannojg

  committed
  fabe796

• fix dot use case

  hannojg

  committed
  3539a57

Commits on Oct 4, 2024

• Merge branch 'main' of github.com:Expensify/App into perf/search-suffix-ukkonen-tree

  hannojg

  committed
  fdf63af

• remove eslint disabling

  hannojg

  committed
  fa68c64

Commits on Oct 10, 2024

• Merge branch 'main' of github.com:margelo/expensify-app-fork into perf/search-suffix-ukkonen-tree

  hannojg

  committed
  162ad83

• Update src/libs/FastSearch.ts

  Show description for fd76f43
  

  hannojg

  and

  marcaaron

  authored
  fd76f43

• improve error messages

  hannojg

  committed
  7c44fa7

• Update src/libs/SuffixUkkonenTree/utils.ts

  Show description for 29e5288
  

  hannojg

  and

  danieldoglas

  authored
  29e5288

• fix variable name usage

  hannojg

  committed
  de7f3b5

Commits on Oct 17, 2024

• Merge branch 'main' of github.com:Expensify/App into perf/search-suffix-ukkonen-tree

  hannojg

  committed
  f757fd2

• fix duplicate imports after merge

  hannojg

  committed
  59d2562