Add import and export CSV flow for Members #48876

Guccio163 · 2024-09-10T10:34:58Z

Details

This PR adds the import and export logic to the Members sections of the workspace. This PR takes into account all raised and fixed bugs for Category section's import/export functions.

Fyi: This PR is created in parallel with PR for Tags import/export which operates on similar files - depending on which gets merged earlier there will be few minor conflicts to take care of.

Fixed Issues

$ #47869
PROPOSAL:

Tests

Import:

Go to any Workspace -> Categories
Press three dots (in header)
Press Import spreadsheet
Press Choose file
Select xls, xlsx, csv or txt file
Select columns to import
Press import
Selected column of chosen file should be imported

Export:

Navigate into workspace.
Enter Members section.
Add some members if you don'e have any.
Click the three-dot icon in top-right corner (Import Spreadsheet and Download CSV options should appear)
Select Download CSV.
"Members-[time] [date]" file should be downloaded with all members in .csv format.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mWeb-android.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mWeb-ios.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…/import-members-csv

…-fork into filip-solecki/import-members-csv

blazejkustra

Overall looks good! 👍

src/languages/es.ts

src/libs/actions/Policy/Member.ts

src/pages/workspace/members/ImportedMembersPage.tsx

Co-authored-by: Błażej Kustra <[email protected]>

…-fork into Guccio163/import-members-csv

Guccio163 · 2024-09-11T15:22:53Z

@Expensify/design PR ready to check out

melvin-bot · 2024-09-11T15:23:02Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra · 2024-09-11T16:26:33Z

@rushatgabhane in case of conflicts/change requests please ping me, I'm going to take over from Wiktor as he will be OOO in the next days 😄

blazejkustra · 2024-09-13T07:40:10Z

@rushatgabhane When do you think you'll be able to finish the review on this one?

rushatgabhane · 2024-09-15T18:38:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-15.at.22.09.34.mov

Screen.Recording.2024-09-15.at.22.12.20.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-09-15.at.22.18.13.mov

iOS: mWeb Safari

Screen.Recording.2024-09-15.at.22.16.40.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-15.at.22.08.31.mov

Screen.Recording.2024-09-15.at.22.11.03.mov

MacOS: Desktop

rushatgabhane

LGTM

melvin-bot · 2024-09-15T19:22:03Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #47869 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

blazejkustra · 2024-09-16T14:27:20Z

@madmax330 Merged the newest main for you 😄

Guccio163 · 2024-09-17T15:29:30Z

Thanks for review @rlinoz, I also merged newest main when applying changes

src/languages/en.ts

…-fork into Guccio163/import-members-csv

rlinoz

Nice work!

Guccio163 · 2024-09-18T14:44:41Z

@madmax330 just LYK I think it's ready for merge

…-fork into Guccio163/import-members-csv

Guccio163 · 2024-09-20T06:43:40Z

@madmax330 bumping, ready for merge

melvin-bot · 2024-09-20T09:41:06Z

@madmax330 looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

madmax330 · 2024-09-20T09:42:05Z

All tests were passing

OSBotify · 2024-09-20T09:51:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-24T19:29:23Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aldo-expensify · 2024-09-25T21:48:02Z

src/pages/workspace/WorkspaceMembersPage.tsx

@@ -531,7 +535,7 @@ function WorkspaceMembersPage({personalDetails, route, policy, currentUserPerson
            return null;
        }
        return (
-            <View style={styles.w100}>
+            <View style={[styles.flexRow, styles.gap2, shouldUseNarrowLayout && styles.mb3]}>


This seems to have caused this: #49749, why did we change the style here? @Guccio163

Was it because we needed to acomodate two buttons?

oh, I see, without this change in desktop the 3-vertical-dots are too far to the right:

github-actions · 2024-09-27T17:44:18Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Pujan92 · 2024-12-04T10:45:49Z

src/pages/workspace/members/ImportMembersPage.tsx

+    const policyID = route.params.policyID;
+
+    return (
+        <ImportSpreedsheet


We need to wrap it with AccessOrNotFoundWrapper to avoid issue #51129

filip-solecki and others added 7 commits August 23, 2024 15:07

Add import flow to Members page

3165104

Merge branch 'filip-solecki/import-categories-csv' into filip-solecki…

be229ed

…/import-members-csv

Fix members import

f4b6f46

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

2c54554

…-fork into filip-solecki/import-members-csv

ts fix

93e0e23

adding fixes after categories

8ca6b73

add members export

5f98deb

blazejkustra approved these changes Sep 11, 2024

View reviewed changes

Guccio163 and others added 5 commits September 11, 2024 09:43

Update src/libs/actions/Policy/Member.ts

6d0acbb

Co-authored-by: Błażej Kustra <[email protected]>

review fixes

3b656b9

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

b375206

…-fork into Guccio163/import-members-csv

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

f9860d0

…-fork into Guccio163/import-members-csv

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

16d3f65

…-fork into Guccio163/import-members-csv

Guccio163 marked this pull request as ready for review September 11, 2024 15:22

Guccio163 requested a review from a team as a code owner September 11, 2024 15:22

melvin-bot bot requested review from rushatgabhane and removed request for a team September 11, 2024 15:23

blazejkustra added 2 commits September 13, 2024 10:03

Merge branch 'main' into Guccio163/import-members-csv

77eba31

Migrate withOnyx on members page

333a89a

rushatgabhane approved these changes Sep 15, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 September 15, 2024 19:23

Merge branch 'main' into Guccio163/import-members-csv

dc88ca4

functions moved to utils

92e6745

rlinoz reviewed Sep 17, 2024

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

Guccio163 added 5 commits September 18, 2024 11:36

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

2deb46b

…-fork into Guccio163/import-members-csv

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

38ab688

…-fork into Guccio163/import-members-csv

resolve typecheck

656a3d7

unused translation

213f5fa

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

7861f4f

…-fork into Guccio163/import-members-csv

rlinoz approved these changes Sep 18, 2024

View reviewed changes

Guccio163 added 3 commits September 18, 2024 17:28

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

a36596b

…-fork into Guccio163/import-members-csv

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

5e25def

…-fork into Guccio163/import-members-csv

Merge branch 'main' of github.com:software-mansion-labs/expensify-app…

233388d

…-fork into Guccio163/import-members-csv

madmax330 approved these changes Sep 20, 2024

View reviewed changes

madmax330 merged commit d009d8e into Expensify:main Sep 20, 2024
21 of 22 checks passed

melvin-bot bot added the Emergency label Sep 20, 2024

madmax330 removed the Emergency label Sep 20, 2024

madmax330 mentioned this pull request Sep 20, 2024

Add import flow to Members page #47917

Merged

50 tasks

github-actions bot mentioned this pull request Sep 24, 2024

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed

67 tasks

ishpaul777 mentioned this pull request Sep 25, 2024

[$250] [hold for payment 2024-10-04] Members - Dropdown button is not full width #49749

Closed

6 tasks

aldo-expensify reviewed Sep 25, 2024

View reviewed changes

aldo-expensify mentioned this pull request Sep 25, 2024

[CP Staging] Fix style change #49760

Merged

50 tasks

brunovjk mentioned this pull request Oct 7, 2024

[Payment due Oct 7][$250] [Support CSV] Categories - File contains errors when downloading CSV with no category #49022

Closed

6 tasks

Pujan92 reviewed Dec 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add import and export CSV flow for Members #48876

Add import and export CSV flow for Members #48876

Guccio163 commented Sep 10, 2024 •

edited

Loading

blazejkustra left a comment

Guccio163 commented Sep 11, 2024

melvin-bot bot commented Sep 11, 2024

blazejkustra commented Sep 11, 2024

blazejkustra commented Sep 13, 2024

rushatgabhane commented Sep 15, 2024 •

edited

Loading

rushatgabhane left a comment

melvin-bot bot commented Sep 15, 2024

blazejkustra commented Sep 16, 2024

Guccio163 commented Sep 17, 2024

rlinoz left a comment

Guccio163 commented Sep 18, 2024

Guccio163 commented Sep 20, 2024

melvin-bot bot commented Sep 20, 2024

madmax330 commented Sep 20, 2024

OSBotify commented Sep 20, 2024

OSBotify commented Sep 24, 2024

aldo-expensify Sep 25, 2024

aldo-expensify Sep 25, 2024

aldo-expensify Sep 25, 2024

github-actions bot commented Sep 27, 2024

Pujan92 Dec 4, 2024

Add import and export CSV flow for Members #48876

Add import and export CSV flow for Members #48876

Conversation

Guccio163 commented Sep 10, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

blazejkustra left a comment

Choose a reason for hiding this comment

Guccio163 commented Sep 11, 2024

melvin-bot bot commented Sep 11, 2024

blazejkustra commented Sep 11, 2024

blazejkustra commented Sep 13, 2024

rushatgabhane commented Sep 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 15, 2024

blazejkustra commented Sep 16, 2024

Guccio163 commented Sep 17, 2024

rlinoz left a comment

Choose a reason for hiding this comment

Guccio163 commented Sep 18, 2024

Guccio163 commented Sep 20, 2024

melvin-bot bot commented Sep 20, 2024

madmax330 commented Sep 20, 2024

OSBotify commented Sep 20, 2024

OSBotify commented Sep 24, 2024

aldo-expensify Sep 25, 2024

Choose a reason for hiding this comment

aldo-expensify Sep 25, 2024

Choose a reason for hiding this comment

aldo-expensify Sep 25, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 27, 2024

Pujan92 Dec 4, 2024

Choose a reason for hiding this comment

Guccio163 commented Sep 10, 2024 •

edited

Loading

rushatgabhane commented Sep 15, 2024 •

edited

Loading