-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "submitted by harvesting" report action copy #48939
Merged
neil-marcellini
merged 20 commits into
main
from
beaman-updateSubmittedByHarvestingCopy
Sep 26, 2024
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
baf36ec
Add optional harvesting key for delayed auto submit
Beamanator a019fe1
A few new consts for help sites
Beamanator 292c0a9
New function for building automatically submitted report message
Beamanator c690569
Conditionally show type of submitted message
Beamanator 4181193
Add in translations
Beamanator a307b5e
Fix type issues
Beamanator 68eb6a5
Style fixes
Beamanator d85051d
Merge branch 'main' of github.com:Expensify/App into beaman-updateSub…
Beamanator bf23be5
Merge branch 'main' of github.com:Expensify/App into beaman-updateSub…
Beamanator 2992186
Merge branch 'main' of github.com:Expensify/App into beaman-updateSub…
Beamanator 8b6d355
Update src/languages/es.ts
Beamanator 3afaa62
Merge branch 'main' of github.com:Expensify/App into beaman-updateSub…
Beamanator efb41e6
Merge branch 'beaman-updateSubmittedByHarvestingCopy' of github.com:E…
Beamanator e7523d9
Get user wallet with useOnyx
Beamanator c077731
Fix getting wallet from onyx
Beamanator 63679a1
UseOnyx to get emoji reactions
Beamanator 5a1d6e4
Move linked transaction route error for useOnyx
Beamanator 140f1dc
Get iouReport with useOnyx
Beamanator 0bde076
Prettify, remove withOnyx import
Beamanator 80d0909
Merge branch 'main' of github.com:Expensify/App into beaman-updateSub…
Beamanator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -439,7 +439,7 @@ const ContextMenuActions: ContextMenuAction[] = [ | |
setClipboardMessage(CONST.ACTIONABLE_TRACK_EXPENSE_WHISPER_MESSAGE); | ||
} else if (ReportActionsUtils.isRenamedAction(reportAction)) { | ||
setClipboardMessage(ReportActionsUtils.getRenamedAction(reportAction)); | ||
} else if (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.SUBMITTED) { | ||
} else if (ReportActionsUtils.isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.SUBMITTED)) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm I might need to update this to copy the "automatically..." text, not just "submitted..." 🙃 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixing in #49909 |
||
const displayMessage = ReportUtils.getIOUSubmittedMessage(reportAction); | ||
Clipboard.setString(displayMessage); | ||
} else if (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.APPROVED) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm same here??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep - create a thread off of this auto-submitted action, you'll see the report name is the old text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing in #49909