Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-pdf and react-fast-pdf #49527

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Upgrade react-pdf and react-fast-pdf #49527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 13 additions & 15 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
"react-content-loader": "^7.0.0",
"react-dom": "18.3.1",
"react-error-boundary": "^4.0.11",
"react-fast-pdf": "1.0.14",
"react-fast-pdf": "1.0.15",
"react-map-gl": "^7.1.3",
"react-native": "0.75.2",
"react-native-android-location-enabler": "^2.0.1",
Expand Down Expand Up @@ -174,22 +174,12 @@
"react-native-web": "^0.19.12",
"react-native-web-sound": "^0.1.3",
"react-native-webview": "13.8.6",
"react-pdf": "9.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes work well, but why are we removing react-pdf from package.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might result in different versions of the same package being installed if the versions get out of sync (see #41238).

There are a few other packages not included in packages.json, including pdfjs-dist. Ideally we should re-enable the import/no-extraneous-dependencies rule and add these packages to peerDependencies as we do in react-fast-pdf

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay okay, I don't have a strong opinion about removing it from the package.json. @thienlnam , are you alright with us removing it from the package.json?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opinion here either - should be okay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we can proceed with the merge. The PR has tested well.

"react-plaid-link": "3.3.2",
"react-web-config": "^1.0.0",
"react-webcam": "^7.1.1",
"react-window": "^1.8.9"
},
"devDependencies": {
"@fullstory/babel-plugin-react-native": "^1.2.1",
"@kie/act-js": "^2.6.2",
"@kie/mock-github": "2.0.1",
"@vue/preload-webpack-plugin": "^2.0.0",
"jest-expo": "51.0.4",
"jest-when": "^3.5.2",
"react-compiler-runtime": "file:./lib/react-compiler-runtime",
"semver": "7.5.2",
"xlsx": "file:vendor/xlsx-0.20.3.tgz",
"@actions/core": "1.10.0",
"@actions/github": "5.1.1",
"@babel/core": "^7.20.0",
Expand All @@ -198,6 +188,7 @@
"@babel/plugin-proposal-export-namespace-from": "^7.18.9",
"@babel/plugin-proposal-private-methods": "^7.18.6",
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@babel/plugin-transform-class-properties": "^7.25.4",
"@babel/preset-env": "^7.20.0",
"@babel/preset-flow": "^7.12.13",
"@babel/preset-react": "^7.10.4",
Expand All @@ -209,7 +200,10 @@
"@dword-design/eslint-plugin-import-alias": "^5.0.0",
"@electron/notarize": "^2.1.0",
"@fullstory/babel-plugin-annotate-react": "^2.3.0",
"@fullstory/babel-plugin-react-native": "^1.2.1",
"@jest/globals": "^29.5.0",
"@kie/act-js": "^2.6.2",
"@kie/mock-github": "2.0.1",
"@ngneat/falso": "^7.1.1",
"@octokit/core": "4.0.4",
"@octokit/plugin-paginate-rest": "3.1.0",
Expand Down Expand Up @@ -258,14 +252,14 @@
"@typescript-eslint/eslint-plugin": "^7.13.1",
"@typescript-eslint/parser": "^7.13.1",
"@vercel/ncc": "0.38.1",
"@vue/preload-webpack-plugin": "^2.0.0",
"@welldone-software/why-did-you-render": "7.0.1",
"ajv-cli": "^5.0.0",
"babel-jest": "29.4.1",
"babel-loader": "^9.1.3",
"babel-plugin-module-resolver": "^5.0.0",
"babel-plugin-react-compiler": "0.0.0-experimental-334f00b-20240725",
"babel-plugin-react-native-web": "^0.18.7",
"@babel/plugin-transform-class-properties": "^7.25.4",
"babel-plugin-transform-remove-console": "^6.9.4",
"clean-webpack-plugin": "^4.0.0",
"concurrently": "^8.2.2",
Expand All @@ -283,19 +277,21 @@
"eslint-plugin-deprecation": "^3.0.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-jsdoc": "^46.2.6",
"eslint-plugin-lodash": "^7.4.0",
"eslint-plugin-react-compiler": "0.0.0-experimental-9ed098e-20240725",
"eslint-plugin-react-native-a11y": "^3.3.0",
"eslint-plugin-storybook": "^0.8.0",
"eslint-plugin-testing-library": "^6.2.2",
"eslint-plugin-you-dont-need-lodash-underscore": "^6.14.0",
"eslint-plugin-lodash": "^7.4.0",
"html-webpack-plugin": "^5.5.0",
"http-server": "^14.1.1",
"jest": "29.4.1",
"jest-circus": "29.4.1",
"jest-cli": "29.4.1",
"jest-environment-jsdom": "^29.4.1",
"jest-expo": "51.0.4",
"jest-transformer-svg": "^2.0.1",
"jest-when": "^3.5.2",
"link": "^2.1.1",
"memfs": "^4.6.0",
"onchange": "^7.1.0",
Expand All @@ -306,10 +302,12 @@
"prettier": "^2.8.8",
"pusher-js-mock": "^0.3.3",
"react-compiler-healthcheck": "^0.0.0-experimental-ab3118d-20240725",
"react-compiler-runtime": "file:./lib/react-compiler-runtime",
"react-is": "^18.3.1",
"react-native-clean-project": "^4.0.0-alpha4.0",
"react-test-renderer": "18.3.1",
"reassure": "^1.0.0-rc.4",
"semver": "7.5.2",
"setimmediate": "^1.0.5",
"shellcheck": "^1.1.0",
"source-map": "^0.7.4",
Expand All @@ -326,7 +324,8 @@
"webpack-bundle-analyzer": "^4.5.0",
"webpack-cli": "^5.0.4",
"webpack-dev-server": "^5.0.4",
"webpack-merge": "^5.8.0"
"webpack-merge": "^5.8.0",
"xlsx": "file:vendor/xlsx-0.20.3.tgz"
},
"overrides": {
"react-native": "0.75.2",
Expand All @@ -338,7 +337,6 @@
"yargs-parser": "21.1.1",
"@expo/config-plugins": "8.0.4",
"ws": "8.17.1",
"react-pdf": "9.1.0",
"micromatch": "4.0.8",
"json5": "2.2.2",
"loader-utils": "2.0.4",
Expand Down
13 changes: 0 additions & 13 deletions patches/react-fast-pdf+1.0.14.patch
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions patches/react-pdf+9.1.0.patch
View file
Open in desktop

This file was deleted.

Loading