Fix - Attachment - Unable to download a txt attachment until the browser is refreshed #49898

HezekielT · 2024-09-29T17:35:59Z

Details

Fixed Issues

$ #48679
PROPOSAL: #48679 (comment)

Tests

Go to New expensify and open a chat.
Click on + of the composer and select Add Attachment option.
Upload a txt file(sample file for testing purpose)
Click Send.
Verify that the loading spinner is shown while uploading the attachment and hovering over it shows a tooltip that says Uploading.
After the attachment is uploaded, click on the download icon.
Verify the attachment is downloaded successfully.

Verify that no errors appear in the JS console

Offline tests

An Internet connection is required to upload an attachment.

QA Steps

Same as Tests Section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-upload-loading-spinner.mp4

Android: mWeb Chrome

android-mweb-upload-loading-spinner.mp4

iOS: Native

ios-native-upload-loading-spinner.mp4

iOS: mWeb Safari

ios-safari-upload-loading-spinner.mp4

MacOS: Chrome / Safari

full-video-loading-spinner.mp4

MacOS: Desktop

desktop-upload.mp4

melvin-bot · 2024-09-30T16:25:51Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

HezekielT · 2024-09-30T20:20:24Z

Asked for translation confirmation on slack(https://expensify.slack.com/archives/C01GTK53T8Q/p1727696948270859)

HezekielT · 2024-10-08T07:19:56Z

@getusha Friendly bump!

getusha · 2024-10-13T13:32:16Z

src/components/Attachments/AttachmentView/index.tsx


-        /** Function for handle on press */
-        onPress?: (e?: GestureResponderEvent | KeyboardEvent) => void;
+    isUsedInAttachmentModal?: boolean;


we missed to add a comment to this prop when it was added, could we add it please?

getusha · 2024-10-13T13:56:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-13.at.4.54.39.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2024-10-13.at.4.44.07.in.the.afternoon.mov

iOS: Native

Screen.Recording.2024-10-13.at.4.44.07.in.the.afternoon.mov

iOS: mWeb Safari

Screen.Recording.2024-10-13.at.4.41.40.in.the.afternoon.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-13.at.4.39.48.in.the.afternoon.mov

MacOS: Desktop

Screen.Recording.2024-10-13.at.4.50.05.in.the.afternoon.mov

aldo-expensify · 2024-10-15T17:41:08Z

src/components/Attachments/AttachmentView/index.tsx

@@ -95,16 +92,20 @@ function AttachmentView({
    isWorkspaceAvatar,
    maybeIcon,
    fallbackSource,
-    transaction,
+    transactionID = '-1',


There is a conversation about the usage of -1 as default here: https://expensify.slack.com/archives/C01GTK53T8Q/p1729014019344209?thread_ts=1728329641.957179&cid=C01GTK53T8Q

In the future I understand we want undefined or null (not sure which one), so I don't know if we should be using null or undefined or -1 here.

We will continue with -1 for now and migrate later.

OSBotify · 2024-10-16T08:37:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-17T01:58:44Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-18T18:47:34Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

HezekielT added 7 commits September 29, 2024 12:48

add isUploading to language and use it in DefaultAttachmentView

8da97f8

pass isUploading and use it show loading spinner.

692a88b

replace withOnyx by useOnyx

fcf13c9

run prettier

87aa484

remove unused imports

33360aa

remove unused imports

86d532a

remove unused imports

bd9a32f

HezekielT marked this pull request as ready for review September 30, 2024 16:25

HezekielT requested a review from a team as a code owner September 30, 2024 16:25

melvin-bot bot requested review from getusha and removed request for a team September 30, 2024 16:25

Merge branch 'Expensify:main' into fix-48679

9e228dc

getusha reviewed Oct 13, 2024

View reviewed changes

getusha approved these changes Oct 13, 2024

View reviewed changes

melvin-bot bot requested a review from aldo-expensify October 13, 2024 13:57

HezekielT added 2 commits October 15, 2024 11:03

Merge branch 'main' of https://github.com/HezekielT/App into fix-48679

9b536ef

added a comment

28cf9ad

aldo-expensify reviewed Oct 15, 2024

View reviewed changes

aldo-expensify approved these changes Oct 16, 2024

View reviewed changes

aldo-expensify merged commit 96ffbfe into Expensify:main Oct 16, 2024
19 checks passed

github-actions bot mentioned this pull request Oct 17, 2024

Deploy Checklist: New Expensify 2024-10-17 #50969

Closed

90 tasks

Beamanator mentioned this pull request Oct 17, 2024

Revert "Fix - Attachment - Unable to download a txt attachment until the browser is refreshed" #50983

Closed

melvin-bot bot mentioned this pull request Oct 18, 2024

[HOLD for payment 2024-10-25] [$250] Web - Attachment - Unable to download a txt attachment until the browser is refreshed #48679

Closed

6 tasks

Nodebrute mentioned this pull request Oct 31, 2024

Chat -Uploading csv file in offline showing infinite loading #51810

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix - Attachment - Unable to download a txt attachment until the browser is refreshed #49898

Fix - Attachment - Unable to download a txt attachment until the browser is refreshed #49898

HezekielT commented Sep 29, 2024 •

edited

Loading

melvin-bot bot commented Sep 30, 2024

HezekielT commented Sep 30, 2024

HezekielT commented Oct 8, 2024

getusha Oct 13, 2024

HezekielT Oct 15, 2024

getusha commented Oct 13, 2024

aldo-expensify Oct 15, 2024

aldo-expensify Oct 16, 2024

OSBotify commented Oct 16, 2024

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

Fix - Attachment - Unable to download a txt attachment until the browser is refreshed #49898

Fix - Attachment - Unable to download a txt attachment until the browser is refreshed #49898

Conversation

HezekielT commented Sep 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 30, 2024

HezekielT commented Sep 30, 2024

HezekielT commented Oct 8, 2024

getusha Oct 13, 2024

Choose a reason for hiding this comment

HezekielT Oct 15, 2024

Choose a reason for hiding this comment

getusha commented Oct 13, 2024

Reviewer Checklist

Screenshots/Videos

aldo-expensify Oct 15, 2024

Choose a reason for hiding this comment

aldo-expensify Oct 16, 2024

Choose a reason for hiding this comment

OSBotify commented Oct 16, 2024

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

HezekielT commented Sep 29, 2024 •

edited

Loading