-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ReportPreview / Text] When showing two avatars, also show both display names with tooltip #50341
Conversation
@eh2077 I assigned you since this is code from the original PR, I'm breaking it into pieces |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safariweb.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good just a minor comment.
I'll complete remain recordings early tmr as it's EOD for me.
{personArray.map((fragment) => ( | ||
<ReportActionItemFragment | ||
style={[styles.flex1]} | ||
key={`person-${action?.reportActionID}-${actorAccountID}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to use index suffix like before. Because it's possible that
personArray.length === 2
and isReportPreviewAction
is false right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify the above comment, we may be able to remove the isReportPreviewAction
check entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. For the lint error, maybe we can just disable the lint by adding
// eslint-disable-next-line react/no-array-index-key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I see what you mean, updating now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.47-1 🚀
|
This PR is failing for Web because of issue #50547 |
Reverted because of these reasons. |
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.47-4 🚀
|
Details
We Reverted https://github.com/Expensify/App/pull/49172/files#diff-f0268faeaefd2de8c31b3f9ceba588c49478c66413b82b3285b0704b820a57a8
I'm breaking it into smaller PRs to avoid blockers- this PR allows for displaying both names if two avatars are shown. It does not change what avatars are shown.
Fixed Issues
Part of #49036
PROPOSAL:
Tests
Offline tests
QA Steps
Name 1 & Name 2
FormatName 1
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop