[No QA] [Direct Feeds] Broken connection violation #50793

VickyStash · 2024-10-15T11:51:00Z

Details

[Direct Feeds] Broken connection violation

Fixed Issues

$ #50454
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Login to the app as User A.
Create a workspace and add as a member User B.
Submit an expense in this workspace and retrieve its transactionId.
Manually update update onyx data to add brokenCardConnection violation to transaction violations. Example:

Onyx.set(`transactionViolations_YOUR_TRANSACTION_ID`, [{
   type: 'warning',
   name: 'rter',
   data: {rterType: 'brokenCardConnection'},
}]);

Also, you can pass it in successData for OpenReport call, this way it won't be overwritten.

Make sure the warning is displayed and looks as expected for User A.
Login to the app as User B, repeat step 4. Make sure the warning is displayed and looks as expected.

Offline tests

Same as in the Tests section.

QA Steps

Verify that no errors appear in the JS console

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…unctions

…iolation

melvin-bot · 2024-10-15T14:46:55Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf

seems good to me, other then the type of description, I see this PR matching the design doc, i will complete the checklist in the meantime

allgandalf · 2024-10-15T18:46:32Z

src/components/BrokenConnectionDescription.tsx

+function BrokenConnectionDescription({transactionID, policy, report}: BrokenConnectionDescriptionProps) {
+    const styles = useThemeStyles();
+    const {translate} = useLocalize();
+    const [transactionViolations] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`);


my concern here is that for a fraction of time useOnyx gives undefined value, hope this doesn't affect the violation fetch. We can only test this in production, so lets stay hopeful 🤞

allgandalf · 2024-10-15T19:52:36Z

src/components/BrokenConnectionDescription.tsx

+        return translate('violations.brokenConnection530Error');
+    }
+
+    if (isPolicyAdmin) {


cool makes sense, according to docs:

Admins can also see violation, but we hide the Mark as cash button (same as the 7-day-hold doc.)

So we match the expected results

@VickyStash :

What about the case when the submitter itself is the policy admin ?

The logic for the admin will be applied. Do you have any concerns?

yes, if i am admin and i submit a request with violation, Now i won't be able to see the mark as cash button even when i submitted the report, is that expected?

I guess so cause you, as admin, can go to Company Cards page and resolve the violation (fix broken connection).
cc @joekaufmanexpensify @mountiny To confirm as well.

If the admin is a submitter on that report, lets show them the Mark as cash button too. So I guess the logic would be - show it to the users who is the owner of the report (submitter) even if they are admin

c.c. @VickyStash

I'll update the check in ~15 mins!

@mountiny I've started to have some doubts about this approach as it goes against the docs.
In docs it mentiones that

Admins can’t resolve this violation with the Mark as cash button, but they can fix the broken card connection, which indirectly resolves this violation.

https://docs.google.com/document/d/1rWjtZqMd15ACI5OUBTb_Kpd-1bAfrDGcZZU9jcQztUI/edit#bookmark=id.xzmm2dzeoc1g

Also the message for the admin doesn't mention Mark as cash button. Should we then update the text of the message for the admin?

Updated! Thank you all for clarifications! ✨

allgandalf · 2024-10-15T19:57:18Z

src/components/MoneyRequestHeaderStatusBar.tsx

@@ -9,7 +9,7 @@ type MoneyRequestHeaderStatusBarProps = {
    icon: ReactNode;

    /** Banner Description */
-    description: string;
+    description: string | ReactElement;


Shouldn't we save the description as string itself, we can convert the prop into string before passing ? (saying cause we don't want the BE to throw some weird error

@allgandalf could you clarify what BE errors do you mean?
This component just renders the description display.
Since for the admin, the broken connection violation text can include TextLink (link to company cards), it returned as a component.

App/src/components/MoneyRequestHeaderStatusBar.tsx

Lines 18 to 28 in 91e299d

function MoneyRequestHeaderStatusBar({icon, description, shouldStyleFlexGrow = true}: MoneyRequestHeaderStatusBarProps) {

const styles = useThemeStyles();

return (

<View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, shouldStyleFlexGrow && styles.flexGrow1, styles.overflowHidden, styles.headerStatusBarContainer]}>

<View style={styles.mr2}>{icon}</View>

<View style={[styles.flexShrink1]}>

<Text style={[styles.textLabelSupporting]}>{description}</Text>

</View>

</View>

);

}

allgandalf · 2024-10-15T20:01:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-16.at.6.08.19.PM.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Screen.Recording.2024-10-16.at.3.02.43.PM.mov

src/components/BrokenConnectionDescription.tsx

allgandalf

functionality and styling are correct and match the design doc, we only made one change that if admin is submitter then we show the mark as cash button (details in slack).

Looks great to me, thanks for the quick work !

mountiny

Small nab comments

mountiny · 2024-10-17T08:13:34Z

src/languages/en.ts

+        rter: ({brokenBankConnection, email, isAdmin, isTransactionOlderThan7Days, member, rterType}: ViolationsRterParams) => {
+            if (rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION_530 || rterType === CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION) {
+                return '';
+            }
            if (brokenBankConnection) {
                return isAdmin
                    ? `Can't auto-match receipt due to broken bank connection which ${email} needs to fix`


When will we use these translations? Should we remove then?

The updates were implemented in this PR.
It looks like it makes the error to be shown next to the merchant field on the Money Request View for rter violation.

mountiny · 2024-10-17T08:15:50Z

src/libs/TransactionUtils/index.ts

+function shouldShowBrokenConnectionViolation(transactionID: string, report: OnyxEntry<Report>, policy: OnyxEntry<Policy>): boolean {
+    return (
+        hasBrokenConnectionViolation(transactionID) &&
+        (!PolicyUtils.isPolicyAdmin(policy) || ReportUtils.isOpenExpenseReport(report) || (ReportUtils.isProcessingReport(report) && PolicyUtils.isInstantSubmitEnabled(policy)))


They can also be the submitter if they are admin

You mean I should update it to:

const isUserMemberOrSubmitter = !PolicyUtils.isPolicyAdmin(policy) || ReportUtils.isCurrentUserSubmitter(report.reportID); return ( hasBrokenConnectionViolation(transactionID) && (isUserMemberOrSubmitter || ReportUtils.isOpenExpenseReport(report) || (ReportUtils.isProcessingReport(report) && PolicyUtils.isInstantSubmitEnabled(policy)))

OSBotify · 2024-10-17T08:29:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-18T19:05:06Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.51-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-22T04:38:22Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

github-actions · 2024-10-22T17:20:46Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

VickyStash added 7 commits October 14, 2024 14:15

Add hasBrokenConnectionViolation and getBrokenConnectionDescription f…

2f90dd1

…unctions

Merge branch 'refs/heads/main' into feature/50454-broken-connection-v…

7e7c40c

…iolation

Add broken connection violation warning display

7bce745

Fix message display

ba663d7

Fix

d9316e8

Update MoneyRequestPreviewContent component

129025e

Lint fixes

91e299d

VickyStash changed the title ~~[WIP] [Direct Feeds] Broken connection violation~~ [Direct Feeds] Broken connection violation Oct 15, 2024

VickyStash marked this pull request as ready for review October 15, 2024 14:46

VickyStash requested a review from a team as a code owner October 15, 2024 14:46

melvin-bot bot requested a review from allgandalf October 15, 2024 14:46

melvin-bot bot removed the request for review from a team October 15, 2024 14:46

VickyStash changed the title ~~[Direct Feeds] Broken connection violation~~ [No QA] [Direct Feeds] Broken connection violation Oct 15, 2024

VickyStash mentioned this pull request Oct 15, 2024

[HOLD for payment 2024-10-29] [Direct Feeds] [App] Broken connection violation #50454

Closed

mountiny self-requested a review October 15, 2024 15:55

allgandalf reviewed Oct 15, 2024

View reviewed changes

allgandalf reviewed Oct 16, 2024

View reviewed changes

src/components/BrokenConnectionDescription.tsx Show resolved Hide resolved

allgandalf reviewed Oct 16, 2024

View reviewed changes

src/components/BrokenConnectionDescription.tsx Show resolved Hide resolved

Updated the checks

630893f

allgandalf approved these changes Oct 16, 2024

View reviewed changes

mountiny approved these changes Oct 17, 2024

View reviewed changes

mountiny merged commit 0b05f53 into Expensify:main Oct 17, 2024
19 checks passed

github-actions bot mentioned this pull request Oct 18, 2024

Deploy Checklist: New Expensify 2024-10-18 #51106

Closed

59 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] [Direct Feeds] Broken connection violation #50793

[No QA] [Direct Feeds] Broken connection violation #50793

VickyStash commented Oct 15, 2024 •

edited

Loading

melvin-bot bot commented Oct 15, 2024

allgandalf left a comment

allgandalf Oct 15, 2024

allgandalf Oct 15, 2024

allgandalf Oct 15, 2024

VickyStash Oct 16, 2024

allgandalf Oct 16, 2024

VickyStash Oct 16, 2024

mountiny Oct 16, 2024

allgandalf Oct 16, 2024 •

edited

Loading

VickyStash Oct 16, 2024

VickyStash Oct 16, 2024

VickyStash Oct 16, 2024

allgandalf Oct 15, 2024

VickyStash Oct 16, 2024

allgandalf commented Oct 15, 2024 •

edited

Loading

allgandalf left a comment

mountiny left a comment

mountiny Oct 17, 2024

VickyStash Oct 17, 2024

mountiny Oct 17, 2024

VickyStash Oct 17, 2024

OSBotify commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

	function MoneyRequestHeaderStatusBar({icon, description, shouldStyleFlexGrow = true}: MoneyRequestHeaderStatusBarProps) {
	const styles = useThemeStyles();
	return (
	<View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, shouldStyleFlexGrow && styles.flexGrow1, styles.overflowHidden, styles.headerStatusBarContainer]}>
	<View style={styles.mr2}>{icon}</View>
	<View style={[styles.flexShrink1]}>
	<Text style={[styles.textLabelSupporting]}>{description}</Text>
	</View>
	</View>
	);
	}

[No QA] [Direct Feeds] Broken connection violation #50793

[No QA] [Direct Feeds] Broken connection violation #50793

Conversation

VickyStash commented Oct 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 15, 2024

allgandalf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allgandalf Oct 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allgandalf commented Oct 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

VickyStash commented Oct 15, 2024 •

edited

Loading

allgandalf Oct 16, 2024 •

edited

Loading

allgandalf commented Oct 15, 2024 •

edited

Loading