Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small search visual bugs #51081

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Fix small search visual bugs #51081

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
586511e
Don't display search icon in Travel AddressPage
Kicu Oct 18, 2024
4f2da3a
Fix incorrect placement and spacing of SearchButton
Kicu Oct 18, 2024
3fddd1a
Merge branch 'main' into kicu/51009-search-icon
Kicu Oct 21, 2024
f683438
Merge branch 'main' into kicu/51009-search-icon
Kicu Oct 21, 2024
2815eca
Fix spacing around SearchButton in Headers
Kicu Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/HeaderWithBackButton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,8 @@ function HeaderWithBackButton({
</PressableWithoutFeedback>
</Tooltip>
)}
{shouldDisplaySearchRouter && <SearchButton />}
</View>
{shouldDisplaySearchRouter && <SearchButton />}
</View>
</View>
);
Expand Down
1 change: 0 additions & 1 deletion src/pages/AddressPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ function AddressPage({title, address, updateAddress, isLoadingApp = true, backTo
title={title}
shouldShowBackButton
onBackButtonPress={() => Navigation.goBack(backTo)}
shouldDisplaySearchRouter
/>
{isLoadingApp ? (
<FullscreenLoadingIndicator style={[styles.flex1, styles.pRelative]} />
Expand Down
Loading