add extra css selector to global autofill style -add css class to the… #51117

klajdipaja · 2024-10-19T12:53:44Z

… SignInPageLayout to apply sign-in only styles

Details

Add DARK theme CSS styles for auto-fill input in the SignInPage on the web version.

Fixed Issues

$ #50460
PROPOSAL: #50460 (comment)

Tests

Scenario 1.

Open the staging.new.expensify.com website
Log out of the account
Tap on the Email field on log in screen
Write one letter on it
Select the first available option tapping on notebook pad
Verify the selected Email is visible on the Email field

Scenario 2.

Open the staging.new.expensify.com website
Log out of the account
Change the system theme preferences to Light Mode (MacOS)
Tap on the Email field on log in screen
Write one letter on it
Select the first available option tapping on notebook pad
Verify the selected Email is visible on the Email field

Scenario 3.

Open the staging.new.expensify.com website
Change the Theme Preferences in Expensify to Dark Mode and log out of the account
Tap on the Email field on log in screen
Write one letter on it
Select the first available option tapping on notebook pad
Verify the selected Email is visible on the Email field

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-10-25.at.12.37.19.PM.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-10-25.at.1.21.03.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-24.at.1.26.23.PM.mov

MacOS: Desktop

…d apply web autofill input

klajdipaja · 2024-10-24T16:33:07Z

@c3024 Do you know what to do about the performance tests check that has failed with this error?

Processing measurement 1: [ReportScreen] should render ReportScreen
Error: Render count difference exceeded the allowed deviation of 0. Current difference: 1

c3024 · 2024-10-25T07:56:15Z

Please merge main. The check failure is not related to changes in this PR.

…utofill_style

melvin-bot · 2024-10-25T12:19:12Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/signin/SignInPageLayout/index.tsx

…to the platform that this styles are applied for Co-authored-by: Krishna Chaitanya <[email protected]>

…le' into issues/sign_in_dark_autofill_style # Conflicts: # src/pages/signin/SignInPageLayout/index.tsx

c3024 · 2024-10-29T16:29:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

themeAndroid.mp4

Android: mWeb Chrome

themeAndroidmWeb.mp4

iOS: Native

themeiOS.mp4

iOS: mWeb Safari

themeiOSmWeb.mp4

MacOS: Chrome / Safari

themeChrome.mp4

MacOS: Desktop

themeDesktop.mp4

c3024

LGTM!

OSBotify · 2024-10-29T17:51:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-31T11:40:42Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-04T14:13:26Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.56-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

klajdipaja mentioned this pull request Oct 19, 2024

[HOLD for payment 2024-11-11] [$250] Web - Login - Invisible text in Email field when logging out and selecting predictive option #50460

Closed

6 tasks

klajdipaja force-pushed the issues/sign_in_dark_autofill_style branch from 42454b8 to 8220bfa Compare October 24, 2024 11:18

add css class to the SignInPageLayout to apply sign-in only styles an…

5c0eeae

…d apply web autofill input

klajdipaja force-pushed the issues/sign_in_dark_autofill_style branch from ae3e3fd to 5c0eeae Compare October 24, 2024 11:21

Merge remote-tracking branch 'origin/main' into issues/sign_in_dark_a…

31b1860

…utofill_style

klajdipaja marked this pull request as ready for review October 25, 2024 12:19

klajdipaja requested a review from a team as a code owner October 25, 2024 12:19

melvin-bot bot requested a review from c3024 October 25, 2024 12:19

melvin-bot bot removed the request for review from a team October 25, 2024 12:19

c3024 suggested changes Oct 26, 2024

View reviewed changes

src/pages/signin/SignInPageLayout/index.tsx Show resolved Hide resolved

src/pages/signin/SignInPageLayout/index.tsx Outdated Show resolved Hide resolved

klajdipaja and others added 4 commits October 26, 2024 18:46

add comment for new autofill styles in sign in input and add desktop …

f083b7a

…to the platform that this styles are applied for Co-authored-by: Krishna Chaitanya <[email protected]>

add comment for new autofill styles in sign in input and add desktop …

08494ae

…to the platform that this styles are applied for Co-authored-by: Krishna Chaitanya <[email protected]>

Merge remote-tracking branch 'origin/issues/sign_in_dark_autofill_sty…

528567a

…le' into issues/sign_in_dark_autofill_style # Conflicts: # src/pages/signin/SignInPageLayout/index.tsx

fix lint and tsc errors

81f38b0

c3024 approved these changes Oct 29, 2024

View reviewed changes

melvin-bot bot requested a review from thienlnam October 29, 2024 16:33

thienlnam approved these changes Oct 29, 2024

View reviewed changes

thienlnam merged commit cfdd59e into Expensify:main Oct 29, 2024
17 checks passed

github-actions bot mentioned this pull request Oct 31, 2024

Deploy Checklist: New Expensify 2024-10-31 #51778

Closed

klajdipaja deleted the issues/sign_in_dark_autofill_style branch November 1, 2024 13:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add extra css selector to global autofill style -add css class to the… #51117

add extra css selector to global autofill style -add css class to the… #51117

klajdipaja commented Oct 19, 2024 •

edited

Loading

klajdipaja commented Oct 24, 2024

c3024 commented Oct 25, 2024

melvin-bot bot commented Oct 25, 2024

c3024 commented Oct 29, 2024 •

edited

Loading

c3024 left a comment

OSBotify commented Oct 29, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Nov 4, 2024

add extra css selector to global autofill style -add css class to the… #51117

add extra css selector to global autofill style -add css class to the… #51117

Conversation

klajdipaja commented Oct 19, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

klajdipaja commented Oct 24, 2024

c3024 commented Oct 25, 2024

melvin-bot bot commented Oct 25, 2024

c3024 commented Oct 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 29, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Nov 4, 2024

klajdipaja commented Oct 19, 2024 •

edited

Loading

c3024 commented Oct 29, 2024 •

edited

Loading