Fix/10731 auto focus input

[christianwen]

Details

Fixed Issues

$ #10731
PROPOSAL: #10731 (comment)

Tests

• 10731

1. Go to any chats
2. Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown
3. Sent any message
4. Open edit mode
5. Verify that the keyboard is shown
6. Tap on the composer to bring up context menu.
7. Verify the context menu is shown

• 50683

1. Login to an account
2. Open any chat, notice that the composer is focused.
3. Press on CTRL + K
4. Press ESC key to dismissed the 'search modal'
5. Verify that: Composer is focused after dismissing the modal

• 50722

1. Open the Hybrid app/NewDot app and log in as user A
2. On a secondary device as user B send an IOU to user A
3. On main device as user A open the chat with user B
4. Select a different payment option on the IOU preview
5. Verify that: The page does not flicker when changing a payment option

• Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-31.at.11.47.30.mov

Android: mWeb Chrome

Screen.Recording.2024-10-31.at.11.43.17.mov

iOS: Native

Screen.Recording.2024-10-31.at.11.49.52.mov

iOS: mWeb Safari

Screen.Recording.2024-10-31.at.11.39.29.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-31.at.11.39.54.mov

MacOS: Desktop

Screen.Recording.2024-10-31.at.11.53.43.mov

[christianwen]

Updated change compare to previous PR:

For 50683: The PR works well without any change, maybe after moving to chat search modal, it's fixed

For 50722: This issue happens even on main, you can see the flicker when the keyboard open. It's the bug from keyboardAvoidingView, in case the soft keyboard is hidden, we don't need to enable it.

[melvin-bot]

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

Reviewing today

[DylanDylann]

@christianwen Is there any new update on this file?

[christianwen]

no new update, just moved to the new file

[DylanDylann]

@christianwen Could you also please help to merge the latest main?

[christianwen]

@DylanDylann I merged main and resolved conflicts

[DylanDylann]

@christianwen It is a bit flicker on Safari

Screen.Recording.2024-11-13.at.18.35.39.mov

[christianwen]

@DylanDylann

I removed in shouldFocusInputOnScreenFocus in

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 282 in d5e7a5a

(shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction) && !ReportUtils.isTaskReport(report))) &&

since we want to enable autoFocus in every devices.

but it breaks the following logic

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 646 in d5e7a5a

if (!((willBlurTextInputOnTapOutside || shouldAutoFocus) && !isNextModalWillOpenRef.current && !modal?.isVisible && isFocused && (!!prevIsModalVisible || !prevIsFocused))) {

Based on this comment

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 643 to 645 in d5e7a5a

	// We want to focus or refocus the input when a modal has been closed or the underlying screen is refocused.
	// We avoid doing this on native platforms since the software keyboard popping
	// open creates a jarring and broken UX.

we need to add shouldFocusInputOnScreenFocus again in the above condition

[DylanDylann]

@christianwen BUG on safari: when going to the chat, the cursor displays in the middle or in the end of the composer in a moment
Step:

1. Go to chat A (Don't see the bug)
2. Back to LHN
3. Go to chat A (See the Bug)
4. Back to LHN
5. Go to chat A (See the Bug)

Screen.Recording.2024-11-18.at.16.39.33.mov

[christianwen]

@DylanDylann

The cursor is hidden when the transition is not finished on staging

Screen.Recording.2024-11-20.at.15.56.44.mov

But when the inputMode is none the cursor is not hidden during report transition. I spent time to invest, unfortunately, I didn't find the RCA, so I just hide the cursor same as what happens on staging.

[DylanDylann]

@christianwen With your solution, the draft message will not display right after going to the chat

Screen.Recording.2024-11-20.at.17.44.38.mov

[christianwen]

@DylanDylann I fixed the issue above. Pls take a look

[DylanDylann]

@christianwen BUG on mobile web

1. Focus on the edit composer
2. Click the dropdown button or pay button or X button or click somewhere
3. The main composer gets focused again

On staging: The main composer isn't getting focused again

Screen.Recording.2024-11-26.at.10.24.40.mov

[DylanDylann]

BUG on IOS: The composer is hidden by the keyboard

Behavior on this change

Screen.Recording.2024-11-26.at.11.17.32.mov

Behavior on the main

Screen.Recording.2024-11-26.at.11.16.59.mov

[christianwen]

@DylanDylann I fixed this issue.

For this bug, the RCA is because on small screen, we hide the main composer when focus on edit composer. When users click outside to blur, the main composer will appear and trigger the logic autoFocus (this value is true). I know it's quite different from staging/main but I don't see any problems about this behavior so we can ignore it for now. Pls let me know what you think.

[DylanDylann]

For #51172 (comment), the RCA is because on small screen, we hide the main composer when focus on edit composer. When users click outside to blur, the main composer will appear and trigger the logic autoFocus (this value is true). I know it's quite different from staging/main but I don't see any problems about this behavior so we can ignore it for now. Pls let me know what you think.

But the cursor is moving to the beginning of the main composer and I think it is incorrect.

[christianwen]

@DylanDylann I can't reproduce your bug above?

[DylanDylann]

@christianwen Please try more time

Screen.Recording.2024-12-05.at.17.25.00.mov

[DylanDylann]

Flicker on IOS

1. Go to any chat that have draft message
2. Edit message
3. Click X

Screen.Recording.2024-12-05.at.17.40.06.mov

[DylanDylann]

@christianwen Kindly bump