Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add report fields to QBO/Xero #51321

Merged
merged 32 commits into from
Oct 25, 2024
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
d4da88c
add QBO routes for report fields selection
lakchote Oct 23, 2024
5e7380d
add QBO screens for report fields selection
lakchote Oct 23, 2024
4dd4829
define types for new QBO screens
lakchote Oct 23, 2024
5c7cc28
link the new QBO screens to relative routes
lakchote Oct 23, 2024
a63bc1d
link new QBO screens to corresponding components
lakchote Oct 23, 2024
069884c
add new QBO screens
lakchote Oct 23, 2024
63e4a53
adjust translations for QBO report fields
lakchote Oct 23, 2024
ccf7da4
allow locations for vendor bills and checks
lakchote Oct 23, 2024
29ce003
link to new QUICKBOOKS_ONLINE_CLASSES_DISPLAYED_AS route
lakchote Oct 23, 2024
064c4cc
component for QUICKBOOKS_ONLINE_CLASSES_DISPLAYED_AS route
lakchote Oct 23, 2024
6f1fadf
link to new QUICKBOOKS_ONLINE_CUSTOMERS_DISPLAYED_AS route
lakchote Oct 23, 2024
f3a3430
component for QUICKBOOKS_ONLINE_CUSTOMERS_DISPLAYED_AS route
lakchote Oct 23, 2024
9eea23d
link to new QUICKBOOKS_ONLINE_LOCATIONS_DISPLAYED_AS route
lakchote Oct 23, 2024
6bd6a67
component for QUICKBOOKS_ONLINE_LOCATIONS_DISPLAYED_AS route
lakchote Oct 23, 2024
67c8941
add report field option for Xero tracking categories
lakchote Oct 23, 2024
4a5350c
fix style
lakchote Oct 23, 2024
2e33bff
fix translation keys
lakchote Oct 23, 2024
f93a540
adjust for fixed translation keys
lakchote Oct 23, 2024
bbf3ea9
fix lint
lakchote Oct 23, 2024
68a6b8b
fix style
lakchote Oct 23, 2024
bd6c9fe
fix lint
lakchote Oct 23, 2024
e50f050
fix lint
lakchote Oct 23, 2024
4485e8d
uppercase word to be consistent with english wording
lakchote Oct 24, 2024
a7772ad
fix logic
lakchote Oct 24, 2024
a8a3862
fix lint
lakchote Oct 24, 2024
12dd284
address comments and handle invalid configuration
lakchote Oct 24, 2024
2dc2dfa
fix lint
lakchote Oct 24, 2024
a7ee8fb
create utility file for QBO
lakchote Oct 24, 2024
661dbb1
use utils
lakchote Oct 24, 2024
4f1e768
handle locations with incorrect configuration
lakchote Oct 24, 2024
63e6290
fix lint
lakchote Oct 24, 2024
a391854
fix style
lakchote Oct 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
lakchote committed Oct 23, 2024
commit e50f0506fd216e619974555e6ab16ac4f4691edb
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ function QuickbooksOutOfPocketExpenseEntitySelectPage({policy}: WithPolicyConnec
const styles = useThemeStyles();
const qboConfig = policy?.connections?.quickbooksOnline?.config;
const {bankAccounts, accountPayable, journalEntryAccounts} = policy?.connections?.quickbooksOnline?.data ?? {};
const isLocationsEnabled = !!(qboConfig?.syncLocations && qboConfig?.syncLocations !== CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE);
const isTaxesEnabled = !!qboConfig?.syncTax;
const shouldShowTaxError = isTaxesEnabled && qboConfig?.reimbursableExpensesExportDestination === CONST.QUICKBOOKS_REIMBURSABLE_ACCOUNT_TYPE.JOURNAL_ENTRY;
const hasErrors = !!qboConfig?.errorFields?.reimbursableExpensesExportDestination && shouldShowTaxError;
Expand Down Expand Up @@ -75,7 +74,7 @@ function QuickbooksOutOfPocketExpenseEntitySelectPage({policy}: WithPolicyConnec
accounts: accountPayable ?? [],
},
],
[qboConfig?.reimbursableExpensesExportDestination, qboConfig?.syncLocations, translate, isLocationsEnabled, bankAccounts, accountPayable, journalEntryAccounts],
[qboConfig?.reimbursableExpensesExportDestination, qboConfig?.syncLocations, translate, bankAccounts, accountPayable, journalEntryAccounts, isTaxesEnabled],
);

const sections = useMemo(() => [{data: data.filter((item) => item.isShown)}], [data]);
Expand Down
Loading