-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA]: Add test to reauthenticate offline user #51805
Merged
madmax330
merged 2 commits into
Expensify:main
from
callstack-internal:zirgulis/add-offline-logout-test
Nov 5, 2024
+78
−1
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,7 @@ | ||||||
import type {Mock} from 'jest-mock'; | ||||||
import type {OnyxEntry} from 'react-native-onyx'; | ||||||
import MockedOnyx from 'react-native-onyx'; | ||||||
import * as App from '@libs/actions/App'; | ||||||
import CONST from '@src/CONST'; | ||||||
import OnyxUpdateManager from '@src/libs/actions/OnyxUpdateManager'; | ||||||
import * as PersistedRequests from '@src/libs/actions/PersistedRequests'; | ||||||
|
@@ -12,6 +14,7 @@ import * as MainQueue from '@src/libs/Network/MainQueue'; | |||||
import * as NetworkStore from '@src/libs/Network/NetworkStore'; | ||||||
import NetworkConnection from '@src/libs/NetworkConnection'; | ||||||
import ONYXKEYS from '@src/ONYXKEYS'; | ||||||
import type {Session as OnyxSession} from '@src/types/onyx'; | ||||||
import type ReactNativeOnyxMock from '../../__mocks__/react-native-onyx'; | ||||||
import * as TestHelper from '../utils/TestHelper'; | ||||||
import waitForBatchedUpdates from '../utils/waitForBatchedUpdates'; | ||||||
|
@@ -50,7 +53,7 @@ afterEach(() => { | |||||
}); | ||||||
|
||||||
describe('NetworkTests', () => { | ||||||
test('failing to reauthenticate while offline should not log out user', () => { | ||||||
test('failing to reauthenticate should not log out user', () => { | ||||||
// Given a test user login and account ID | ||||||
const TEST_USER_LOGIN = '[email protected]'; | ||||||
const TEST_USER_ACCOUNT_ID = 1; | ||||||
|
@@ -130,6 +133,80 @@ describe('NetworkTests', () => { | |||||
}); | ||||||
}); | ||||||
|
||||||
test('failing to reauthenticate while offline should not log out user', async () => { | ||||||
const TEST_USER_LOGIN = '[email protected]'; | ||||||
const TEST_USER_ACCOUNT_ID = 1; | ||||||
|
||||||
let session: OnyxEntry<OnyxSession>; | ||||||
Onyx.connect({ | ||||||
key: ONYXKEYS.SESSION, | ||||||
callback: (val) => (session = val), | ||||||
}); | ||||||
|
||||||
Onyx.connect({ | ||||||
key: ONYXKEYS.NETWORK, | ||||||
}); | ||||||
|
||||||
await TestHelper.signInWithTestUser(TEST_USER_ACCOUNT_ID, TEST_USER_LOGIN); | ||||||
await waitForBatchedUpdates(); | ||||||
|
||||||
expect(session?.authToken).not.toBeUndefined(); | ||||||
|
||||||
// Turn off the network | ||||||
await Onyx.set(ONYXKEYS.NETWORK, {isOffline: true}); | ||||||
|
||||||
const mockedXhr = jest.fn(); | ||||||
mockedXhr | ||||||
// Call ReconnectApp with an expired token | ||||||
.mockImplementationOnce(() => | ||||||
Promise.resolve({ | ||||||
jsonCode: CONST.JSON_CODE.NOT_AUTHENTICATED, | ||||||
}), | ||||||
) | ||||||
// // Call Authenticate | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
.mockImplementationOnce(() => | ||||||
Promise.resolve({ | ||||||
jsonCode: CONST.JSON_CODE.SUCCESS, | ||||||
authToken: 'newAuthToken', | ||||||
}), | ||||||
) | ||||||
// // Call ReconnectApp again, it should connect with a new token | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
.mockImplementationOnce(() => | ||||||
Promise.resolve({ | ||||||
jsonCode: CONST.JSON_CODE.SUCCESS, | ||||||
}), | ||||||
); | ||||||
|
||||||
HttpUtils.xhr = mockedXhr; | ||||||
|
||||||
// Initiate the requests | ||||||
App.confirmReadyToOpenApp(); | ||||||
App.reconnectApp(); | ||||||
await waitForBatchedUpdates(); | ||||||
|
||||||
// Turn the network back online | ||||||
await Onyx.set(ONYXKEYS.NETWORK, {isOffline: false}); | ||||||
|
||||||
// Filter requests results by request name | ||||||
const reconnectResults = (HttpUtils.xhr as Mock).mock.results.filter((_, index) => (HttpUtils.xhr as Mock)?.mock?.calls?.at(index)?.[0] === 'ReconnectApp'); | ||||||
const authenticateResults = (HttpUtils.xhr as Mock).mock.results.filter((_, index) => (HttpUtils.xhr as Mock)?.mock?.calls?.at(index)?.[0] === 'Authenticate'); | ||||||
|
||||||
// Get the response code of Authenticate call | ||||||
const authenticateResponse = await (authenticateResults?.at(0)?.value as Promise<{jsonCode: string}>); | ||||||
|
||||||
// Get the response code of the second Reconnect call | ||||||
const reconnectResponse = await (reconnectResults?.at(1)?.value as Promise<{jsonCode: string}>); | ||||||
|
||||||
// Authenticate request should return 200 | ||||||
expect(authenticateResponse.jsonCode).toBe(CONST.JSON_CODE.SUCCESS); | ||||||
|
||||||
// The second ReconnectApp should return 200 | ||||||
expect(reconnectResponse.jsonCode).toBe(CONST.JSON_CODE.SUCCESS); | ||||||
|
||||||
// check if the user is still logged in | ||||||
expect(session?.authToken).not.toBeUndefined(); | ||||||
}); | ||||||
|
||||||
test('consecutive API calls eventually succeed when authToken is expired', () => { | ||||||
// Given a test user login and account ID | ||||||
const TEST_USER_LOGIN = '[email protected]'; | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this part of the description because this test doesn't turn off the network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay so this happens when the user is online, cool no problem with the change