-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace Feed - update details cardName to use full name instead of 4 digits #52151
Conversation
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment was marked as abuse.
This comment was marked as abuse.
@DylanDylann will update today the PR with **** |
@waterim Is this ready? |
@DylanDylann yes |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2024-11-08.at.01.36.04.mov |
@mountiny Can you please check @VickyStash comment, what should I do with that? |
@waterim lets not change those. Its for direct feed and that is just handled a bit differently |
Co-authored-by: Vit Horacek <[email protected]>
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.60-0 🚀
|
Tested and verified we're now showing 10 digits of the card on the card details page instead of only the last 4 digits. |
I do have one question about how the new dot pattern is appearing on the card list, but i don't think it is a blocker/not sure it is related to this PR. |
@@ -75,7 +76,7 @@ function ConfirmationStep({policyID, backTo}: ConfirmationStepProps) { | |||
/> | |||
<MenuItemWithTopDescription | |||
description={translate('workspace.companyCards.card')} | |||
title={data?.cardNumber} | |||
title={CardUtils.maskCardNumber(data?.cardNumber ?? '')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem is known before and we will handle it separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising, @waterim can you handle it in your next PR please?
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.60-3 🚀
|
Details
Fixed Issues
$ #51912
PROPOSAL: N/A
Tests
Offline tests
Same as tests
QA Steps
None
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos