Workspace Feed - Use full cardsList instead of user cardList #52152

waterim · 2024-11-06T22:55:32Z

Details

Fixed Issues

$ #51914
PROPOSAL: N/A

Tests

Open any workspace
Enable Company Cards
Click company cards
Click on the employed cards assigned

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

None

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

melvin-bot · 2024-11-06T22:55:37Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-11-07T11:29:42Z

src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

-    const card = allBankCards?.[cardID];
+    const [lastSelectedFeed] = useOnyx(`${ONYXKEYS.COLLECTION.LAST_SELECTED_FEED}${policyID}`);
+    const [cardFeeds] = useOnyx(`${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${workspaceAccountID}`);
+    const selectedFeed = CardUtils.getSelectedFeed(lastSelectedFeed, cardFeeds);


This wont work for the direct feeds will it? @waterim @DylanDylann as those are saved elsewhere

It worked for both direct feed and company feed

VickyStash · 2024-11-07T12:35:21Z

@waterim I think I by accident created the same PR... 🤦‍♀️
Thought it's simplified a little, could you take a look?

waterim · 2024-11-07T12:39:12Z

@VickyStash yeah, this makes sense and closes this ticket
I can do your change here

mountiny · 2024-11-07T12:41:06Z

Vicky accidentally made a better PR than you if I understood her right 🧌

waterim · 2024-11-07T12:42:20Z

@mountiny haha, yes, more generic data fetching :D

waterim · 2024-11-07T12:45:24Z

@mountiny Both solutions should work, but I would like to leave more generic as @VickyStash suggested

allgandalf · 2024-11-07T12:56:26Z

should i copy my checklist from that PR? 🤣

DylanDylann · 2024-11-07T13:08:42Z

For safety, I think we should verify that the bank field on the card matches the feed name or not. On the FE, the bank field only has string type.

DylanDylann · 2024-11-07T13:12:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-11-07.at.15.49.39.mov

MacOS: Desktop

waterim · 2024-11-07T13:23:03Z

@DylanDylann updated

DylanDylann · 2024-11-07T13:43:21Z

@waterim Let's revert this commit. I just checked and everything looks safe

DylanDylann · 2024-11-07T13:43:40Z

This check will become redundant

waterim · 2024-11-07T17:27:34Z

@DylanDylann reverted

allgandalf · 2024-11-07T19:29:41Z

Okay now the PR is same as the one closed 🤣

mountiny

Thanks!

OSBotify · 2024-11-08T13:04:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-11T18:40:44Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

joekaufmanexpensify · 2024-11-11T22:42:16Z

Verified I'm now able to access the card details page for cards assigned to others.

github-actions · 2024-11-13T00:44:13Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.60-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

use full cardsList instead of user cardList

72b511c

waterim requested a review from a team as a code owner November 6, 2024 22:55

melvin-bot bot requested review from DylanDylann and removed request for a team November 6, 2024 22:55

DylanDylann approved these changes Nov 7, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny November 7, 2024 08:56

mountiny assigned waterim Nov 7, 2024

mountiny added the InternalQA This pull request required internal QA label Nov 7, 2024

mountiny reviewed Nov 7, 2024

View reviewed changes

use bankCards

5f3a4c7

VickyStash mentioned this pull request Nov 7, 2024

[Workspace Feeds] Fix not found display on the company card details page #52107

Closed

49 tasks

mountiny previously approved these changes Nov 7, 2024

View reviewed changes

add verification for bank

c271649

waterim dismissed mountiny’s stale review via c271649 November 7, 2024 13:22

revert reduntant check

397cb8d

DylanDylann approved these changes Nov 7, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny November 7, 2024 17:54

mountiny approved these changes Nov 8, 2024

View reviewed changes

mountiny merged commit bd880d1 into Expensify:main Nov 8, 2024
17 checks passed

github-actions bot mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-21] Deploy Checklist: New Expensify 2024-11-11 #52320

Closed

95 tasks

mountiny mentioned this pull request Nov 12, 2024

[HOLD for payment 2024-11-20] [Workspace feeds] "Not here" message shown when trying to access card details page for cards assigned to other employees. #51914

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Workspace Feed - Use full cardsList instead of user cardList #52152

Workspace Feed - Use full cardsList instead of user cardList #52152

waterim commented Nov 6, 2024

melvin-bot bot commented Nov 6, 2024

mountiny Nov 7, 2024

waterim Nov 7, 2024

DylanDylann Nov 7, 2024

VickyStash commented Nov 7, 2024

waterim commented Nov 7, 2024

mountiny commented Nov 7, 2024

waterim commented Nov 7, 2024

waterim commented Nov 7, 2024

allgandalf commented Nov 7, 2024

DylanDylann commented Nov 7, 2024

DylanDylann commented Nov 7, 2024

waterim commented Nov 7, 2024

DylanDylann commented Nov 7, 2024

DylanDylann commented Nov 7, 2024

waterim commented Nov 7, 2024

allgandalf commented Nov 7, 2024

mountiny left a comment

OSBotify commented Nov 8, 2024

github-actions bot commented Nov 11, 2024

joekaufmanexpensify commented Nov 11, 2024

github-actions bot commented Nov 13, 2024

Workspace Feed - Use full cardsList instead of user cardList #52152

Workspace Feed - Use full cardsList instead of user cardList #52152

Conversation

waterim commented Nov 6, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 6, 2024

mountiny Nov 7, 2024

Choose a reason for hiding this comment

waterim Nov 7, 2024

Choose a reason for hiding this comment

DylanDylann Nov 7, 2024

Choose a reason for hiding this comment

VickyStash commented Nov 7, 2024

waterim commented Nov 7, 2024

mountiny commented Nov 7, 2024

waterim commented Nov 7, 2024

waterim commented Nov 7, 2024

allgandalf commented Nov 7, 2024

DylanDylann commented Nov 7, 2024

DylanDylann commented Nov 7, 2024

Reviewer Checklist

Screenshots/Videos

waterim commented Nov 7, 2024

DylanDylann commented Nov 7, 2024

DylanDylann commented Nov 7, 2024

waterim commented Nov 7, 2024

allgandalf commented Nov 7, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 8, 2024

github-actions bot commented Nov 11, 2024

joekaufmanexpensify commented Nov 11, 2024

github-actions bot commented Nov 13, 2024