-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO QA - Create assign-a-task page #52229
Conversation
Hi @rlinoz - I'm adding a new section to https://help.expensify.com/new-expensify/hubs/chat/ I hope the formatting is correct, if not, please feel free to correct me! Thanks! |
@jliexpensify I think the only thing missing is the extension of the file, which should be |
Hmm is this correct @rlinoz? If not...yes, would love an assist 😄 |
A preview of your ExpensifyHelp changes have been deployed to https://4be689c2.helpdot.pages.dev ⚡️ |
Yeah, that is perfect, thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.60-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.60-3 🚀
|
Explanation of Change
Fixed Issues
$
PROPOSAL:
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.