[No QA] Remove unused parameter for short lived authToken #52501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
DylanDylann
and removed request for
a team
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
DylanDylann
approved these changes
Nov 14, 2024
src/libs/actions/Session/index.ts
Outdated
| @@ -570,12 +570,7 @@ function beginGoogleSignIn(token: string | null) { | |||
| */ | |||
| function signInWithShortLivedAuthToken(email: string, authToken: string) { | |||
There was a problem hiding this comment.
Suggested change
| function signInWithShortLivedAuthToken(email: string, authToken: string) { | |
| function signInWithShortLivedAuthToken(authToken: string) { |
There was a problem hiding this comment.
Thanks for pointing that out. Removing this param resulted in a little bit more cleanup.
|
@rafecolton Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #52528. |
iwiznia
previously approved these changes
Nov 14, 2024
DylanDylann
approved these changes
Nov 14, 2024
|
@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
rafecolton
previously approved these changes
Nov 14, 2024
|
We got some eslint failures |
|
ahh, we need to migrate to useOnyx in some changed files cc @tgolen |
|
OK, I'm not sure if I will get to this today or not, but I'll get it updated! |
|
OK, looks like it's all set now! |
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.
rafecolton
reviewed
Nov 15, 2024
| const {initialURL} = useContext(InitialURLContext); | ||
| const [session] = useOnyx(ONYXKEYS.SESSION); | ||
| const [account = {}] = useOnyx(ONYXKEYS.ACCOUNT); | ||
| const isAccountLoading = account?.isLoading; |
There was a problem hiding this comment.
Does isLoading need to be null coalesced or defaulted in line 25?
|
|
||
| function SAMLSignInPage({credentials, account}: SAMLSignInPageProps) { | ||
| function SAMLSignInPage() { | ||
| const [account] = useOnyx(ONYXKEYS.ACCOUNT); |
There was a problem hiding this comment.
Do we need a default for isLoading or a null coalesce below? Why did you do [account = {}] above and [account] here?
There was a problem hiding this comment.
No, we don't need that (explained in my other comment). The default object was just some copy/paste from other code that I will remove.
DylanDylann
reviewed
Nov 18, 2024
src/pages/LogOutPreviousUserPage.tsx
Outdated
Comment on lines
26
to
27
| const [account = {}] = useOnyx(ONYXKEYS.ACCOUNT); | ||
| const isAccountLoading = account?.isLoading; |
There was a problem hiding this comment.
Yeah, agree we should make it as before. Wdyt about this suggestion?
Suggested change
| const [account = {}] = useOnyx(ONYXKEYS.ACCOUNT); | |
| const isAccountLoading = account?.isLoading; | |
| const [account] = useOnyx(ONYXKEYS.ACCOUNT); | |
| const isAccountLoading = account?.isLoading ?? false; |
There was a problem hiding this comment.
I can remove the default value for account, but it doesn't need null coalesce because the logic is only doing a falsy check, so undefined would be treated the same as false anyway.
tgolen
commented
Nov 18, 2024
src/pages/LogOutPreviousUserPage.tsx
Outdated
Comment on lines
26
to
27
| const [account = {}] = useOnyx(ONYXKEYS.ACCOUNT); | ||
| const isAccountLoading = account?.isLoading; |
There was a problem hiding this comment.
I can remove the default value for account, but it doesn't need null coalesce because the logic is only doing a falsy check, so undefined would be treated the same as false anyway.
|
|
||
| function SAMLSignInPage({credentials, account}: SAMLSignInPageProps) { | ||
| function SAMLSignInPage() { | ||
| const [account] = useOnyx(ONYXKEYS.ACCOUNT); |
There was a problem hiding this comment.
No, we don't need that (explained in my other comment). The default object was just some copy/paste from other code that I will remove.
rafecolton
approved these changes
Nov 18, 2024
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
54 tasks
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/rafecolton in version: 9.0.64-0 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.64-4 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @iwiznia @jasperhuangg
Explanation of Change
This param was removed because we stopped deleting these logins on the server.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/443960
Tests
None, since this is already being tested with https://github.com/Expensify/Web-Expensify/pull/44408 and removing the param does not change any functionality
Offline tests
None
QA Steps
None, since this is already being tested with https://github.com/Expensify/Web-Expensify/pull/44408 and removing the param does not change any functionality
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop