Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Let's get you set up 🔧 " line during onboarding #52728

Merged
merged 10 commits into from
Nov 19, 2024
Merged

Remove "Let's get you set up 🔧 " line during onboarding #52728

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b27f20d
Update CONST.ts
jamesdeanexpensify Nov 18, 2024
c701612
Update Report.ts
jamesdeanexpensify Nov 18, 2024
a5a35af
Update Report.ts
jamesdeanexpensify Nov 19, 2024
b7f331e
Update Report.ts
jamesdeanexpensify Nov 19, 2024
f8c3d95
Update Report.ts
jamesdeanexpensify Nov 19, 2024
0dc28f1
Update src/libs/actions/Report.ts
jamesdeanexpensify Nov 19, 2024
601b4e0
Update src/libs/actions/Report.ts
jamesdeanexpensify Nov 19, 2024
ce49dc3
Update src/libs/actions/Report.ts
jamesdeanexpensify Nov 19, 2024
c5afbcf
Update src/libs/actions/Report.ts
jamesdeanexpensify Nov 19, 2024
23c6802
Run prettier
marcaaron Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4821,7 +4821,6 @@ const CONST = {

WELCOME_VIDEO_URL: `${CLOUDFRONT_URL}/videos/intro-1280.mp4`,

ONBOARDING_INTRODUCTION: 'Let’s get you set up 🔧',
ONBOARDING_CHOICES: {...onboardingChoices},
SELECTABLE_ONBOARDING_CHOICES: {...selectableOnboardingChoices},
COMBINED_TRACK_SUBMIT_ONBOARDING_CHOICES: {...combinedTrackSubmitOnboardingChoices},
Expand Down
5 changes: 1 addition & 4 deletions src/libs/actions/Report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3499,9 +3499,9 @@
const {reportID: targetChatReportID = '', policyID: targetChatPolicyID = ''} = targetChatReport ?? {};

// Introductory message
jamesdeanexpensify marked this conversation as resolved.
Show resolved Hide resolved
const introductionComment = ReportUtils.buildOptimisticAddCommentReportAction(CONST.ONBOARDING_INTRODUCTION, undefined, actorAccountID);
const introductionComment = ReportUtils.buildOptimisticAddCommentReportAction(undefined, actorAccountID);

Check failure on line 3502 in src/libs/actions/Report.ts

View workflow job for this annotation

GitHub Actions / typecheck 

Argument of type 'number' is not assignable to parameter of type 'FileObject | undefined'.
jamesdeanexpensify marked this conversation as resolved.
Show resolved Hide resolved
const introductionCommentAction: OptimisticAddCommentReportAction = introductionComment.reportAction;
jamesdeanexpensify marked this conversation as resolved.
Show resolved Hide resolved
const introductionMessage: AddCommentOrAttachementParams = {

Check failure on line 3504 in src/libs/actions/Report.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

'introductionMessage' is assigned a value but never used
jamesdeanexpensify marked this conversation as resolved.
Show resolved Hide resolved
reportID: targetChatReportID,
reportActionID: introductionCommentAction.reportActionID,
reportComment: introductionComment.commentText,
marcaaron marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -3753,7 +3753,6 @@
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${targetChatReportID}`,
value: {
[introductionCommentAction.reportActionID]: introductionCommentAction as ReportAction,
[textCommentAction.reportActionID]: textCommentAction as ReportAction,
},
},
Expand All @@ -3776,7 +3775,6 @@
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${targetChatReportID}`,
value: {
[introductionCommentAction.reportActionID]: {pendingAction: null},
[textCommentAction.reportActionID]: {pendingAction: null},
},
});
Expand Down Expand Up @@ -3866,8 +3864,7 @@
});
}

const guidedSetupData: GuidedSetupData = [

Check failure on line 3867 in src/libs/actions/Report.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Replace `⏎········{type:·'message',·...textMessage},⏎····` with `{type:·'message',·...textMessage}`
{type: 'message', ...introductionMessage},
{type: 'message', ...textMessage},
];

Expand Down
Loading