[NO QA] feat: Step 3 logic #52954

MrMuzyk · 2024-11-22T11:01:26Z

Explanation of Change

Implements validation, API, navigation and other logic for step 3 in global reimbursements flow

Fixed Issues

$ #50905
PROPOSAL:

Tests

Change workspace currency to EUR, GBP, CAD or AUD
Enable workflows for the workspace
Open workflows
Try to connect a bank account
Go to the third step
Fill out all the forms and send data

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

android.web.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.safari.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…-api-integration' into feat/step-3-logic # Conflicts: # src/libs/API/types.ts

…-api-integration' into feat/step-3-logic

…stack-internal/Expensify-App into feat/step-3-logic

hungvu193 · 2025-01-15T08:48:38Z

I think we changed the eslint rules recently, can you address the lint? @MrMuzyk

MrMuzyk · 2025-01-15T08:58:14Z

On it

MrMuzyk · 2025-01-15T15:13:42Z

@hungvu193 Looks like the issue with missing policyID is fixed - AUD accounts should pass too. Eslint issues are fixed as well. I've talked with Max and I've added 2 missing fields but at the moment I'm getting "message": "500 Unhandled Exception", Hopefully we will sort this out soon, we're close

hungvu193 · 2025-01-16T07:50:21Z

@hungvu193 Looks like the issue with missing policyID is fixed - AUD accounts should pass too. Eslint issues are fixed as well. I've talked with Max and I've added 2 missing fields but at the moment I'm getting "message": "500 Unhandled Exception", Hopefully we will sort this out soon, we're close

Yeah, I got the same 500 issue with you. Let me know when. it's resolved, I think this PR is ready to merge.

MrMuzyk · 2025-01-21T09:02:47Z

@hungvu193 Hey, latest fix for BE made it live and now Step 3 is working correctly for me. Let's close this one today 🚀

hungvu193 · 2025-01-21T14:11:43Z

Awesome. I'll test it today!

hungvu193 · 2025-01-21T17:00:13Z

Nice, it's working well 🚀

Screen.Recording.2025-01-21.at.23.56.48.mov

hungvu193 · 2025-01-21T17:41:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-22.at.01.07.29.mov

Android: mWeb Chrome

Screen.Recording.2025-01-22.at.00.36.37.mov

iOS: Native

Screen.Recording.2025-01-22.at.00.18.39.mov

iOS: mWeb Safari

Screen.Recording.2025-01-22.at.00.18.25.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-21.at.23.56.48.mov

MacOS: Desktop

Screen.Recording.2025-01-22.at.00.00.01.mov

madmax330

Just one small comment 😅

src/ONYXKEYS.ts

OSBotify · 2025-01-22T09:39:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:26:53Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-28T01:50:17Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

MrMuzyk added 22 commits November 15, 2024 11:21

feat: step 3 logic

9e0e6aa

feat: break

5669047

feat: break

e81d66e

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

8ea2550

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

c895304

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

979401b

feat: proper params

2da4876

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

8a99d20

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

93396c0

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

dbb6f2a

Merge remote-tracking branch 'refs/remotes/origin/feature/GR-step-two…

2331ba8

…-api-integration' into feat/step-3-logic # Conflicts: # src/libs/API/types.ts

testing

52c6562

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

d135e65

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

90f0695

Merge remote-tracking branch 'refs/remotes/origin/feature/GR-step-two…

0bdbce8

…-api-integration' into feat/step-3-logic

feat: picklists

b63de9b

fix: small fix

39b8cf5

Merge branch 'feature/GR-step-two-api-integration' of github.com:call…

19285e0

…stack-internal/Expensify-App into feat/step-3-logic

Merge branch 'feature/GR-step-two-api-integration' of github.com:call…

720299e

…stack-internal/Expensify-App into feat/step-3-logic

Merge branch 'feature/GR-step-two-api-integration' of github.com:call…

a308516

…stack-internal/Expensify-App into feat/step-3-logic

Merge branch 'feature/GR-step-two-api-integration' of github.com:call…

5a2671f

…stack-internal/Expensify-App into feat/step-3-logic

feat: hold

3f76d59

MrMuzyk mentioned this pull request Dec 16, 2024

[GR Phase 3] Step 4 - navigation, default data, logic and API call to save it #50906

Open

MrMuzyk added 7 commits December 17, 2024 09:30

Merge branch 'feature/GR-step-two-api-integration' of github.com:call…

0dd6b81

…stack-internal/Expensify-App into feat/step-3-logic

feat: average reimbursement

dc47fe2

Merge branch 'feature/GR-step-two-api-integration' of github.com:call…

63b2979

…stack-internal/Expensify-App into feat/step-3-logic

Merge branch 'feature/GR-step-two-api-integration' of github.com:call…

9f3fba1

…stack-internal/Expensify-App into feat/step-3-logic

feat: API error

7974bd6

Merge branch 'feature/GR-step-two-api-integration' of github.com:call…

285a000

…stack-internal/Expensify-App into feat/step-3-logic

fix: revert default nonusd step

81a07f5

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

28e17ec

MrMuzyk added 4 commits January 15, 2025 10:21

fix: linting

e18a8f8

fix: more linter changes

139266c

fix: final fix

790b0bb

fix: missing fields

c9d1663

MrMuzyk added 5 commits January 17, 2025 09:49

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

b06196e

fix: change purpose value

f0763c2

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

c82f196

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

c8441ca

Merge branch 'main' of github.com:Expensify/App into feat/step-3-logic

7f4e714

hungvu193 approved these changes Jan 21, 2025

View reviewed changes

melvin-bot bot requested a review from madmax330 January 21, 2025 18:08

madmax330 reviewed Jan 21, 2025

View reviewed changes

src/ONYXKEYS.ts Outdated Show resolved Hide resolved

fix: typo

937c8ec

MrMuzyk requested a review from madmax330 January 22, 2025 07:39

madmax330 approved these changes Jan 22, 2025

View reviewed changes

madmax330 merged commit a0836a9 into Expensify:main Jan 22, 2025
17 checks passed

github-actions bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

melvin-bot bot mentioned this pull request Jan 28, 2025

[HOLD for payment 2025-02-04] [GR Phase 3] Step 3 - navigation, default data, logic and API call to save it #50905

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA] feat: Step 3 logic #52954

[NO QA] feat: Step 3 logic #52954

MrMuzyk commented Nov 22, 2024 •

edited

Loading

hungvu193 commented Jan 15, 2025

MrMuzyk commented Jan 15, 2025

MrMuzyk commented Jan 15, 2025 •

edited

Loading

hungvu193 commented Jan 16, 2025

MrMuzyk commented Jan 21, 2025

hungvu193 commented Jan 21, 2025

hungvu193 commented Jan 21, 2025

hungvu193 commented Jan 21, 2025 •

edited

Loading

madmax330 left a comment

OSBotify commented Jan 22, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 28, 2025

[NO QA] feat: Step 3 logic #52954

[NO QA] feat: Step 3 logic #52954

Conversation

MrMuzyk commented Nov 22, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

hungvu193 commented Jan 15, 2025

MrMuzyk commented Jan 15, 2025

MrMuzyk commented Jan 15, 2025 • edited Loading

hungvu193 commented Jan 16, 2025

MrMuzyk commented Jan 21, 2025

hungvu193 commented Jan 21, 2025

hungvu193 commented Jan 21, 2025

hungvu193 commented Jan 21, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

madmax330 left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 22, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 28, 2025

MrMuzyk commented Nov 22, 2024 •

edited

Loading

MrMuzyk commented Jan 15, 2025 •

edited

Loading

hungvu193 commented Jan 21, 2025 •

edited

Loading