-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert 'jules-updateValidatePageInVBAFlow' #5301
Conversation
CC @roryabraham & @AndrewGable, to ensure I'm following this guide correctly. |
@roryabraham this is the part that isn't clear to me:
Do I just need to mention that this is a revert PR? Don't I also need to add the cherry-pick label so this PR skips the deploy lock check? |
Yep |
|
@Julesssss That SO is out-of-date, updating it now. We'll want to CP this. |
1 similar comment
@Julesssss That SO is out-of-date, updating it now. We'll want to CP this. |
I resolved the conflict, can you review again please? + @roryabraham |
HOLD for now. There's a chance this revert was unnecessary. I'm looking into the possibility that the regression was already occurring here. |
Okay, we're now pretty certain that issue did already exist. Closing this PR, thanks for the help all! |
Reverts this PR, which introduced this bug. As this is now a prod deploy blocker we need to merge this ASAP to unblock N6.
n6-hold
is not relevant here, this revert PR resolves a deployBlocker which will delay n6.Fixed Issues
$ #5290
Tests | QA Steps
N/A