Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selection list scrolling after closing context menu #53120

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix selection list scrolling after closing context menu #53120

wants to merge 10 commits into from
+40 −8

Conversation

QichenZhu
Copy link
Contributor

@QichenZhu QichenZhu commented Nov 26, 2024 •
edited
Loading

Explanation of Change

Fixed Issues

$ #50639
PROPOSAL: #50639 (comment)

Tests

Precondition: A workspace with Category feature enabled and a sufficient number of categories that cannot be displayed in one screen.

  1. Open New Expensify.
  2. Go to Settings > Workspaces and select the workspace that meets the precondition.
  3. Tap Categories.
  4. Scroll to the middle of the category list.
  5. On narrow screens, long-press an item and tap Select. On wide screens, click the checkbox.
  6. Verify that the scroll position does not change.
  • Verify that no errors appear in the JS console

Offline tests

Precondition: A workspace with Category feature enabled and a sufficient number of categories that cannot be displayed in one screen.

  1. Open New Expensify.
  2. Go to Settings > Workspaces and select the workspace that meets the precondition.
  3. Tap Categories.
  4. Scroll to the middle of the category list.
  5. On narrow screens, long-press an item and tap Select. On wide screens, click the checkbox.
  6. Verify that the scroll position does not change.

QA Steps

Precondition: A workspace with Category feature enabled and a sufficient number of categories that cannot be displayed in one screen.

  1. Open New Expensify.
  2. Go to Settings > Workspaces and select the workspace that meets the precondition.
  3. Tap Categories.
  4. Scroll to the middle of the category list.
  5. On narrow screens, long-press an item and tap Select. On wide screens, click the checkbox.
  6. Verify that the scroll position does not change.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-native.mp4
Android: mWeb Chrome
android-web.mp4
iOS: Native
ios-native.mp4
iOS: mWeb Safari
ios-web.mp4
MacOS: Chrome / Safari
mac-web.mov
MacOS: Desktop
mac-desktop.mov

@QichenZhu QichenZhu changed the title Fix/50639 Fix selection list scrolling after closing context menu Nov 26, 2024
@QichenZhu QichenZhu marked this pull request as ready for review November 26, 2024 12:06
@QichenZhu QichenZhu requested a review from a team as a code owner November 26, 2024 12:06
@melvin-bot melvin-bot bot requested a review from eVoloshchak November 26, 2024 12:06
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 26, 2024

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team November 26, 2024 12:06
@QichenZhu

This comment was marked as resolved.

Sign in to view
@QichenZhu
Copy link
Contributor Author

QichenZhu commented Dec 4, 2024 •
edited
Loading

@eVoloshchak What do you think about this comment?

@eVoloshchak
Copy link
Contributor

eVoloshchak commented Dec 5, 2024 •
edited
Loading

Currently, when a partially visible item is selected in Chrome on Android, it scrolls to reveal the full item.
Would you prefer to keep this behavior or find a way to prevent it from moving?

Ultimately, the goal is to have identical behavior across all platforms. If the scroll doesn't occur on other platforms, it shouldn't occur on mWeb Android

Could you also take a look at why the PR Author Checklist check is failing?

@QichenZhu QichenZhu marked this pull request as draft December 9, 2024 03:06
@QichenZhu
Copy link
Contributor Author

I adjusted the header height in selection mode on the categories page. Could @Expensify/design team review it?

Before After
Before After

@QichenZhu QichenZhu marked this pull request as ready for review December 9, 2024 06:15
@QichenZhu
Copy link
Contributor Author

QichenZhu commented Dec 9, 2024 •
edited
Loading

Note that there is an existing issue on the main branch. The context menu only pops up after release, not on press.

Update: After merging main, the above issue goes away, but npm run ios fails. I have to revert 7e50692 to build.

@trjExpensify trjExpensify mentioned this pull request Dec 16, 2024
Open
8 tasks
@QichenZhu
Copy link
Contributor Author

Retested and looks good except for the iOS build issue not related to this PR.

@eVoloshchak Could you review this when you have a chance? Thanks!

Screenshots/Videos

Android: Native
android-native.mp4
Android: mWeb Chrome
android-web.mp4
iOS: Native
ios-native.mp4
iOS: mWeb Safari
ios-web.mp4
MacOS: Chrome / Safari
mac-web.mov
MacOS: Desktop
mac-desktop.mov

@QichenZhu
Copy link
Contributor Author

Bump @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eVoloshchak eVoloshchak eVoloshchak left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QichenZhu @eVoloshchak